mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/gopls/internal/lsp/source
History
Robert Findley b2533141c6 gopls/internal/lsp/cache: add support for loading standalone main files 
Add support in gopls for working on "standalone main files", which are
Go source files that should be treated as standalone packages.
Standalone files are identified by a specific build tag, which may be
configured via the new standaloneTags setting. For example, it is common
to use the directive "//go:build ignore" to colocate standalone files
with other package files.

Specifically,
- add a new loadScope interface for use in snapshot.load, to add a bit
  of type safety
- add a new standaloneTags setting to allow configuring the set of build
  constraints that define standalone main files
- add an isStandaloneFile function that detects standalone files based
  on build constraints
- implement the loading of standalone files, by querying go/packages for
  the standalone file path
- rewrite getOrLoadIDsForURI, which had inconsistent behavior with
  respect to error handling and the experimentalUseInvalidMetadata
  setting
- update the WorkspaceSymbols handler to properly format
  command-line-arguments packages
- add regression tests for LSP behavior with standalone files, and for
  dynamic configuration of standalone files

Fixes golang/go#49657

Change-Id: I7b79257a984a87b67e476c32dec3c122f9bbc636
Reviewed-on: https://go-review.googlesource.com/c/tools/+/441877
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
 		2022-10-13 15:07:40 +00:00
..
completion gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
add_import.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
api_json.go gopls/internal/lsp/cache: add support for loading standalone main files 2022-10-13 15:07:40 +00:00
call_hierarchy.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
code_lens.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
comment.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
comment_go118.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
comment_go118_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
diagnostics.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
extract.go all: fix a few function names on comments 2022-10-10 13:22:38 +00:00
fix.go gopls/internal/span: some cleanups 2022-10-13 13:15:27 +00:00
folding_range.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
format.go gopls/internal/lsp/source: sort protocol edits 2022-10-11 18:07:12 +00:00
format_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
gc_annotations.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
highlight.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
hover.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
identifier.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
identifier_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
implementation.go gopls/internal/lsp/source: find references in test packages 2022-10-11 14:54:39 +00:00
inlay_hint.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
known_packages.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
options.go gopls/internal/lsp/cache: add support for loading standalone main files 2022-10-13 15:07:40 +00:00
options_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
references.go gopls/internal/lsp/source: find references in test packages 2022-10-11 14:54:39 +00:00
rename.go gopls/internal/lsp/source: find references in test packages 2022-10-11 14:54:39 +00:00
rename_check.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
signature_help.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
source_test.go internal/diff: ToUnified may fail 2022-10-07 15:16:55 +00:00
stub.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
symbols.go internal/lsp/source: derive document symbols from syntax alone 2022-09-23 13:51:08 +00:00
types_format.go gopls/internal/lsp/source: don't type-check in FindPackageFromPos 2022-10-05 17:57:07 +00:00
util.go gopls/internal/span: some cleanups 2022-10-13 13:15:27 +00:00
util_test.go gopls/internal/span: move internal/span into gopls 2022-10-07 14:50:44 +00:00
view.go gopls/internal/lsp/cache: add support for loading standalone main files 2022-10-13 15:07:40 +00:00
workspace_symbol.go gopls/internal/lsp/cache: add support for loading standalone main files 2022-10-13 15:07:40 +00:00
workspace_symbol_test.go gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00