Karthik Nayak d25f906682 internal/lsp: do not block on channel when there is an error ... In `internal/lsp/cmd.(*connection).diagnoseFiles`, when we request for `gopls/diagnoseFiles`, we are blocked on the channel even if there is an error. In such a scenario, we've reach a deadlock since. Avoid this by checking for error, existing if it exists and also closing the channel while we're at it. Fixes golang/go#46251 Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Change-Id: I4266ab3ac272a9ae3eac2084b70b6568b72c1984 GitHub-Last-Rev: 94bf2926a0f35d51d62643618a8072ef5a8b5225 GitHub-Pull-Request: golang/tools#324 Reviewed-on: https://go-review.googlesource.com/c/tools/+/329109 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>		2021-06-18 18:34:00 +00:00
..
analysisinternal	internal/lsp/fuzzy: fix return value on no match	2020-08-28 15:37:48 +00:00
apidiff	all: add copyright notices to files that are missing them	2021-01-06 17:23:47 +00:00
event	internal/lsp/debug: add a facility to track known bugs	2021-05-10 23:21:19 +00:00
fakenet	internal/fakenet: add a fake network connection	2020-05-27 14:27:59 +00:00
fastwalk	x/tools/internal/fastwalk: fixes "interrupted system call" error	2021-02-24 01:32:32 +00:00
gocommand	internal/gocommand: run 'go list' on the unsafe package when fetching release tags	2021-05-29 00:21:43 +00:00
gopathwalk	internal/imports: fix crash when adding stdlib imports	2020-08-13 17:47:04 +00:00
imports	go/packages/packagestest: make Export skip tests involving unsupported links	2021-06-02 19:23:16 +00:00
jsonrpc2	internal/jsonrpc2: remove unused invalidID constant	2021-02-04 15:49:51 +00:00
jsonrpc2_v2	internal/jsonrpc2_v2: make TestIdleTimeout pass on Plan 9	2021-06-02 15:04:26 +00:00
lsp	internal/lsp: do not block on channel when there is an error	2021-06-18 18:34:00 +00:00
memoize	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
packagesinternal	internal/lsp/cache: disable network for mod tidy diagnostics	2021-02-05 19:41:14 +00:00
proxydir	all: remove version-specific test files	2020-05-28 17:13:50 +00:00
span	internal/span: compute utf16 length directly	2021-05-20 14:08:36 +00:00
stack	internal/stack: add the leak test	2020-05-27 14:25:42 +00:00
testenv	internal/testenv: treat netbsd-arm*-bsiegert as slow builders	2021-06-02 19:26:46 +00:00
tool	internal/tool: avoid editorialization	2020-03-05 14:01:59 +00:00
typeparams	go/ast/astutil: fix panic when rewriting multi-argument type instances	2021-06-09 21:40:20 +00:00
typesinternal	internal/typesinternal: sync error codes with go1.16	2021-02-16 20:01:04 +00:00
xcontext	…