cf148f3d46
Currently, when converting a float (say float64), we use convT64 function. In the runtime convT64 expects a uint64 argument. In the compiler, convT64 is defined as taking an "any" argument (so it works with also uint64-like types such as [1]uint64). The "any" type is instantiated with the concrete type in walk. So the backend will see instances such as convT64([1]uint64). Currently, float64 is treated as uint64-like. So the backend will see convT64(float64). With a memory-based calling convention this is fine. With a register-based calling convention, however, it will pass the argument in a floating point register, whereas the runtime expects the argument in an integer register (as it is declared as uint64). To fix this, this CL introduces runtime functions convT32F and convT64F. They behave the same as convT32/convT64, but with a float argument. In the compiler, use convT32F/convT64F to convert float-like type to interface. With this, "GOEXPERIMENT=regabi,regabiargs go test math fmt" works. Updates #40724. Change-Id: I8b2e232096a95e4a7c4ab81795d77ef224ffaab3 Reviewed-on: https://go-review.googlesource.com/c/go/+/307232 Trust: Cherry Zhang <cherryyz@google.com> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Than McIntosh <thanm@google.com> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.