mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/test
History
Keith Randall cd9fd640db cmd/compile: don't allow NaNs in floating-point constant ops 
Trying this CL again, with a fixed test that allows platforms
to disagree on the exact behavior of converting NaNs.

We store 32-bit floating point constants in a 64-bit field, by
converting that 32-bit float to 64-bit float to store it, and convert
it back to use it.

That works for *almost* all floating-point constants. The exception is
signaling NaNs. The round trip described above means we can't represent
a 32-bit signaling NaN, because conversions strip the signaling bit.

To fix this issue, just forbid NaNs as floating-point constants in SSA
form. This shouldn't affect any real-world code, as people seldom
constant-propagate NaNs (except in test code).

Additionally, NaNs are somewhat underspecified (which of the many NaNs
do you get when dividing 0/0?), so when cross-compiling there's a
danger of using the compiler machine's NaN regime for some math, and
the target machine's NaN regime for other math. Better to use the
target machine's NaN regime always.

Update #36400

Change-Id: Idf203b688a15abceabbd66ba290d4e9f63619ecb
Reviewed-on: https://go-review.googlesource.com/c/go/+/221790
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
 		2020-03-04 04:49:54 +00:00
..
alias3.dir
…
bench
…
chan
…
closure3.dir
…
codegen cmd/compile: don't allow NaNs in floating-point constant ops 2020-03-04 04:49:54 +00:00
ddd2.dir
…
dwarf
…
fixedbugs runtime: print instruction bytes when reporting a SIGILL 2020-03-02 18:46:06 +00:00
import2.dir
…
import4.dir
…
interface
…
intrinsic.dir
…
ken
…
linkname.dir
…
method4.dir
…
oldescape_linkname.dir
…
retjmp.dir
…
runtime
…
stress
…
syntax cmd/compile/internal/syntax: better error when an assignment is used in value context 2020-02-21 22:57:52 +00:00
uintptrescapes.dir
…
64bit.go
…
235.go
…
README.md
…
alg.go
…
alias.go
…
alias1.go
…
alias2.go
…
alias3.go
…
align.go
…
append.go
…
append1.go
…
args.go
…
armimm.go
…
assign.go
…
assign1.go
…
atomicload.go
…
bigalg.go
…
bigmap.go
…
blank.go
…
blank1.go
…
bom.go
…
bombad.go
…
bounds.go
…
chancap.go
…
chanlinear.go
…
char_lit.go
…
char_lit1.go
…
checkbce.go
…
clearfat.go
…
closedchan.go
…
closure.go
…
closure1.go
…
closure2.go
…
closure3.go
…
closure4.go
…
cmp.go
…
cmp6.go
…
cmplx.go
…
cmplxdivide.c
…
cmplxdivide.go
…
cmplxdivide1.go
…
complit.go
…
complit1.go
…
compos.go
…
const.go
…
const1.go
…
const2.go
…
const3.go
…
const4.go
…
const5.go
…
const6.go
…
convT2X.go
…
convert.go
…
convert1.go
…
convert2.go
…
convert3.go
…
convlit.go
…
convlit1.go
…
copy.go
…
copy1.go
…
crlf.go
…
ddd.go
…
ddd1.go
…
ddd2.go
…
decl.go
…
declbad.go
…
defer.go
…
defererrcheck.go test: re-enable open-coded defer test on riscv64 2020-02-26 16:54:17 +00:00
deferfin.go
…
defernil.go
…
deferprint.go
…
deferprint.out
…
devirt.go
…
divide.go
…
divmod.go
…
empty.go
…
env.go
…
eof.go
…
eof1.go
…
escape.go
…
escape2.go
…
escape2n.go
…
escape3.go
…
escape4.go
…
escape5.go
…
escape_array.go
…
escape_calls.go
…
escape_closure.go
…
escape_field.go
…
escape_goto.go
…
escape_hash_maphash.go
…
escape_iface.go
…
escape_indir.go
…
escape_level.go
…
escape_map.go
…
escape_param.go
…
escape_runtime_atomic.go
…
escape_selfassign.go
…
escape_slice.go
…
escape_struct_param1.go
…
escape_struct_param2.go
…
escape_struct_return.go
…
escape_sync_atomic.go
…
escape_unsafe.go
…
fibo.go
…
finprofiled.go
…
float_lit.go
…
float_lit2.go
…
float_lit3.go
…
floatcmp.go
…
for.go
…
func.go
…
func1.go
…
func2.go
…
func3.go
…
func4.go
…
func5.go
…
func6.go
…
func7.go
…
func8.go
…
funcdup.go
…
funcdup2.go
…
gc.go
…
gc1.go
…
gc2.go
…
gcgort.go
…
gcstring.go
…
goprint.go
…
goprint.out
…
goto.go
…
heapsampling.go
…
helloworld.go
…
helloworld.out
…
if.go
…
import.go
…
import1.go
…
import2.go
…
import4.go
…
import5.go
…
import6.go
…
index.go
…
index0.go
…
index1.go
…
index2.go
…
indirect.go
…
indirect1.go
…
init.go
…
init1.go
…
initcomma.go
…
initempty.go
…
initialize.go
…
initializerr.go
…
initloop.go
…
inline.go
…
inline_big.go cmd/compile: output cost while inlining function with Debug['m'] > 1 2020-02-26 14:44:24 +00:00
inline_caller.go
…
inline_callers.go
…
inline_literal.go
…
inline_math_bits_rotate.go
…
inline_sync.go test: adjust tests for riscv64 2020-01-25 16:30:26 +00:00
inline_variadic.go
…
int_lit.go
…
intcvt.go
…
intrinsic.go
…
intrinsic_atomic.go
…
iota.go
…
label.go
…
label1.go
…
linkmain.go
…
linkmain_run.go
…
linkname.go
…
linkobj.go
…
linkx.go
…
linkx_run.go
…
literal.go
…
literal2.go
…
live.go cmd/compile,cmd/link: fix and re-enable open-coded defers on riscv64 2020-01-29 16:34:44 +00:00
live1.go
…
live2.go
…
live_syscall.go
…
locklinear.go
…
loopbce.go
…
makechan.go
…
makemap.go
…
makenew.go
…
mallocfin.go
…
map.go
…
map1.go
…
mapclear.go
…
maplinear.go
…
mergemul.go
…
method.go
…
method1.go
…
method2.go
…
method3.go
…
method4.go
…
method5.go
…
method6.go
…
method7.go
…
named.go
…
named1.go
…
nil.go
…
nilcheck.go
…
nilptr.go
…
nilptr2.go
…
nilptr3.go
…
nilptr4.go
…
nilptr5.go
…
nilptr5_aix.go
…
nilptr5_wasm.go
…
nilptr_aix.go
…
nosplit.go test: adjust tests for riscv64 2020-01-25 16:30:26 +00:00
notinheap.go
…
notinheap2.go
…
notinheap3.go
…
nowritebarrier.go
…
nul1.go
…
opt_branchlikely.go
…
parentype.go
…
peano.go
…
phiopt.go
…
print.go
…
print.out
…
printbig.go
…
printbig.out
…
prove.go cmd/compile: remove Greater* and Geq* generic integer ops 2020-02-26 13:11:53 +00:00
range.go
…
recover.go
…
recover1.go
…
recover2.go
…
recover3.go
…
recover4.go
…
recover5.go
…
reflectmethod1.go
…
reflectmethod2.go
…
reflectmethod3.go
…
reflectmethod4.go
…
rename.go
…
rename1.go
…
reorder.go
…
reorder2.go
…
retjmp.go
…
return.go
…
rotate.go
…
rotate0.go
…
rotate1.go
…
rotate2.go
…
rotate3.go
…
run.go test: clean up run.go 2020-02-24 16:13:21 +00:00
rune.go
…
runtime.go
…
shift1.go
…
shift2.go
…
sieve.go
…
sigchld.go
…
sigchld.out
…
simassign.go
…
sinit.go
…
sinit_run.go
…
sizeof.go
…
slice3.go
…
slice3err.go
…
slicecap.go
…
sliceopt.go
…
solitaire.go
…
stack.go
…
stackobj.go
…
stackobj2.go
…
stackobj3.go
…
strcopy.go
…
strength.go
…
string_lit.go
…
stringrange.go
…
struct0.go
…
switch.go
…
switch2.go
…
switch3.go
…
switch4.go
…
switch5.go
…
switch6.go
…
switch7.go
…
tinyfin.go
…
torture.go
…
turing.go
…
typecheck.go
…
typecheckloop.go
…
typeswitch.go
…
typeswitch1.go
…
typeswitch2.go
…
typeswitch2b.go
…
typeswitch3.go
…
uintptrescapes.go
…
uintptrescapes2.go
…
uintptrescapes3.go
…
undef.go
…
utf.go
…
varerr.go
…
varinit.go
…
writebarrier.go
…
zerodivide.go
…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

  • it is most naturally expressed using the test runner; or
  • it is also applicable to gccgo and other Go tool chains.