go/src
Bryan C. Mills cd91ab5d96 cmd/go/internal/modload: fix spurious import resolution error
Due to a bug in CL 173017, if QueryPackages found multiple candidates
for the given package and *at least* one of those candidates was not
available to add, we would reject *all* such candidates — even those
that were still viable.

Now, we return the first viable candidate, and only return an error if
*no* candidate is viable given the current build list.

Fixes #41113

Change-Id: Idb2e77244be7c0f5dd511efb142c3059925d7336
Reviewed-on: https://go-review.googlesource.com/c/go/+/251446
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
2020-09-09 21:29:10 +00:00
..
archive
bufio all: fix spelling mistakes 2020-08-18 03:28:52 +00:00
builtin
bytes
cmd cmd/go/internal/modload: fix spurious import resolution error 2020-09-09 21:29:10 +00:00
compress compress/flate: fix another deflate Reset inconsistency 2020-07-16 23:38:32 +00:00
container
context
crypto crypto/x509: fix duplicate import 2020-08-25 17:34:17 +00:00
database/sql database/sql: shortestIdleTimeLocked correct min comparison 2020-08-29 09:20:35 +00:00
debug debug/elf: support relocations relative to sections with non-zero addresses 2020-08-31 18:42:38 +00:00
encoding encoding/binary: replace constant literals with named constant (cleanup) 2020-08-25 16:06:28 +00:00
errors
expvar
flag
fmt fmt: avoid badverb formatting for %q when used with integers 2020-08-17 04:55:28 +00:00
go go/ast: note that in BasicLit CHARs and STRINGs are quoted 2020-09-06 20:23:50 +00:00
hash hash/maphash: adding benchmarks for maphash 2020-08-21 05:30:14 +00:00
html text/template: add CommentNode to template parse tree 2020-08-28 21:45:12 +00:00
image image/gif: have BenchmarkEncodeRealisticRGBA convert to RGBA 2020-09-03 05:33:35 +00:00
index/suffixarray
internal cmd/go, testing, os: fail test that calls os.Exit(0) 2020-08-27 23:19:15 +00:00
io
log
math math/big: tune addVW/subVW performance on arm64 2020-08-28 16:40:41 +00:00
mime mime: add examples for FormatMediaType and ParseMediaType 2020-09-06 05:12:37 +00:00
net net/http: fix data race due to writeLoop goroutine left running 2020-09-09 21:25:35 +00:00
os cmd/go, testing, os: fail test that calls os.Exit(0) 2020-08-27 23:19:15 +00:00
path path,path/filepath: add Join examples with ".." components 2020-08-19 00:10:22 +00:00
plugin
reflect runtime: eliminate scase.kind field 2020-08-18 20:06:33 +00:00
regexp regexp/syntax: append patchLists in constant time 2020-06-18 00:40:11 +00:00
runtime runtime: ignore SIGPROF if profiling disable for thread 2020-09-09 18:04:10 +00:00
sort
strconv unicode: upgrade to Unicode 13.0.0 2020-08-20 13:41:13 +00:00
strings strings: optimize Replace by using a strings.Builder 2020-08-17 04:08:35 +00:00
sync sync: delete dirty keys inside Map.LoadAndDelete 2020-08-24 20:05:41 +00:00
syscall syscall: cap RLIMIT_NOFILE soft limit in TestRlimit on darwin 2020-08-17 09:14:51 +00:00
testdata
testing testing: make TempDir idempotent for both Cleanup and Benchmark 2020-09-05 04:21:49 +00:00
text text/template: add CommentNode to template parse tree 2020-08-28 21:45:12 +00:00
time
unicode unicode: upgrade to Unicode 13.0.0 2020-08-20 13:41:13 +00:00
unsafe
vendor src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-05 16:55:51 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-05 16:55:51 +00:00
go.sum src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-05 16:55:51 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.