go/test at cd595be6d669af171bc28bdc939cc36785717718 - go

History

Jakub Ciolek cd595be6d6 cmd/compile: prefer an add when shifting left by 1 ADD(Q\|L) has generally twice the throughput. Came up in CL 626998. Throughput by arch: Zen 4: SHLL (R64, 1): 0.5 ADD (R64, R64): 0.25 Intel Alder Lake: SHLL (R64, 1): 0.5 ADD (R64, R64): 0.2 Intel Haswell: SHLL (R64, 1): 0.5 ADD (R64, R64): 0.25 Also include a minor opt for: (x + x) << c -> x << (c + 1) Before this, the code: func addShift(x int64) int64 { return (x + x) << 1 } emitted two instructions: ADDQ AX, AX SHLQ $1, AX but we can do it in a single shift: SHLQ $2, AX Add a codegen test for clearing the last bit. compilecmp linux/amd64: math math.sqrt 243 -> 242 (-0.41%) math [cmd/compile] math.sqrt 243 -> 242 (-0.41%) runtime runtime.selectgo 5455 -> 5445 (-0.18%) runtime.sysargs 665 -> 662 (-0.45%) runtime.isPinned 145 -> 141 (-2.76%) runtime.atoi64 198 -> 194 (-2.02%) runtime.setPinned 714 -> 709 (-0.70%) runtime [cmd/compile] runtime.sysargs 665 -> 662 (-0.45%) runtime.setPinned 714 -> 709 (-0.70%) runtime.atoi64 198 -> 194 (-2.02%) runtime.isPinned 145 -> 141 (-2.76%) strconv strconv.computeBounds 109 -> 107 (-1.83%) strconv.FormatInt 201 -> 197 (-1.99%) strconv.ryuFtoaShortest 1298 -> 1266 (-2.47%) strconv.small 144 -> 134 (-6.94%) strconv.AppendInt 357 -> 344 (-3.64%) strconv.ryuDigits32 490 -> 488 (-0.41%) strconv.AppendUint 342 -> 340 (-0.58%) strconv [cmd/compile] strconv.FormatInt 201 -> 197 (-1.99%) strconv.ryuFtoaShortest 1298 -> 1266 (-2.47%) strconv.ryuDigits32 490 -> 488 (-0.41%) strconv.AppendUint 342 -> 340 (-0.58%) strconv.computeBounds 109 -> 107 (-1.83%) strconv.small 144 -> 134 (-6.94%) strconv.AppendInt 357 -> 344 (-3.64%) image image.Rectangle.Inset 101 -> 97 (-3.96%) regexp/syntax regexp/syntax.inCharClass.func1 111 -> 110 (-0.90%) regexp/syntax.(compiler).quest 586 -> 573 (-2.22%) regexp/syntax.ranges.Less 153 -> 150 (-1.96%) regexp/syntax.(compiler).loop 583 -> 568 (-2.57%) time time.Time.Before 179 -> 161 (-10.06%) time.Time.Compare 189 -> 166 (-12.17%) time.Time.Sub 444 -> 425 (-4.28%) time.Time.UnixMicro 106 -> 95 (-10.38%) time.div 592 -> 587 (-0.84%) time.Time.UnixNano 85 -> 78 (-8.24%) time.(Time).UnixMilli 141 -> 140 (-0.71%) time.Time.UnixMilli 106 -> 95 (-10.38%) time.(Time).UnixMicro 141 -> 140 (-0.71%) time.Time.After 179 -> 161 (-10.06%) time.Time.Equal 170 -> 150 (-11.76%) time.Time.AppendBinary 766 -> 757 (-1.17%) time.Time.IsZero 74 -> 66 (-10.81%) time.(Time).UnixNano 124 -> 113 (-8.87%) time.(Time).IsZero 113 -> 108 (-4.42%) regexp regexp.(Regexp).FindAllStringSubmatch.func1 590 -> 569 (-3.56%) regexp.QuoteMeta 485 -> 469 (-3.30%) regexp/syntax [cmd/compile] regexp/syntax.inCharClass.func1 111 -> 110 (-0.90%) regexp/syntax.(compiler).loop 583 -> 568 (-2.57%) regexp/syntax.(compiler).quest 586 -> 573 (-2.22%) regexp/syntax.ranges.Less 153 -> 150 (-1.96%) encoding/base64 encoding/base64.decodedLen 92 -> 90 (-2.17%) encoding/base64.(Encoding).DecodedLen 99 -> 97 (-2.02%) time [cmd/compile] time.(Time).IsZero 113 -> 108 (-4.42%) time.Time.IsZero 74 -> 66 (-10.81%) time.(Time).UnixNano 124 -> 113 (-8.87%) time.Time.UnixMilli 106 -> 95 (-10.38%) time.Time.Equal 170 -> 150 (-11.76%) time.Time.UnixMicro 106 -> 95 (-10.38%) time.(Time).UnixMicro 141 -> 140 (-0.71%) time.Time.Before 179 -> 161 (-10.06%) time.Time.UnixNano 85 -> 78 (-8.24%) time.Time.AppendBinary 766 -> 757 (-1.17%) time.div 592 -> 587 (-0.84%) time.Time.After 179 -> 161 (-10.06%) time.Time.Compare 189 -> 166 (-12.17%) time.(Time).UnixMilli 141 -> 140 (-0.71%) time.Time.Sub 444 -> 425 (-4.28%) index/suffixarray index/suffixarray.sais_8_32 1677 -> 1645 (-1.91%) index/suffixarray.sais_32 1677 -> 1645 (-1.91%) index/suffixarray.sais_64 1677 -> 1654 (-1.37%) index/suffixarray.sais_8_64 1677 -> 1654 (-1.37%) index/suffixarray.writeInt 249 -> 247 (-0.80%) os os.Expand 1070 -> 1051 (-1.78%) os.Chtimes 787 -> 774 (-1.65%) regexp [cmd/compile] regexp.(Regexp).FindAllStringSubmatch.func1 590 -> 569 (-3.56%) regexp.QuoteMeta 485 -> 469 (-3.30%) encoding/base64 [cmd/compile] encoding/base64.decodedLen 92 -> 90 (-2.17%) encoding/base64.(Encoding).DecodedLen 99 -> 97 (-2.02%) encoding/hex encoding/hex.Encode 138 -> 136 (-1.45%) encoding/hex.(decoder).Read 830 -> 824 (-0.72%) crypto/des crypto/des.initFeistelBox 235 -> 229 (-2.55%) crypto/des.cryptBlock 549 -> 538 (-2.00%) os [cmd/compile] os.Chtimes 787 -> 774 (-1.65%) os.Expand 1070 -> 1051 (-1.78%) math/big math/big.newFloat 238 -> 223 (-6.30%) math/big.nat.mul 2138 -> 2122 (-0.75%) math/big.karatsubaSqr 1372 -> 1369 (-0.22%) math/big.(Float).sqrtInverse 895 -> 878 (-1.90%) math/big.basicSqr 1032 -> 1017 (-1.45%) cmd/vendor/golang.org/x/sys/unix cmd/vendor/golang.org/x/sys/unix.TimeToTimespec 72 -> 66 (-8.33%) encoding/json encoding/json.Indent 404 -> 403 (-0.25%) encoding/json.MarshalIndent 303 -> 297 (-1.98%) testing testing.(T).Deadline 84 -> 82 (-2.38%) testing.(M).Run 3545 -> 3525 (-0.56%) archive/zip archive/zip.headerFileInfo.ModTime 229 -> 223 (-2.62%) encoding/gob encoding/gob.(encoderState).encodeInt 474 -> 469 (-1.05%) crypto/elliptic crypto/elliptic.Marshal 728 -> 714 (-1.92%) debug/buildinfo debug/buildinfo.readString 325 -> 315 (-3.08%) image/png image/png.(decoder).readImagePass 10866 -> 10834 (-0.29%) archive/tar archive/tar.Header.allowedFormats.func3 1768 -> 1736 (-1.81%) archive/tar.formatPAXTime 389 -> 358 (-7.97%) archive/tar.(Writer).writeGNUHeader 741 -> 727 (-1.89%) archive/tar.readGNUSparseMap0x1 709 -> 695 (-1.97%) archive/tar.(Writer).templateV7Plus 915 -> 909 (-0.66%) crypto/internal/cryptotest crypto/internal/cryptotest.TestHash.func4 890 -> 879 (-1.24%) crypto/internal/cryptotest.TestStream.func6.1 646 -> 645 (-0.15%) crypto/internal/cryptotest.testCipher.func3 1300 -> 1289 (-0.85%) internal/pkgbits internal/pkgbits.(Encoder).Int64 113 -> 103 (-8.85%) internal/pkgbits.(Encoder).rawVarint 74 -> 72 (-2.70%) testing/quick testing/quick.(Config).getRand 316 -> 315 (-0.32%) log/slog log/slog.TimeValue 489 -> 479 (-2.04%) runtime/pprof runtime/pprof.(profileBuilder).build 2341 -> 2322 (-0.81%) internal/coverage/cfile internal/coverage/cfile.(emitState).openMetaFile 824 -> 822 (-0.24%) internal/coverage/cfile.(emitState).openCounterFile 904 -> 892 (-1.33%) cmd/internal/objabi cmd/internal/objabi.expandArgs 1177 -> 1169 (-0.68%) crypto/ecdsa crypto/ecdsa.pointFromAffine 1162 -> 1144 (-1.55%) net net.minNonzeroTime 313 -> 308 (-1.60%) net.cgoLookupAddrPTR 812 -> 797 (-1.85%) net.(IPNet).String 851 -> 827 (-2.82%) net.IP.AppendText 488 -> 471 (-3.48%) net.IPMask.String 281 -> 270 (-3.91%) net.partialDeadline 374 -> 366 (-2.14%) net.hexString 249 -> 240 (-3.61%) net.IP.String 454 -> 453 (-0.22%) internal/fuzz internal/fuzz.newPcgRand 240 -> 234 (-2.50%) crypto/x509 crypto/x509.(Certificate).isValid 2642 -> 2611 (-1.17%) cmd/internal/obj/s390x cmd/internal/obj/s390x.buildop 33676 -> 33644 (-0.10%) encoding/hex [cmd/compile] encoding/hex.(decoder).Read 830 -> 824 (-0.72%) encoding/hex.Encode 138 -> 136 (-1.45%) cmd/internal/objabi [cmd/compile] cmd/internal/objabi.expandArgs 1177 -> 1169 (-0.68%) math/big [cmd/compile] math/big.(Float).sqrtInverse 895 -> 878 (-1.90%) math/big.nat.mul 2138 -> 2122 (-0.75%) math/big.karatsubaSqr 1372 -> 1369 (-0.22%) math/big.basicSqr 1032 -> 1017 (-1.45%) math/big.newFloat 238 -> 223 (-6.30%) encoding/json [cmd/compile] encoding/json.MarshalIndent 303 -> 297 (-1.98%) encoding/json.Indent 404 -> 403 (-0.25%) cmd/covdata main.(metaMerge).emitCounters 985 -> 973 (-1.22%) runtime/pprof [cmd/compile] runtime/pprof.(profileBuilder).build 2341 -> 2322 (-0.81%) cmd/compile/internal/syntax cmd/compile/internal/syntax.(source).fill 722 -> 703 (-2.63%) cmd/dist main.runInstall 19081 -> 19049 (-0.17%) crypto/tls crypto/tls.extractPadding 176 -> 175 (-0.57%) slices.Clone[[]crypto/tls.SignatureScheme,crypto/tls.SignatureScheme] 253 -> 247 (-2.37%) slices.Clone[[]uint16,uint16] 253 -> 247 (-2.37%) slices.Clone[[]crypto/tls.CurveID,crypto/tls.CurveID] 253 -> 247 (-2.37%) crypto/tls.(Config).cipherSuites 335 -> 326 (-2.69%) slices.DeleteFunc[go.shape.[]crypto/tls.CurveID,go.shape.uint16] 437 -> 434 (-0.69%) crypto/tls.dial 1349 -> 1339 (-0.74%) slices.DeleteFunc[go.shape.[]uint16,go.shape.uint16] 437 -> 434 (-0.69%) internal/pkgbits [cmd/compile] internal/pkgbits.(Encoder).Int64 113 -> 103 (-8.85%) internal/pkgbits.(Encoder).rawVarint 74 -> 72 (-2.70%) cmd/compile/internal/syntax [cmd/compile] cmd/compile/internal/syntax.(source).fill 722 -> 703 (-2.63%) cmd/internal/obj/s390x [cmd/compile] cmd/internal/obj/s390x.buildop 33676 -> 33644 (-0.10%) cmd/go/internal/trace cmd/go/internal/trace.Flow 910 -> 886 (-2.64%) cmd/go/internal/trace.(Span).Done 311 -> 304 (-2.25%) cmd/go/internal/trace.StartSpan 620 -> 615 (-0.81%) cmd/internal/script cmd/internal/script.(Engine).Execute.func2 534 -> 528 (-1.12%) cmd/link/internal/loader cmd/link/internal/loader.(Loader).SetSymSect 344 -> 338 (-1.74%) net/http net/http.(Transport).queueForIdleConn 1797 -> 1766 (-1.73%) net/http.(Transport).getConn 2149 -> 2131 (-0.84%) net/http.(http2ClientConn).tooIdleLocked 207 -> 197 (-4.83%) net/http.(http2responseWriter).SetWriteDeadline.func1 520 -> 508 (-2.31%) net/http.(Cookie).Valid 837 -> 818 (-2.27%) net/http.(http2responseWriter).SetReadDeadline 373 -> 357 (-4.29%) net/http.checkIfRange 701 -> 690 (-1.57%) net/http.(http2SettingsFrame).Value 325 -> 298 (-8.31%) net/http.(http2SettingsFrame).HasDuplicates 777 -> 767 (-1.29%) net/http.(Server).Serve 1746 -> 1739 (-0.40%) net/http.http2traceGotConn 569 -> 556 (-2.28%) net/http/pprof net/http/pprof.collectProfile 242 -> 239 (-1.24%) cmd/compile/internal/coverage cmd/compile/internal/coverage.metaHashAndLen 439 -> 438 (-0.23%) cmd/vendor/golang.org/x/telemetry/internal/upload cmd/vendor/golang.org/x/telemetry/internal/upload.(uploader).findWork 4570 -> 4540 (-0.66%) cmd/vendor/golang.org/x/telemetry/internal/upload.(uploader).reports 3604 -> 3572 (-0.89%) cmd/compile/internal/coverage [cmd/compile] cmd/compile/internal/coverage.metaHashAndLen 439 -> 438 (-0.23%) cmd/vendor/golang.org/x/text/language cmd/vendor/golang.org/x/text/language.regionGroupDist 287 -> 284 (-1.05%) cmd/go/internal/vcweb cmd/go/internal/vcweb.(Server).overview.func1 1045 -> 1041 (-0.38%) cmd/go/internal/vcs cmd/go/internal/vcs.expand 761 -> 741 (-2.63%) cmd/compile/internal/inline/inlheur slices.stableCmpFunc[go.shape.struct 2300 -> 2284 (-0.70%) cmd/compile/internal/inline/inlheur [cmd/compile] slices.stableCmpFunc[go.shape.struct 2300 -> 2284 (-0.70%) cmd/go/internal/modfetch/codehost cmd/go/internal/modfetch/codehost.bzrParseStat 2217 -> 2213 (-0.18%) cmd/link/internal/ld cmd/link/internal/ld.decodetypeStructFieldCount 157 -> 152 (-3.18%) cmd/link/internal/ld.(Link).address 12559 -> 12495 (-0.51%) cmd/link/internal/ld.(dodataState).allocateDataSections 18345 -> 18205 (-0.76%) cmd/link/internal/ld.elfshreloc 618 -> 616 (-0.32%) cmd/link/internal/ld.(deadcodePass).decodetypeMethods 794 -> 779 (-1.89%) cmd/link/internal/ld.(dodataState).assignDsymsToSection 668 -> 663 (-0.75%) cmd/link/internal/ld.relocSectFn 285 -> 284 (-0.35%) cmd/link/internal/ld.decodetypeIfaceMethodCount 146 -> 144 (-1.37%) cmd/link/internal/ld.decodetypeArrayLen 157 -> 152 (-3.18%) cmd/link/internal/arm64 cmd/link/internal/arm64.gensymlate.func1 895 -> 888 (-0.78%) cmd/go/internal/modload cmd/go/internal/modload.queryProxy.func3 1029 -> 1012 (-1.65%) cmd/go/internal/load cmd/go/internal/load.(Package).setBuildInfo 8453 -> 8447 (-0.07%) cmd/go/internal/clean cmd/go/internal/clean.runClean 2120 -> 2104 (-0.75%) cmd/compile/internal/ssa cmd/compile/internal/ssa.(poset).aliasnodes 2010 -> 1978 (-1.59%) cmd/compile/internal/ssa.rewriteValueARM64_OpARM64MOVHstoreidx2 730 -> 719 (-1.51%) cmd/compile/internal/ssa.(debugState).buildLocationLists 3326 -> 3294 (-0.96%) cmd/compile/internal/ssa.rewriteValueAMD64_OpAMD64ADDLconst 3069 -> 2941 (-4.17%) cmd/compile/internal/ssa.(debugState).processValue 9756 -> 9724 (-0.33%) cmd/compile/internal/ssa.rewriteValueAMD64_OpAMD64ADDQconst 3069 -> 2941 (-4.17%) cmd/compile/internal/ssa.(poset).mergeroot 1079 -> 1054 (-2.32%) cmd/compile/internal/ssa [cmd/compile] cmd/compile/internal/ssa.rewriteValueARM64_OpARM64MOVHstoreidx2 730 -> 719 (-1.51%) cmd/compile/internal/ssa.(poset).aliasnodes 2010 -> 1978 (-1.59%) cmd/compile/internal/ssa.(*poset).mergeroot 1079 -> 1054 (-2.32%) cmd/compile/internal/ssa.rewriteValueAMD64_OpAMD64ADDQconst 3069 -> 2941 (-4.17%) cmd/compile/internal/ssa.rewriteValueAMD64_OpAMD64ADDLconst 3069 -> 2941 (-4.17%) file before after Δ % math/bits.s 2352 2354 +2 +0.085% math/bits [cmd/compile].s 2352 2354 +2 +0.085% math.s 35675 35674 -1 -0.003% math [cmd/compile].s 35675 35674 -1 -0.003% runtime.s 577251 577245 -6 -0.001% runtime [cmd/compile].s 642419 642438 +19 +0.003% sort.s 37434 37435 +1 +0.003% strconv.s 48391 48343 -48 -0.099% sort [cmd/compile].s 37434 37435 +1 +0.003% bufio.s 21386 21418 +32 +0.150% strconv [cmd/compile].s 48391 48343 -48 -0.099% image.s 34978 35022 +44 +0.126% regexp/syntax.s 81719 81781 +62 +0.076% time.s 94341 94184 -157 -0.166% regexp.s 60411 60399 -12 -0.020% bufio [cmd/compile].s 21512 21544 +32 +0.149% encoding/binary.s 34062 34087 +25 +0.073% regexp/syntax [cmd/compile].s 81719 81781 +62 +0.076% encoding/base64.s 11907 11903 -4 -0.034% time [cmd/compile].s 94341 94184 -157 -0.166% index/suffixarray.s 41633 41527 -106 -0.255% os.s 101770 101738 -32 -0.031% regexp [cmd/compile].s 60411 60399 -12 -0.020% encoding/binary [cmd/compile].s 37173 37198 +25 +0.067% encoding/base64 [cmd/compile].s 11907 11903 -4 -0.034% os/exec.s 23900 23907 +7 +0.029% encoding/hex.s 6038 6030 -8 -0.132% crypto/des.s 5073 5056 -17 -0.335% os [cmd/compile].s 102030 101998 -32 -0.031% vendor/golang.org/x/net/http2/hpack.s 22027 22033 +6 +0.027% math/big.s 164808 164753 -55 -0.033% cmd/vendor/golang.org/x/sys/unix.s 121450 121444 -6 -0.005% encoding/json.s 110294 110287 -7 -0.006% testing.s 115303 115281 -22 -0.019% archive/zip.s 65329 65325 -4 -0.006% os/user.s 10078 10080 +2 +0.020% encoding/gob.s 143788 143783 -5 -0.003% crypto/elliptic.s 30686 30704 +18 +0.059% go/doc/comment.s 49401 49433 +32 +0.065% debug/buildinfo.s 9095 9085 -10 -0.110% image/png.s 36113 36081 -32 -0.089% archive/tar.s 71994 71897 -97 -0.135% crypto/internal/cryptotest.s 60872 60849 -23 -0.038% internal/pkgbits.s 20441 20429 -12 -0.059% testing/quick.s 8236 8235 -1 -0.012% log/slog.s 77568 77558 -10 -0.013% internal/trace/internal/oldtrace.s 52885 52896 +11 +0.021% runtime/pprof.s 123978 123969 -9 -0.007% internal/coverage/cfile.s 25198 25184 -14 -0.056% cmd/internal/objabi.s 19954 19946 -8 -0.040% crypto/ecdsa.s 29159 29141 -18 -0.062% log/slog/internal/benchmarks.s 6694 6695 +1 +0.015% net.s 299569 299503 -66 -0.022% os/exec [cmd/compile].s 23888 23895 +7 +0.029% internal/trace.s 179226 179240 +14 +0.008% internal/fuzz.s 86190 86191 +1 +0.001% crypto/x509.s 177195 177164 -31 -0.017% cmd/internal/obj/s390x.s 121642 121610 -32 -0.026% cmd/internal/obj/ppc64.s 140118 140122 +4 +0.003% encoding/hex [cmd/compile].s 6149 6141 -8 -0.130% cmd/internal/objabi [cmd/compile].s 19954 19946 -8 -0.040% cmd/internal/obj/arm64.s 158523 158555 +32 +0.020% go/doc/comment [cmd/compile].s 49512 49544 +32 +0.065% math/big [cmd/compile].s 166394 166339 -55 -0.033% encoding/json [cmd/compile].s 110712 110705 -7 -0.006% cmd/covdata.s 39699 39687 -12 -0.030% runtime/pprof [cmd/compile].s 125209 125200 -9 -0.007% cmd/compile/internal/syntax.s 181755 181736 -19 -0.010% cmd/dist.s 177893 177861 -32 -0.018% crypto/tls.s 389157 389113 -44 -0.011% internal/pkgbits [cmd/compile].s 41644 41632 -12 -0.029% cmd/compile/internal/syntax [cmd/compile].s 196105 196086 -19 -0.010% cmd/compile/internal/types.s 71315 71345 +30 +0.042% cmd/internal/obj/s390x [cmd/compile].s 121733 121701 -32 -0.026% cmd/go/internal/trace.s 4796 4760 -36 -0.751% cmd/internal/obj/arm64 [cmd/compile].s 168120 168147 +27 +0.016% cmd/internal/obj/ppc64 [cmd/compile].s 140219 140223 +4 +0.003% cmd/internal/script.s 83442 83436 -6 -0.007% cmd/link/internal/loader.s 93299 93294 -5 -0.005% net/http.s 620639 620472 -167 -0.027% net/http/pprof.s 35016 35013 -3 -0.009% cmd/compile/internal/coverage.s 6668 6667 -1 -0.015% cmd/vendor/golang.org/x/telemetry/internal/upload.s 34210 34148 -62 -0.181% cmd/compile/internal/coverage [cmd/compile].s 6664 6663 -1 -0.015% cmd/vendor/golang.org/x/text/language.s 48077 48074 -3 -0.006% cmd/go/internal/vcweb.s 45193 45189 -4 -0.009% cmd/go/internal/vcs.s 44749 44729 -20 -0.045% cmd/compile/internal/inline/inlheur.s 83758 83742 -16 -0.019% cmd/compile/internal/inline/inlheur [cmd/compile].s 84773 84757 -16 -0.019% cmd/go/internal/modfetch/codehost.s 89098 89094 -4 -0.004% cmd/trace.s 257550 257564 +14 +0.005% cmd/link/internal/ld.s 641945 641706 -239 -0.037% cmd/link/internal/arm64.s 34805 34798 -7 -0.020% cmd/go/internal/modload.s 328971 328954 -17 -0.005% cmd/go/internal/load.s 178877 178871 -6 -0.003% cmd/go/internal/clean.s 11006 10990 -16 -0.145% cmd/compile/internal/ssa.s 3552843 3553347 +504 +0.014% cmd/compile/internal/ssa [cmd/compile].s 3752511 3753123 +612 +0.016% total 36179015 36178687 -328 -0.001% Change-Id: I251c2898ccf3c9931d162d87dabbd49cf4ec73a5 Reviewed-on: https://go-review.googlesource.com/c/go/+/641757 Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>		2025-02-06 09:05:20 -08:00
..
abi	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
alias3.dir	…
arenas	reflect: fix ArenaNew to match documentation	2023-06-16 17:08:43 +00:00
asmhdr.dir	…
chan	…
closure3.dir	cmd/compile: use very high budget for once-called closures	2024-11-22 02:04:41 +00:00
closure5.dir	…
codegen	cmd/compile: prefer an add when shifting left by 1	2025-02-06 09:05:20 -08:00
ddd2.dir	…
dwarf	…
fixedbugs	test/issue71226: add cast to avoid clang error	2025-02-03 10:14:38 -08:00
import2.dir	…
import4.dir	…
interface	…
internal/runtime/sys	runtime: move getcallersp to internal/runtime/sys	2024-09-17 17:01:20 +00:00
intrinsic.dir	runtime,internal: move runtime/internal/sys to internal/runtime/sys	2024-07-23 19:05:35 +00:00
ken	…
linkname.dir	…
linknameasm.dir	cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname	2024-06-07 15:22:22 +00:00
method4.dir	…
retjmp.dir	…
stress	test/stress: fix typo in comment	2024-03-25 19:21:35 +00:00
syntax	cmd/compile: better error message when offending/missing token is a keyword	2024-11-14 02:14:13 +00:00
typeparam	cmd/compile: export/import materialized aliases	2024-04-05 16:29:58 +00:00
uintptrescapes.dir	…
wasmmemsize.dir	test: add a test for wasm memory usage	2024-10-28 13:27:58 +00:00
64bit.go	…
235.go	…
README.md	internal/testdir: move to cmd/internal/testdir	2023-05-12 17:18:08 +00:00
alg.go	…
alias.go	…
alias1.go	…
alias2.go	go/types, types2: qualify named types in error messages with type kind	2024-10-23 04:43:01 +00:00
alias3.go	…
align.go	…
append.go	…
append1.go	…
args.go	…
armimm.go	…
asmhdr.go	…
assign.go	sync: add explicit noCopy fields to Map, Mutex, and Once	2024-11-18 18:52:54 +00:00
assign1.go	…
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	…
bom.go	…
bombad.go	…
bounds.go	…
cannotassign.go	…
chancap.go	…
chanlinear.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
char_lit.go	…
char_lit1.go	…
checkbce.go	cmd/compile: rewrite the constant parts of the prove pass	2024-08-07 16:07:33 +00:00
clear.go	…
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	…
closure3.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
closure4.go	…
closure5.go	…
closure6.go	…
closure7.go	…
cmp.go	…
cmp6.go	…
cmplx.go	…
cmplxdivide.c	…
cmplxdivide.go	…
cmplxdivide1.go	…
complit.go	…
complit1.go	…
compos.go	…
const.go	…
const1.go	…
const2.go	…
const3.go	…
const4.go	…
const5.go	…
const6.go	…
const7.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
const8.go	…
convT2X.go	…
convert.go	…
convert1.go	…
convert2.go	…
convert3.go	…
convert4.go	…
convinline.go	…
convlit.go	…
convlit1.go	…
copy.go	…
copy1.go	…
crlf.go	…
ddd.go	…
ddd1.go	…
ddd2.go	…
decl.go	…
declbad.go	…
defer.go	…
defererrcheck.go	test: add open-coded defer tests for too many exits path	2024-07-29 14:30:07 +00:00
deferfin.go	…
defernil.go	…
deferprint.go	…
deferprint.out	…
devirt.go	…
directive.go	…
directive2.go	…
divide.go	…
divmod.go	…
embedfunc.go	…
embedvers.go	…
empty.go	…
env.go	test,internal/testdir: don't set GOOS/GOARCH	2023-05-12 12:34:59 +00:00
eof.go	…
eof1.go	…
escape.go	…
escape2.go	all: remove newline characters after return statements	2023-12-14 17:22:18 +00:00
escape2n.go	all: remove newline characters after return statements	2023-12-14 17:22:18 +00:00
escape3.go	…
escape4.go	cmd/compile: retire "IsHiddenClosure" and "IsDeadcodeClosure"	2024-07-22 21:27:37 +00:00
escape5.go	cmd/compile/internal/noder: stop preserving original const strings	2023-09-08 18:50:24 +00:00
escape_array.go	…
escape_calls.go	cmd/compile: fix escape analysis of string min/max	2023-12-05 22:06:07 +00:00
escape_closure.go	cmd/compile: retire "IsHiddenClosure" and "IsDeadcodeClosure"	2024-07-22 21:27:37 +00:00
escape_field.go	…
escape_goto.go	…
escape_hash_maphash.go	…
escape_iface.go	test: remove *_unified.go variants	2023-05-23 17:16:35 +00:00
escape_indir.go	…
escape_level.go	…
escape_map.go	…
escape_mutations.go	cmd/compile: restore zero-copy string->[]byte optimization	2023-08-18 11:58:37 +00:00
escape_param.go	…
escape_reflect.go	reflect: remove calling mapiterkey, mapiterelem	2024-09-18 20:57:20 +00:00
escape_runtime_atomic.go	runtime: migrate internal/atomic to internal/runtime	2024-03-25 19:53:03 +00:00
escape_selfassign.go	…
escape_slice.go	cmd/compile/internal/noder: stop preserving original const strings	2023-09-08 18:50:24 +00:00
escape_struct_param1.go	…
escape_struct_param2.go	…
escape_struct_return.go	…
escape_sync_atomic.go	…
escape_unsafe.go	…
fibo.go	…
finprofiled.go	test: ignore MemProfileRecords with no live objects in finprofiled.go	2023-11-16 05:48:00 +00:00
float_lit.go	…
float_lit2.go	…
float_lit3.go	…
floatcmp.go	…
for.go	test: add test cases for index value with range array clear	2023-07-10 16:36:41 +00:00
func.go	…
func1.go	…
func2.go	…
func3.go	go/parser, syntax: better error message for parameter missing type	2024-09-30 22:04:40 +00:00
func4.go	…
func5.go	…
func6.go	…
func7.go	…
func8.go	…
funcdup.go	…
funcdup2.go	…
fuse.go	cmd/compile: handle boolean and pointer relations	2024-08-07 16:07:55 +00:00
gc.go	…
gc1.go	…
gc2.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
gcgort.go	…
gcstring.go	…
goprint.go	…
goprint.out	…
goto.go	…
heapsampling.go	…
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	…
import4.go	…
import5.go	…
import6.go	…
index.go	…
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	…
init1.go	…
initcomma.go	…
initexp.go	…
initialize.go	…
initializerr.go	…
initloop.go	go/types: improve recursive type error message	2024-10-22 22:20:29 +00:00
inline.go	cmd/compile: add "deadlocals" pass to remove unused locals	2024-07-30 15:46:27 +00:00
inline_big.go	cmd/compile: restore zero-copy string->[]byte optimization	2023-08-18 11:58:37 +00:00
inline_caller.go	…
inline_callers.go	…
inline_endian.go	…
inline_literal.go	…
inline_math_bits_rotate.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
inline_sync.go	sync: use atomic.Uint32 in Once	2023-10-06 21:01:50 +00:00
inline_testingbloop.go	cmd/compile,testing: implement one-time rampup logic for testing.B.Loop	2024-11-20 23:19:48 +00:00
inline_variadic.go	…
int_lit.go	…
intcvt.go	…
intrinsic.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
intrinsic_atomic.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
iota.go	…
label.go	…
label1.go	…
linkmain.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
linkmain_run.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
linkname.go	…
linkname3.go	cmd/compile: disallow linkname referring to instantiations	2024-05-15 19:27:25 +00:00
linknameasm.go	cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname	2024-06-07 15:22:22 +00:00
linkobj.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
linkx.go	…
linkx_run.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
literal.go	…
literal2.go	…
live.go	runtime: rename mapiterinit and mapiternext	2025-01-28 10:54:43 -08:00
live1.go	…
live2.go	cmd/compile,internal/runtime/maps: add extendible hashing	2024-10-21 14:16:20 +00:00
live_regabi.go	runtime: rename mapiterinit and mapiternext	2025-01-28 10:54:43 -08:00
live_uintptrkeepalive.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
loopbce.go	cmd/compile: rewrite the constant parts of the prove pass	2024-08-07 16:07:33 +00:00
mainsig.go	…
makechan.go	all: fix some comments	2024-04-04 14:29:45 +00:00
makemap.go	…
makenew.go	…
makeslice.go	…
mallocfin.go	…
map.go	…
map1.go	…
mapclear.go	…
maplinear.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
maymorestack.go	…
mergemul.go	…
method.go	…
method1.go	…
method2.go	…
method3.go	…
method4.go	…
method5.go	…
method6.go	…
method7.go	…
named.go	…
named1.go	…
newinline.go	cmd/compile: add "deadlocals" pass to remove unused locals	2024-07-30 15:46:27 +00:00
nil.go	…
nilcheck.go	…
nilptr.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
nilptr2.go	…
nilptr3.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
nilptr4.go	…
nilptr5.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
nilptr5_aix.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
nilptr5_wasm.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
nilptr_aix.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
noinit.go	cmd/compile: reenable inline static init	2023-04-14 17:57:36 +00:00
nosplit.go	cmd/internal/objabi, internal/runtime: increase nosplit limit on OpenBSD	2024-12-06 00:35:41 +00:00
nowritebarrier.go	cmd/compile: redo IsRuntimePkg/IsReflectPkg predicate	2023-08-22 19:18:21 +00:00
nul1.go	…
opt_branchlikely.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
parentype.go	…
peano.go	…
phiopt.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
print.go	…
print.out	…
printbig.go	…
printbig.out	…
prove.go	cmd/compile: establish limits of bool to uint8 conversions	2025-02-05 09:04:25 -08:00
prove_constant_folding.go	cmd/compile: rewrite the constant parts of the prove pass	2024-08-07 16:07:33 +00:00
prove_invert_loop_with_unused_iterators.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
range.go	…
range2.go	all: rename GOEXPERIMENT=range to rangefunc	2023-11-08 15:32:14 +00:00
range3.go	cmd/compile: fix typecheck range over rune literal	2023-12-01 17:20:08 +00:00
range4.go	cmd/compile: handle defined iter func type correctly	2024-01-08 16:00:53 +00:00
rangegen.go	test: skip rangegen.go on 32-bit platforms	2023-12-18 23:35:19 +00:00
recover.go	…
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
recover5.go	…
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
reflectmethod5.go	…
reflectmethod6.go	…
reflectmethod7.go	…
reflectmethod8.go	…
rename.go	…
rename1.go	cmd/compile/internal/types2: only mark variables as used if they are	2023-04-19 14:07:00 +00:00
reorder.go	…
reorder2.go	…
retjmp.go	…
return.go	…
rotate.go	…
rotate0.go	…
rotate1.go	…
rotate2.go	…
rotate3.go	…
rune.go	…
runtime.go	…
shift1.go	…
shift2.go	…
shift3.go	…
sieve.go	…
sigchld.go	test: migrate remaining files to go:build syntax	2023-10-19 23:33:25 +00:00
sigchld.out	…
simassign.go	…
sizeof.go	…
slice3.go	…
slice3err.go	…
slicecap.go	…
sliceopt.go	…
solitaire.go	…
stack.go	…
stackobj.go	…
stackobj2.go	…
stackobj3.go	…
strcopy.go	…
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	cmd/compile: better error message when offending/missing token is a keyword	2024-11-14 02:14:13 +00:00
switch3.go	…
switch4.go	…
switch5.go	…
switch6.go	…
switch7.go	…
tailcall.go	cmd/compile: emit tail call wrappers when possible	2024-09-09 20:20:10 +00:00
tighten.go	cmd/compile: enhance tighten pass for memory values	2023-05-16 01:01:38 +00:00
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	…
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	…
typeswitch2b.go	…
typeswitch3.go	…
uintptrescapes.go	…
uintptrescapes2.go	…
uintptrescapes3.go	…
uintptrkeepalive.go	…
undef.go	…
unsafe_slice_data.go	…
unsafe_string.go	…
unsafe_string_data.go	…
unsafebuiltins.go	…
used.go	…
utf.go	…
varerr.go	…
varinit.go	…
wasmexport.go	cmd/compile: add basic wasmexport support	2024-08-09 20:07:54 +00:00
wasmexport2.go	cmd/compile: allow more types for wasmimport/wasmexport parameters and results	2024-11-11 17:11:50 +00:00
wasmmemsize.go	test: add a test for wasm memory usage	2024-10-28 13:27:58 +00:00
winbatch.go	…
writebarrier.go	…
zerodivide.go	…
zerosize.go	cmd/link: put zero-sized data symbols at same address as runtime.zerobase	2023-04-28 18:35:43 +00:00

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go test cmd/internal/testdir

To run just tests from specified files in this directory, execute:

../bin/go test cmd/internal/testdir -run='Test/(file1.go|file2.go|...)'

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.