go/src
Austin Clements c5be4ed7df runtime: add missing trace lock edges
We're missing lock edges to trace.lock that happen only rarely. Any
trace event can potentially fill up a trace buffer and acquire
trace.lock in order to flush the buffer, but this happens relatively
rarely, so we simply haven't seen some of these lock edges that could
happen.

With this change, we promote "fin, notifyList < traceStackTab" to
"fin, notifyList < trace" and now everything that emits trace events
with a P enters the tracer lock ranks via "trace", rather than some
things entering at "trace" and others at "traceStackTab".

This was found by inspecting the rank graph for things that didn't
make sense.

Ideally we would add a mayAcquire annotation that any trace event can
potentially acquire trace.lock, but there are actually cases that
violate this ranking right now. This is #53979. The chance of a lock
cycle is extremely low given the number of conditions that have to
happen simultaneously.

For #53789.

Change-Id: Ic65947d27dee88d2daf639b21b2c9d37552f0ac0
Reviewed-on: https://go-review.googlesource.com/c/go/+/418716
Reviewed-by: Michael Pratt <mpratt@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-08-04 15:31:45 +00:00
..
archive archive/zip: use bufio.Reset rather than NewReader 2022-06-02 17:17:19 +00:00
bufio
builtin builtin: clarify effect of close on receive 2022-05-24 19:45:14 +00:00
bytes bytes: document that Reader.Reset affects the result of Size 2022-07-26 14:20:34 +00:00
cmd cmd/dist: require Go 1.17 for building Go 2022-08-04 14:47:49 +00:00
compress compress/gzip: fix stack exhaustion bug in Reader.Read 2022-07-12 15:06:07 +00:00
container
context
crypto crypto/internal/nistec,debug/gosym: fix typos 2022-07-19 20:07:59 +00:00
database/sql database/sql: make TestTxContextWaitNoDiscard test more robust 2022-07-11 17:14:33 +00:00
debug crypto/internal/nistec,debug/gosym: fix typos 2022-07-19 20:07:59 +00:00
embed embed: document additional file name restrictions 2022-06-23 16:32:40 +00:00
encoding encoding/gob: s/TestIngoreDepthLimit/TestIgnoreDepthLimit/ 2022-07-15 14:20:24 +00:00
errors
expvar expvar: don't crash if map value set to nil 2022-06-16 18:29:19 +00:00
flag flag: highlight support for double dashes in docs 2022-07-01 15:37:46 +00:00
fmt
go internal/dag: add a Graph type and make node order deterministic 2022-08-04 15:31:42 +00:00
hash hash/crc32: fix typo in arm64 archInitCastagnoli panic message 2022-05-25 05:31:01 +00:00
html html/template: fix typo in content_test.go 2022-06-27 17:04:56 +00:00
image image/jpeg: increase TestLargeImageWithShortData timeout by an order of magnitude 2022-07-12 21:23:11 +00:00
index/suffixarray
internal runtime: generate the lock ranking from a DAG description 2022-08-04 15:31:44 +00:00
io io/fs: fix stack exhaustion in Glob 2022-07-12 15:05:55 +00:00
log
math math/big: check buffer lengths in GobDecode 2022-07-27 18:31:51 +00:00
mime mime: ignore .js => text/plain in Windows registry 2022-05-28 20:07:28 +00:00
net net: disable TestIPv6WriteMsgUDPAddrPortTargetAddrIPVersion [sic] on DragonflyBSD 2022-08-03 13:50:38 +00:00
os os/exec: add GODEBUG setting to opt out of ErrDot changes 2022-07-28 19:12:40 +00:00
path path/filepath: fix stack exhaustion in Glob 2022-07-12 15:06:01 +00:00
plugin
reflect reflect: fix reference comment to runtime/map.go 2022-06-15 21:24:24 +00:00
regexp regexp: avoid copying each instruction executed 2022-06-04 20:10:54 +00:00
runtime runtime: add missing trace lock edges 2022-08-04 15:31:45 +00:00
sort
strconv strconv: avoid panic on invalid call to FormatFloat 2022-06-24 23:50:20 +00:00
strings
sync sync: add more notes about Cond behavior 2022-06-17 21:35:36 +00:00
syscall all: disable tests that fail on Alpine 2022-08-02 17:23:42 +00:00
testdata
testing cmd/compile: mark closures made for generic function expressions as wrappers 2022-05-26 21:06:31 +00:00
text text/template/parse: fix data race on lexer initialization 2022-06-06 15:54:07 +00:00
time time: clarify documentation for allowed formats and add tests to prove them 2022-07-25 16:15:08 +00:00
unicode
unsafe unsafe: document when Sizeof/Offsetof/Alignof are not constant 2022-07-21 23:05:01 +00:00
vendor all: update to current golang.org/x/sys revision 2022-06-22 16:47:18 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update to current golang.org/x/sys revision 2022-06-22 16:47:18 +00:00
go.sum all: update to current golang.org/x/sys revision 2022-06-22 16:47:18 +00:00
make.bash
make.bat make.bat, make.rc: show bootstrap toolchain version 2022-08-03 19:52:27 +00:00
make.rc make.bat, make.rc: show bootstrap toolchain version 2022-08-03 19:52:27 +00:00
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.