mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/gopls/internal/regtest/misc
History
Robert Findley 96d05aa120 gopls/internal/regtest: fix TestFailingDiagnosticClearingOnEdit 
This test was asserting immediately on the non-presence of published
diagnostics, and therefore was racing with the diagnostics calculation
pass. Following https://go.dev/cl/420539 this became a flake, because
once gopls has calculated diagnostics for the open event, it will
actually publish empty diagnostics for the opened file.

Update the test to use a OnceMet so that we only evaluate the
expectation once we've finished the diagnostics pass. As a result, the
test deterministically failed, which was fixed by using the
EmptyOrNoDiagnostics expectation.

Fixes golang/go#54271

Change-Id: Id3f220ce44c7996132699a724b6c627f034e367f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/422136
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
 		2022-08-09 15:36:31 +00:00
..
testdata/vulndb internal/lsp/mod/code_lens: add "run govulncheck" codelens 2022-08-04 20:03:56 +00:00
call_hierarchy_test.go internal/lsp/source: check for nil objects in call hierarchy 2021-10-27 16:11:50 +00:00
configuration_test.go internal/lsp: re-send diagnostics on file events 2022-08-02 18:52:36 +00:00
debugserver_test.go internal/lsp/debug: add a facility to track known bugs 2021-05-10 23:21:19 +00:00
definition_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
embed_test.go internal/lsp/cache: parse files with ParseFull mode to check if metadata reload is required 2021-08-06 19:38:52 +00:00
failures_test.go gopls/internal/regtest: fix TestFailingDiagnosticClearingOnEdit 2022-08-09 15:36:31 +00:00
fix_test.go internal/lsp/analysis/fillreturns: update fillreturns for new type errs 2021-12-03 18:55:02 +00:00
formatting_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
generate_test.go internal/lsp/progress: actually close over Context in WorkDoneWriter 2022-07-12 22:14:18 +00:00
highlight_test.go internal/lsp: move gopls/internal/regtest -> internal/lsp/regtest 2021-04-23 16:19:37 +00:00
hover_test.go internal/lsp: render package documentation when hovering over a package import 2022-04-25 17:29:41 +00:00
import_test.go internal/lsp: add ListImports 2022-02-04 22:09:29 +00:00
imports_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
link_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
misc_test.go internal/lsp/cache: invalidate metadata when parsing issues resolve 2022-05-23 18:14:40 +00:00
multiple_adhoc_test.go internal/lsp: allow for multiple ad-hoc packages in the workspace 2021-08-12 18:45:58 +00:00
references_test.go internal/lsp: find references to package 2022-06-21 19:39:47 +00:00
rename_test.go internal/lsp: rename all the package names in the renamed package 2022-08-01 17:28:00 +00:00
semantictokens_test.go internal/lsp/regtest: allow sharing memoized results across regtests 2022-07-26 21:20:42 +00:00
settings_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
shared_test.go gopls/internal/regtest/misc: simplify shared edit tests 2022-08-04 19:57:25 +00:00
staticcheck_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
vendor_test.go internal/lsp/regtest: allow sharing memoized results across regtests 2022-07-26 21:20:42 +00:00
vuln_test.go internal/lsp: polish vulncheck progress messages 2022-08-04 20:05:03 +00:00
workspace_symbol_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00