Heschi Kreinick aefe0b7421 internal/lsp: set correct directness when adding new requires ... When adding a require, we should add an `// indirect` comment if that's what go mod tidy would do. It's possible I should split Add out from Update and Remove, but this was quick and easy and I'm not too worried about it for now. Also minimize the test that covered this case, which was way more complicated than it needed to be AFAICT. Fixes golang/go#38914. Change-Id: I89c44f8573873227c4c9e637d1d31d8c1a6530aa Reviewed-on: https://go-review.googlesource.com/c/tools/+/267578 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-11-04 18:37:02 +00:00
..
analysis.go	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
cache.go	internal/lsp/cache: introduce a workspace abstraction	2020-10-30 19:58:30 +00:00
check.go	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
error_test.go	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
errors.go	internal/lsp: add support for RelatedInformation in diagnostics	2020-09-04 18:57:47 +00:00
imports.go	internal/lsp/cache: introduce a workspace abstraction	2020-10-30 19:58:30 +00:00
keys.go	internal/lsp: decouple client and server debug	2020-06-11 13:49:48 +00:00
load.go	internal/lsp/cache: set a 15 minute deadline on calls to packages.Load	2020-11-02 02:19:07 +00:00
mod.go	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
mod_tidy.go	internal/lsp: set correct directness when adding new requires	2020-11-04 18:37:02 +00:00
os_darwin.go	internal/lsp: add a mutex around the view's options	2020-04-02 16:41:49 +00:00
os_windows.go	internal/lsp/cache: validate workspace path case	2020-03-27 19:55:53 +00:00
parse.go	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
parse_test.go	internal/lsp/cache: trim ellipsis array literals	2020-08-12 23:16:40 +00:00
pkg.go	internal/lsp: prepare for deletion of view.modURI	2020-09-28 20:19:43 +00:00
session.go	internal/lsp/cache: assign a static temp workspace dir to the first view	2020-11-04 18:18:50 +00:00
snapshot.go	internal/lsp/cache: assign a static temp workspace dir to the first view	2020-11-04 18:18:50 +00:00
view.go	internal/lsp/cache: assign a static temp workspace dir to the first view	2020-11-04 18:18:50 +00:00
view_test.go	internal/lsp: change `go mod vendor` warning into a diagnostic	2020-11-02 00:57:53 +00:00
workspace.go	internal/lsp: fix the logic to avoid duplicate file watching	2020-11-03 19:00:53 +00:00
workspace_test.go	internal/lsp/cache: introduce a workspace abstraction	2020-10-30 19:58:30 +00:00