bb4add04dd
Do a pass a cleaning up the matchArgType and matchArgTypeInternal functions: - Remove the 'typ' argument from matchArgType, since external callers must pass nil. It must have predated matchArgTypeInternal. - Remove the `if false` blocks that were placeholders for the *verbose flag. It has been three years, so seems safe to delete this dead code. This also means we don't do any reporting via matchArgType, which is cleaner. - Extract the types.Info lookup of the arg type into matchArgType; it doesn't make sense in recursive calls to matchArgType. - Compare against types.Typ[types.Invalid] directly, rather than comparing against the type string "invalid type". - Remove an unused pass argument from isConvertibleToString. - Remove the now unused 'pass' and 'arg' arguments from matchArgTypeInternal. Change-Id: I52232a881090e40943e4c4c377ae8436512232b1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/360154 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| copyright | ||
| cover | ||
| go | ||
| godoc | ||
| gopls | ||
| imports | ||
| internal | ||
| playground | ||
| present | ||
| refactor | ||
| txtar | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierrc | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| codereview.cfg | ||
| go.mod | ||
| go.sum | ||
README.md
Go Tools
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go
distributions.
Others, including the Go guru and the test coverage tool, can be fetched with
go install.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
Download/Install
The easiest way to install is to run go install golang.org/x/tools/...@latest.
JS/CSS Formatting
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
Report Issues / Send Patches
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.