mirror of https://github.com/golang/go.git
Vet complained about multiple definitions of the 'workspace' tag. The underlying error was a failure to do type merging in alias types, coupled with relying on luck when generating types and deciding which type definitions to store. (Luck almost worked, but more careful type merging made it too risky.) The only noticeable change (outside tsprotocol.go) is that the generated type names used in general.go now have serial numbers in them. tsserver.go and tsclient.go just have new dates in their headers, but are otherwise unchanged. tsprotocol.go has more generated types (Workspace.*Gn). (There are probably more types than are needed, but fixing that is for the future.) All the tests pass and gopls seems to work ok. The revised code.ts will be submitted in a future CL. Change-Id: I7082755c327e7b6ebec57d4449eec1e0cc50fcd5 Reviewed-on: https://go-review.googlesource.com/c/tools/+/294909 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Peter Weinberger <pjw@google.com> Run-TryBot: Peter Weinberger <pjw@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| lsp | ||
| memoize | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typesinternal | ||
| xcontext | ||