go/internal/lsp/cmd/test
Rebecca Stambler 73cd2cc3b5 internal/lsp: don't run analyses on the entire view
Running staticcheck on the entire workspace causes a slowdown, and most
likely users don't want to see staticcheck reports for every
subdirectory of their workspace. Only run staticcheck on open files.

Also, fixed a staticcheck warning that showed up along the way. Filed
golang/go#35718 to remind ourselves to fix all of the staticcheck warnings
that showed up when we ran gopls with staticcheck on x/tools.

Finally, made sure that we don't send empty diagnostics when diagnosing
the snapshot on start-up, as that is not necessary.

Change-Id: Ic51d1abfc80b1b53397057f06a4cfd7e2dc930f9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/208098
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Cottrell <iancottrell@google.com>
2019-11-25 22:48:44 +00:00
..
check.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
cmdtest.go internal/lsp: don't run analyses on the entire view 2019-11-25 22:48:44 +00:00
definition.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
folding_range.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
format.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
implementation.go tools/gopls: add cmd support for implementation 2019-11-25 20:27:09 +00:00
imports.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
links.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
references.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
rename.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
signature.go internal/lsp: use AST to construct placeholders 2019-11-25 01:11:57 +00:00
suggested_fix.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00
symbols.go internal/lsp: fix a race in the command line tests 2019-11-22 16:15:56 +00:00