go/test at afa3f8e104744ea2350b0eb87474866ef27e04f2 - go

History

Matthew Dempsky afa3f8e104 cmd/compile/internal/staticinit: make staticopy safe Currently, cmd/compile optimizes `var a = true; var b = a` into `var a = true; var b = true`. But this may not be safe if we need to initialize any other global variables between `a` and `b`, and the initialization involves calling a user-defined function that reassigns `a`. This CL changes staticinit to keep track of the initialization expressions that we've seen so far, and to stop applying the staticcopy optimization once we've seen an initialization expression that might have modified another global variable within this package. To help identify affected initializers, this CL adds a -d=staticcopy flag to warn when a staticcopy is suppressed and turned into a dynamic copy. Currently, `go build -gcflags=all=-d=staticcopy std` reports only four instances: ``` encoding/xml/xml.go:1600:5: skipping static copy of HTMLEntity+0 with map[string]string{...} encoding/xml/xml.go:1869:5: skipping static copy of HTMLAutoClose+0 with []string{...} net/net.go:661:5: skipping static copy of .stmp_31+0 with poll.ErrNetClosing net/http/transport.go:2566:5: skipping static copy of errRequestCanceled+0 with ~R0 ``` Fixes #51913. Change-Id: Iab41cf6f84c44f7f960e4e62c28a8aeaade4fbcf Reviewed-on: https://go-review.googlesource.com/c/go/+/395541 Auto-Submit: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Heschi Kreinick <heschi@google.com>		2023-09-11 20:12:05 +00:00
..
abi	…
alias3.dir	…
arenas	reflect: fix ArenaNew to match documentation	2023-06-16 17:08:43 +00:00
asmhdr.dir	…
chan	…
closure3.dir	cmd/compile/internal/noder: remove inlined closure naming hack	2023-08-17 19:36:29 +00:00
closure5.dir	…
codegen	cmd/compile/internal/ssa: improve masking codegen on PPC64	2023-09-06 16:34:20 +00:00
ddd2.dir	…
dwarf	…
fixedbugs	cmd/compile/internal/staticinit: make staticopy safe	2023-09-11 20:12:05 +00:00
import2.dir	…
import4.dir	go/types, types2: use "and not used" instead of "but not used" in error messages	2022-09-27 21:10:19 +00:00
interface	go/types, types2: more systematic use of Checker.use und useLHS	2023-03-28 14:28:33 +00:00
intrinsic.dir	runtime: replace all uses of CtzXX with TrailingZerosXX	2022-10-18 18:06:27 +00:00
ken	…
linkname.dir	…
method4.dir	…
retjmp.dir	…
runtime	…
stress	…
syntax	go/parser: adjustments to error messages	2022-09-01 22:37:04 +00:00
typeparam	go/types, types2: don't infer type argument for unused parameter in interfaces	2023-05-25 21:37:01 +00:00
uintptrescapes.dir	…
64bit.go	…
235.go	…
README.md	internal/testdir: move to cmd/internal/testdir	2023-05-12 17:18:08 +00:00
alg.go	…
alias.go	…
alias1.go	…
alias2.go	cmd/compile: use "cannot use %s as %s value in %s: %s" error message	2022-09-28 22:28:39 +00:00
alias3.go	…
align.go	…
append.go	…
append1.go	cmd/compile: use "cannot use %s as %s value in %s: %s" error message	2022-09-28 22:28:39 +00:00
args.go	…
armimm.go	cmd/internal/obj: continue to optimize ARM's constant pool	2017-05-11 13:53:54 +00:00
asmhdr.go	…
assign.go	…
assign1.go	test: [a-c]: add introductory comments to tests	2012-02-19 13:19:43 +11:00
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	…
bom.go	…
bombad.go	…
bounds.go	…
cannotassign.go	…
chancap.go	…
chanlinear.go	…
char_lit.go	…
char_lit1.go	…
checkbce.go	Revert "cmd/compile: sparse conditional constant propagation"	2023-05-24 14:39:34 +00:00
clear.go	cmd/compile: add clear(x) builtin	2023-01-31 19:43:07 +00:00
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	cmd/compile: experimental loop iterator capture semantics change	2023-03-06 18:34:24 +00:00
closure3.go	…
closure4.go	…
closure5.go	…
closure6.go	…
closure7.go	…
cmp.go	…
cmp6.go	…
cmplx.go	…
cmplxdivide.c	…
cmplxdivide.go	…
cmplxdivide1.go	…
complit.go	…
complit1.go	…
compos.go	…
const.go	…
const1.go	…
const2.go	…
const3.go	…
const4.go	…
const5.go	…
const6.go	…
const7.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
const8.go	…
convT2X.go	…
convert.go	…
convert1.go	…
convert2.go	go/types, types2: implement slice-to-array conversions	2022-09-08 15:55:44 +00:00
convert3.go	…
convert4.go	cmd/compile: implement slice-to-array conversions	2022-09-19 18:58:26 +00:00
convinline.go	cmd/compile: handle integer conversions in static init inliner	2022-11-17 13:46:05 +00:00
convlit.go	…
convlit1.go	…
copy.go	…
copy1.go	…
crlf.go	…
ddd.go	…
ddd1.go	cmd/compile: use "cannot use %s as %s value in %s: %s" error message	2022-09-28 22:28:39 +00:00
ddd2.go	…
decl.go	…
declbad.go	…
defer.go	…
defererrcheck.go	…
deferfin.go	…
defernil.go	cmd/compile: on Wasm and AIX, let deferred nil function panic at invocation	2019-10-16 00:05:37 +00:00
deferprint.go	…
deferprint.out	…
devirt.go	…
directive.go	cmd/compile: restrict //go:notinheap to runtime/internal/sys	2022-09-02 06:22:23 +00:00
directive2.go	cmd/compile: restrict //go:notinheap to runtime/internal/sys	2022-09-02 06:22:23 +00:00
divide.go	…
divmod.go	…
embedfunc.go	…
embedvers.go	…
empty.go	…
env.go	test,internal/testdir: don't set GOOS/GOARCH	2023-05-12 12:34:59 +00:00
eof.go	…
eof1.go	…
escape.go	cmd/compile: experimental loop iterator capture semantics change	2023-03-06 18:34:24 +00:00
escape2.go	cmd/compile: enable -d=zerocopy by default	2023-08-18 11:59:42 +00:00
escape2n.go	cmd/compile: enable -d=zerocopy by default	2023-08-18 11:59:42 +00:00
escape3.go	…
escape4.go	test: enable inlining tests for functions with local type	2023-01-31 20:36:55 +00:00
escape5.go	cmd/compile/internal/noder: stop preserving original const strings	2023-09-08 18:50:24 +00:00
escape_array.go	…
escape_calls.go	…
escape_closure.go	cmd/compile/internal/escape: optimize indirect closure calls	2023-08-17 16:36:09 +00:00
escape_field.go	…
escape_goto.go	…
escape_hash_maphash.go	…
escape_iface.go	test: remove *_unified.go variants	2023-05-23 17:16:35 +00:00
escape_indir.go	…
escape_level.go	…
escape_map.go	…
escape_mutations.go	cmd/compile: restore zero-copy string->[]byte optimization	2023-08-18 11:58:37 +00:00
escape_param.go	…
escape_reflect.go	cmd/compile/internal/noder: stop preserving original const strings	2023-09-08 18:50:24 +00:00
escape_runtime_atomic.go	…
escape_selfassign.go	…
escape_slice.go	cmd/compile/internal/noder: stop preserving original const strings	2023-09-08 18:50:24 +00:00
escape_struct_param1.go	…
escape_struct_param2.go	…
escape_struct_return.go	…
escape_sync_atomic.go	…
escape_unsafe.go	test: fix typo in escape_unsafe.go	2022-09-07 17:25:59 +00:00
fibo.go	…
finprofiled.go	…
float_lit.go	…
float_lit2.go	…
float_lit3.go	…
floatcmp.go	…
for.go	test: add test cases for index value with range array clear	2023-07-10 16:36:41 +00:00
func.go	…
func1.go	…
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	…
func7.go	…
func8.go	…
funcdup.go	…
funcdup2.go	…
fuse.go	…
gc.go	…
gc1.go	…
gc2.go	all: skip unsupported tests for js/wasm	2018-04-30 19:39:18 +00:00
gcgort.go	…
gcstring.go	…
goprint.go	…
goprint.out	…
goto.go	…
heapsampling.go	…
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	go/types, types2: use "and not used" instead of "but not used" in error messages	2022-09-27 21:10:19 +00:00
import2.go	…
import4.go	…
import5.go	…
import6.go	…
index.go	…
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	…
init1.go	…
initcomma.go	…
initexp.go	cmd/compile: use "init... cycle" instead of "init... loop" in error messages	2022-09-23 20:27:09 +00:00
initialize.go	cmd/compile: handle simple inlined calls in staticinit	2022-11-16 04:04:52 +00:00
initializerr.go	…
initloop.go	…
inline.go	cmd/compile/internal/noder: elide statically known "if" statements	2023-08-23 18:01:55 +00:00
inline_big.go	cmd/compile: restore zero-copy string->[]byte optimization	2023-08-18 11:58:37 +00:00
inline_caller.go	…
inline_callers.go	…
inline_endian.go	cmd/compile: make encoding/binary appends cheaper to inline	2022-09-15 21:05:02 +00:00
inline_literal.go	…
inline_math_bits_rotate.go	…
inline_sync.go	reflect: do not escape Value.Type	2023-05-12 21:11:51 +00:00
inline_variadic.go	…
int_lit.go	…
intcvt.go	…
intrinsic.go	…
intrinsic_atomic.go	…
iota.go	…
label.go	…
label1.go	…
linkmain.go	…
linkmain_run.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
linkname.go	…
linkname3.go	…
linkobj.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
linkx.go	…
linkx_run.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
literal.go	…
literal2.go	…
live.go	cmd/compile/internal/walk: reuse runtime.scase	2023-08-21 23:34:34 +00:00
live1.go	…
live2.go	cmd/compile/internal/reflectdata: share hmap and hiter types	2023-08-21 23:29:33 +00:00
live_regabi.go	cmd/compile/internal/walk: reuse runtime.scase	2023-08-21 23:34:34 +00:00
live_uintptrkeepalive.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
loopbce.go	Revert "cmd/compile: sparse conditional constant propagation"	2023-05-24 14:39:34 +00:00
mainsig.go	…
makechan.go	…
makemap.go	…
makenew.go	…
makeslice.go	…
mallocfin.go	…
map.go	…
map1.go	…
mapclear.go	…
maplinear.go	…
maymorestack.go	…
mergemul.go	…
method.go	…
method1.go	cmd/compile: use "method T.m already declared" for method redeclaration errors	2022-09-27 21:59:19 +00:00
method2.go	…
method3.go	…
method4.go	…
method5.go	…
method6.go	…
method7.go	…
named.go	…
named1.go	…
nil.go	…
nilcheck.go	…
nilptr.go	…
nilptr2.go	…
nilptr3.go	cmd/compile: casts from slices to array pointers are known to be non-nil	2023-03-29 21:55:11 +00:00
nilptr4.go	…
nilptr5.go	cmd/compile: handle partially overlapping assignments	2022-08-23 19:56:32 +00:00
nilptr5_aix.go	…
nilptr5_wasm.go	…
nilptr_aix.go	…
noinit.go	cmd/compile: reenable inline static init	2023-04-14 17:57:36 +00:00
nosplit.go	runtime, cmd: rationalize StackLimit and StackGuard	2023-04-21 19:28:56 +00:00
nowritebarrier.go	cmd/compile: redo IsRuntimePkg/IsReflectPkg predicate	2023-08-22 19:18:21 +00:00
nul1.go	…
opt_branchlikely.go	…
parentype.go	…
peano.go	…
phiopt.go	…
print.go	…
print.out	…
printbig.go	…
printbig.out	…
prove.go	cmd/compile: teach prove about bitwise OR operation	2023-04-10 17:13:41 +00:00
prove_constant_folding.go	…
prove_invert_loop_with_unused_iterators.go	cmd/compile: try to rewrite loops to count down	2023-07-31 18:33:29 +00:00
range.go	…
recover.go	…
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	…
recover5.go	…
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
reflectmethod5.go	…
reflectmethod6.go	…
reflectmethod7.go	…
reflectmethod8.go	…
rename.go	…
rename1.go	cmd/compile/internal/types2: only mark variables as used if they are	2023-04-19 14:07:00 +00:00
reorder.go	…
reorder2.go	…
retjmp.go	…
return.go	…
rotate.go	…
rotate0.go	…
rotate1.go	…
rotate2.go	…
rotate3.go	…
rune.go	…
runtime.go	…
shift1.go	…
shift2.go	…
shift3.go	…
sieve.go	test/[n-z]*.go: add documentation	2012-02-24 11:48:19 +11:00
sigchld.go	all: add wasip1 support	2023-04-11 20:56:32 +00:00
sigchld.out	…
simassign.go	…
sizeof.go	…
slice3.go	…
slice3err.go	…
slicecap.go	…
sliceopt.go	…
solitaire.go	…
stack.go	…
stackobj.go	…
stackobj2.go	…
stackobj3.go	…
strcopy.go	…
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	go/parser: adjustments to error messages	2022-09-01 22:37:04 +00:00
switch3.go	…
switch4.go	…
switch5.go	…
switch6.go	cmd/compile: use "missing method m" instead of "missing m method"	2022-09-24 17:04:15 +00:00
switch7.go	…
tighten.go	cmd/compile: enhance tighten pass for memory values	2023-05-16 01:01:38 +00:00
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	cmd/compile: use "init... cycle" instead of "init... loop" in error messages	2022-09-23 20:27:09 +00:00
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	…
typeswitch2b.go	go/types, types2: use "and not used" instead of "but not used" in error messages	2022-09-27 21:10:19 +00:00
typeswitch3.go	…
uintptrescapes.go	…
uintptrescapes2.go	…
uintptrescapes3.go	…
uintptrkeepalive.go	…
undef.go	…
unsafe_slice_data.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafe_string.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafe_string_data.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
unsafebuiltins.go	cmd/compile: add support for unsafe.{String,StringData,SliceData}	2022-08-31 17:15:15 +00:00
used.go	…
utf.go	…
varerr.go	…
varinit.go	…
winbatch.go	…
writebarrier.go	…
zerodivide.go	…
zerosize.go	cmd/link: put zero-sized data symbols at same address as runtime.zerobase	2023-04-28 18:35:43 +00:00

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go test cmd/internal/testdir

To run just tests from specified files in this directory, execute:

../bin/go test cmd/internal/testdir -run='Test/(file1.go|file2.go|...)'

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.