go/test at aeb4fbabc0aaa5293dd34821c450855e9ff82230 - go

History

Keith Randall 301f6c8019 cmd/compile: keep methods on generic types from being deadcode eliminated We currently make dictionaries contain a relocation pointing to methods that generic code might use, so that those methods are not deadcode eliminated. However, with inlining we can end up not using the dictionary, making the reference from the dictionary to the method no longer keep the method alive. Fix this by keeping the dictionary alive at generic interface call sites. It's a bit of overkill, as we only need to keep the dictionary statically alive. We don't actually need it dynamically alive, which is what KeepAlive does. But it works. It ends up generating a LEAQ + stack spill that aren't necessary, but that's pretty low overhead. To make this work, I needed to stop generating methods on shape types. We should do this anyway, as we shouldn't ever need them. But currently we do use them! issue44688.go has a test that only works because it calls a method on a shape type. I've disabled that test for now, will work on it in a subsequent CL. Fixes #48047 Change-Id: I78968868d6486c1745f51b8b43be0898931432a2 Reviewed-on: https://go-review.googlesource.com/c/go/+/349169 Trust: Keith Randall <khr@golang.org> Trust: Dan Scales <danscales@google.com> Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Dan Scales <danscales@google.com> Reviewed-by: Than McIntosh <thanm@google.com>		2021-09-27 20:42:34 +00:00
..
abi	cmd/compile: restore tail call for method wrappers	2021-09-17 22:59:44 +00:00
alias3.dir	…
bench	test/bench/go1: fix size for RegexpMatchMedium_32	2021-07-18 21:03:43 +00:00
chan	[dev.typeparams] cmd/compile/internal/types2: implement close(ch) where ch is of type parameter type	2021-07-14 23:33:46 +00:00
closure3.dir	cmd/compile: don't emit inltree for closure within body of inlined func	2021-05-18 20:04:57 +00:00
closure5.dir	[dev.regabi] cmd/compile: exporting, importing, and inlining functions with OCLOSURE	2021-01-20 22:53:32 +00:00
codegen	cmd/compile: optimise immediate operands with constants on riscv64	2021-09-24 10:51:48 +00:00
ddd2.dir	…
dwarf	…
fixedbugs	test/fixedbugs: adjust test case (fix longtest builders)	2021-09-23 19:41:46 +00:00
import2.dir	…
import4.dir	…
interface	cmd/compile/internal/types2: avoid "declared but not used" errors for invalid code	2021-09-23 19:41:45 +00:00
intrinsic.dir	…
ken	…
linkname.dir	…
method4.dir	…
oldescape_linkname.dir	…
retjmp.dir	…
runtime	…
stress	all: update references to symbols moved from io/ioutil to io	2021-04-05 17:51:15 +00:00
syntax	test/syntax: remove interface.go	2021-04-06 18:55:39 +00:00
typeparam	cmd/compile: keep methods on generic types from being deadcode eliminated	2021-09-27 20:42:34 +00:00
uintptrescapes.dir	…
64bit.go	…
235.go	…
README.md	…
alg.go	…
alias.go	…
alias1.go	…
alias2.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
alias3.go	…
align.go	…
append.go	…
append1.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
args.go	…
armimm.go	…
assign.go	[dev.typeparams] merge: merge branch 'dev.regabi' into 'dev.typeparams'	2020-12-14 12:13:36 -08:00
assign1.go	…
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	[dev.typeparams] merge: merge branch 'dev.regabi' into 'dev.typeparams'	2020-12-14 12:13:36 -08:00
bom.go	…
bombad.go	…
bounds.go	…
cannotassign.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
chancap.go	[dev.regabi] cmd/compile: remove toolstash scaffolding	2021-01-05 21:44:30 +00:00
chanlinear.go	…
char_lit.go	…
char_lit1.go	cmd/compile: do not report error for invalid constant	2021-03-05 18:46:43 +00:00
checkbce.go	…
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	[dev.regabi] test: add another closure test case	2021-01-01 13:44:37 +00:00
closure3.go	cmd/compile: disable inlining functions with closures for now	2021-02-24 21:34:21 +00:00
closure4.go	…
closure5.go	[dev.regabi] cmd/compile: exporting, importing, and inlining functions with OCLOSURE	2021-01-20 22:53:32 +00:00
closure6.go	[dev.regabi] cmd/compile: fix escape analysis problem with closures	2021-01-23 02:15:24 +00:00
closure7.go	[dev.regabi] test: add a test for inlining closures	2021-02-01 18:28:05 +00:00
cmp.go	…
cmp6.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
cmplx.go	…
cmplxdivide.c	…
cmplxdivide.go	…
cmplxdivide1.go	…
complit.go	…
complit1.go	test: fix error check messages for 2 types2 tests	2021-06-02 05:14:45 +00:00
compos.go	…
const.go	…
const1.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
const2.go	[dev.typeparams] test: add scaffolding to run.go to check compiler with -G flag	2020-12-01 21:49:31 +00:00
const3.go	…
const4.go	…
const5.go	…
const6.go	…
const7.go	[dev.typeparams] cmd/compile: refuse excessively long constants	2021-02-03 20:22:34 +00:00
convT2X.go	…
convert.go	…
convert1.go	…
convert2.go	cmd/compile: allow conversion from slice to array ptr	2021-04-21 00:53:48 +00:00
convert3.go	…
convert4.go	cmd/compile: allow conversion from slice to array ptr	2021-04-21 00:53:48 +00:00
convlit.go	cmd/compile/internal/types2: refactor untyped conversions	2021-03-23 05:11:09 +00:00
convlit1.go	…
copy.go	…
copy1.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
crlf.go	…
ddd.go	…
ddd1.go	test: fix error check messages for 2 types2 tests	2021-06-02 05:14:45 +00:00
ddd2.go	…
decl.go	…
declbad.go	cmd/compile: rewrite a, b = f() to use temporaries when type not identical	2021-06-14 07:12:37 +00:00
defer.go	…
defererrcheck.go	…
deferfin.go	[dev.regabi] test: enable finalizer tests on !amd64	2021-01-05 21:11:31 +00:00
defernil.go	…
deferprint.go	…
deferprint.out	…
devirt.go	[dev.typeparams] cmd/compile: simplify interface conversions	2021-08-09 16:10:20 +00:00
directive.go	…
divide.go	…
divmod.go	…
embedfunc.go	cmd/compile: require 'go 1.16' go.mod line for //go:embed	2021-01-19 20:07:52 +00:00
embedvers.go	cmd/compile: require 'go 1.16' go.mod line for //go:embed	2021-01-19 20:07:52 +00:00
empty.go	…
env.go	…
eof.go	…
eof1.go	…
escape.go	…
escape2.go	[dev.typeparams] cmd/compile: move call logic from order.go to escape	2021-06-23 16:48:12 +00:00
escape2n.go	[dev.typeparams] cmd/compile: move call logic from order.go to escape	2021-06-23 16:48:12 +00:00
escape3.go	…
escape4.go	[dev.regabi] cmd/compile: convert OPANIC argument to interface{} during typecheck	2021-01-18 05:55:08 +00:00
escape5.go	[dev.typeparams] test: rename blank functions	2021-07-28 21:41:07 +00:00
escape_array.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_calls.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_closure.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_field.go	…
escape_goto.go	[dev.typeparams] test: rename blank functions	2021-07-28 21:41:07 +00:00
escape_hash_maphash.go	…
escape_iface.go	…
escape_indir.go	…
escape_level.go	…
escape_map.go	…
escape_param.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_runtime_atomic.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_selfassign.go	…
escape_slice.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_struct_param1.go	…
escape_struct_param2.go	…
escape_struct_return.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
escape_sync_atomic.go	…
escape_unsafe.go	[dev.typeparams] cmd/compile: simplify ~r/~b naming	2021-05-26 23:50:32 +00:00
fibo.go	…
finprofiled.go	…
float_lit.go	…
float_lit2.go	…
float_lit3.go	[dev.regabi] cmd/compile: enable rational constant arithmetic	2021-01-25 18:53:24 +00:00
floatcmp.go	…
for.go	…
func.go	…
func1.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	…
func7.go	…
func8.go	…
funcdup.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
funcdup2.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
fuse.go	test: do not run fuse test in noopt mode	2021-04-28 15:55:10 +00:00
gc.go	…
gc1.go	…
gc2.go	…
gcgort.go	…
gcstring.go	…
goprint.go	…
goprint.out	…
goto.go	…
heapsampling.go	…
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	…
import4.go	…
import5.go	…
import6.go	…
index.go	…
index0.go	…
index1.go	…
index2.go	…
indirect.go	…
indirect1.go	…
init.go	[dev.typeparams] merge: merge branch 'dev.regabi' into 'dev.typeparams'	2020-12-14 12:13:36 -08:00
init1.go	…
initcomma.go	…
initempty.go	…
initexp.go	cmd/compile: fix exponential-time init-cycle reporting	2021-01-08 17:14:20 +00:00
initialize.go	…
initializerr.go	test: match gofrontend error messages	2020-11-28 02:31:54 +00:00
initloop.go	[dev.typeparams] cmd/compile/internal/types2: adjusted qualified identifier error message for compiler	2020-12-09 23:56:19 +00:00
inline.go	[dev.typeparams] test: rename blank functions	2021-07-28 21:41:07 +00:00
inline_big.go	[dev.typeparams] cmd/compile/internal/inline: refactor mkinlcall	2021-05-27 23:40:56 +00:00
inline_caller.go	…
inline_callers.go	…
inline_literal.go	…
inline_math_bits_rotate.go	…
inline_sync.go	…
inline_variadic.go	[dev.typeparams] cmd/compile: simplify inlining variadic calls	2021-05-26 23:50:45 +00:00
int_lit.go	…
intcvt.go	…
intrinsic.go	…
intrinsic_atomic.go	…
iota.go	…
label.go	test: match gofrontend error messages	2020-11-28 02:31:54 +00:00
label1.go	test: match gofrontend error messages	2020-11-28 02:31:54 +00:00
linkmain.go	…
linkmain_run.go	…
linkname.go	…
linkname2.go	[dev.regabi] cmd/compile: comment out //go:linkname warning	2020-12-02 06:49:37 +00:00
linkobj.go	test: recognize and use gc build tag	2020-12-18 00:10:44 +00:00
linkx.go	…
linkx_run.go	test: recognize and use gc build tag	2020-12-18 00:10:44 +00:00
literal.go	…
literal2.go	…
live.go	[dev.typeparams] cmd/compile: simplify interface conversions	2021-08-09 16:10:20 +00:00
live1.go	…
live2.go	…
live_regabi.go	test: enable regabi test on arm64	2021-08-20 19:58:13 +00:00
live_syscall.go	…
locklinear.go	…
loopbce.go	…
mainsig.go	[dev.regabi] cmd/compile: cleanup for concrete types - noder	2020-12-17 04:43:46 +00:00
makechan.go	cmd/compile/internal/types2: add unsafe.Add and unsafe.Slice	2021-04-23 00:41:01 +00:00
makemap.go	cmd/compile/internal/types2: add unsafe.Add and unsafe.Slice	2021-04-23 00:41:01 +00:00
makenew.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
makeslice.go	…
mallocfin.go	…
map.go	…
map1.go	[dev.typeparams] merge: merge branch 'dev.regabi' into 'dev.typeparams'	2020-12-14 12:13:36 -08:00
mapclear.go	…
maplinear.go	…
mergemul.go	…
method.go	…
method1.go	…
method2.go	[dev.typeparams] merge: merge branch 'dev.regabi' into 'dev.typeparams'	2020-12-14 12:13:36 -08:00
method3.go	…
method4.go	…
method5.go	…
method6.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
method7.go	[dev.typeparams] cmd/compile: fix MethodExpr handling with embedded fields	2021-01-26 17:05:06 +00:00
named.go	…
named1.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
nil.go	…
nilcheck.go	…
nilptr.go	test: disable nilptr on windows/arm64	2021-02-19 00:40:22 +00:00
nilptr2.go	…
nilptr3.go	[dev.regabi] cmd/compile: deref PAUTOHEAPs during SSA construction	2021-01-10 08:01:49 +00:00
nilptr4.go	…
nilptr5.go	…
nilptr5_aix.go	…
nilptr5_wasm.go	…
nilptr_aix.go	…
nosplit.go	test: make nosplit test invariant to ABI wrappers	2021-03-18 16:51:25 +00:00
notinheap.go	…
notinheap2.go	…
notinheap3.go	…
nowritebarrier.go	…
nul1.go	…
opt_branchlikely.go	…
parentype.go	…
peano.go	…
phiopt.go	cmd/compile/internal/ssa: strengthen phiopt pass	2021-03-29 05:50:11 +00:00
print.go	…
print.out	…
printbig.go	…
printbig.out	…
prove.go	docs: fix spelling	2021-02-24 04:11:43 +00:00
range.go	…
recover.go	…
recover1.go	…
recover2.go	…
recover3.go	…
recover4.go	…
recover5.go	…
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
reflectmethod5.go	…
reflectmethod6.go	…
reflectmethod7.go	cmd/compile: mark concrete call of reflect.(*rtype).Method as REFLECTMETHOD	2021-02-10 22:44:54 +00:00
reflectmethod8.go	[dev.typeparams] cmd/compile: fix missing condition in usemethod	2021-07-22 17:48:41 +00:00
rename.go	…
rename1.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
reorder.go	[dev.regabi] cmd/compile: cleanup OAS2FUNC ordering	2021-01-16 23:19:26 +00:00
reorder2.go	…
retjmp.go	…
return.go	…
rotate.go	…
rotate0.go	…
rotate1.go	…
rotate2.go	…
rotate3.go	…
run.go	cmd/compile: fixing writebarrier.go for -G=3	2021-09-16 21:10:17 +00:00
rune.go	…
runtime.go	[dev.typeparams] cmd/compile/internal/types2: adjusted qualified identifier error message for compiler	2020-12-09 23:56:19 +00:00
shift1.go	test: recognize gofrontend error messages	2020-11-30 20:08:34 +00:00
shift2.go	…
sieve.go	…
sigchld.go	…
sigchld.out	…
simassign.go	…
sinit.go	…
sinit_run.go	test: recognize and use gc build tag	2020-12-18 00:10:44 +00:00
sizeof.go	…
slice3.go	…
slice3err.go	[dev.typeparams] test: finish triaging all outstanding failing tests	2020-12-14 21:28:48 +00:00
slicecap.go	…
sliceopt.go	…
solitaire.go	…
stack.go	…
stackobj.go	…
stackobj2.go	…
stackobj3.go	…
strcopy.go	…
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	…
switch.go	…
switch2.go	…
switch3.go	[dev.typeparams] cmd/compile/internal/types2: report error for invalid (but empty) expr switch	2020-12-15 19:43:32 +00:00
switch4.go	…
switch5.go	[dev.typeparams] test: finish triaging all outstanding failing tests	2020-12-14 21:28:48 +00:00
switch6.go	[dev.typeparams] test: finish triaging all outstanding failing tests	2020-12-14 21:28:48 +00:00
switch7.go	[dev.typeparams] test: finish triaging all outstanding failing tests	2020-12-14 21:28:48 +00:00
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	[dev.typeparams] cmd/compile/internal/types2: adjust init cycle error message for compiler	2020-12-09 23:55:41 +00:00
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	…
typeswitch2b.go	…
typeswitch3.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
uintptrescapes.go	…
uintptrescapes2.go	[dev.typeparams] cmd/compile: skip escape analysis diagnostics for wrappers	2021-06-24 18:24:24 +00:00
uintptrescapes3.go	…
undef.go	…
unsafebuiltins.go	cmd/compile,runtime: change unsafe.Slice((*T)(nil), 0) to return []T(nil)	2021-06-28 23:31:13 +00:00
used.go	[dev.typeparams] all: merge dev.regabi (`07569da`) into dev.typeparams	2020-12-28 00:39:17 -08:00
utf.go	…
varerr.go	[dev.typeparams] test: enable some more errorcheck tests	2020-12-04 21:22:23 +00:00
varinit.go	…
winbatch.go	all: update to use filepath.WalkDir instead of filepath.Walk	2020-12-02 16:33:57 +00:00
writebarrier.go	cmd/compile: don't emit write barriers for offsets of global addresses	2021-08-23 19:46:36 +00:00
zerodivide.go	…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

To run just tests from specified files in this directory, execute:

../bin/go run run.go -- file1.go file2.go ...

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

it is most naturally expressed using the test runner; or
it is also applicable to gccgo and other Go tool chains.