go/src
Phil Pearl acbed0372e encoding/json: remove allocation when using a Marshaler with value receiver
If we marshal a non-pointer struct field whose type implements Marshaler with
a non-pointer receiver, then we avoid an allocation if we take the address of
the field before casting it to an interface.

name               old time/op    new time/op    delta
EncodeMarshaler-8     104ns ± 1%      92ns ± 2%  -11.72%  (p=0.001 n=7+7)

name               old alloc/op   new alloc/op   delta
EncodeMarshaler-8     36.0B ± 0%      4.0B ± 0%  -88.89%  (p=0.000 n=8+8)

name               old allocs/op  new allocs/op  delta
EncodeMarshaler-8      2.00 ± 0%      1.00 ± 0%  -50.00%  (p=0.000 n=8+8)

Test coverage already looks good enough for this change. TestRefValMarshal
already covers all possible combinations of value & pointer receivers on
value and pointer struct fields.

Change-Id: I6fc7f72396396d98f9a90c3c86e813690f41c099
Reviewed-on: https://go-review.googlesource.com/c/go/+/203608
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-10-28 11:22:20 +00:00
..
archive
bufio
builtin
bytes bytes/hash: initialize all 64 bits of hash seed 2019-10-21 22:01:12 +00:00
cmd cmd/nm, runtime/cgo: add cgo support for freebsd/arm64 2019-10-28 10:25:44 +00:00
compress
container
context
crypto crypto/tls: move a defer out of a loop 2019-10-26 15:17:28 +00:00
database/sql database/sql: remove forced log import from test 2019-10-21 19:27:15 +00:00
debug debug/dwarf: call strings.EqualFold instead of calling Lower twice 2019-10-26 02:36:26 +00:00
encoding encoding/json: remove allocation when using a Marshaler with value receiver 2019-10-28 11:22:20 +00:00
errors errors: fix typo in TODO comment 2019-10-11 13:33:01 +00:00
expvar
flag
fmt fmt: fix handling of %% verb in Scanf 2019-10-25 04:15:59 +00:00
go go/types: don't update package-external types when checking validity 2019-10-22 16:13:55 +00:00
hash all: remove nacl (part 3, more amd64p32) 2019-10-10 22:38:38 +00:00
html
image
index/suffixarray
internal internal/syscall/windows/registry: remove TestWalkFullRegistry due to false assumptions 2019-10-27 09:45:42 +00:00
io syscall: respect permission bits on file opening on Windows 2019-10-22 10:09:39 +00:00
log syscall: reenable sysctl on iOS 2019-10-23 15:12:15 +00:00
math math/big: use nat pool to reduce allocations in mul and sqr 2019-10-25 03:14:39 +00:00
mime mime/multipart: add Part.NextRawPart to avoid QP decoding 2019-10-11 17:03:37 +00:00
net net/http: fix comment TimeoutHandler no longer supports Flusher 2019-10-25 20:46:57 +00:00
os os: use an actual RemoveAll failure in TestRemoveAllWithMoreErrorThanReqSize 2019-10-26 01:46:02 +00:00
path
plugin
reflect reflect: fix unsafe conversions reported by -d=checkptr 2019-10-22 18:09:15 +00:00
regexp regexp: skip long-running benchmarks if -short is specified 2019-10-17 19:53:52 +00:00
runtime cmd/nm, runtime/cgo: add cgo support for freebsd/arm64 2019-10-28 10:25:44 +00:00
sort
strconv
strings cmd/compile: add -d=checkptr to validate unsafe.Pointer rules 2019-10-17 00:40:21 +00:00
sync sync/atomic: suppress checkptr errors for hammerStoreLoadPointer 2019-10-22 18:09:03 +00:00
syscall syscall: correct comment in testGetdirentries 2019-10-24 13:58:59 +00:00
testdata
testing testing: stream log output in verbose mode 2019-10-22 19:21:02 +00:00
text
time runtime, syscall, time: prepare for adding timers to P's 2019-10-21 23:41:41 +00:00
unicode
unsafe
vendor vendor: re-vendor golang.org/x/net to fix Dragonfly build 2019-10-21 13:35:49 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod vendor: re-vendor golang.org/x/net to fix Dragonfly build 2019-10-21 13:35:49 +00:00
go.sum vendor: re-vendor golang.org/x/net to fix Dragonfly build 2019-10-21 13:35:49 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.