go/src
Michael Munday ac743dea8e cmd/compile: always tighten and de-duplicate tuple selectors
The scheduler assumes two special invariants that apply to tuple
selectors (Select0 and Select1 ops):

  1. There is only one tuple selector of each type per generator.
  2. Tuple selectors and generators reside in the same block.

Prior to this CL the assumption was that these invariants would
only be broken by the CSE pass. The CSE pass therefore contained
code to move and de-duplicate selectors to fix these invariants.

However it is also possible to write relatively basic optimization
rules that cause these invariants to be broken. For example:

  (A (Select0 (B))) -> (Select1 (B))

This rule could result in the newly added selector (Select1) being
in a different block to the tuple generator (see issue #38356). It
could also result in duplicate selectors if this rule matches
multiple times for the same tuple generator (see issue #39472).

The CSE pass will 'fix' these invariants. However it will only do
so when optimizations are enabled (since disabling optimizations
disables the CSE pass).

This CL moves the CSE tuple selector fixup code into its own pass
and makes it mandatory even when optimizations are disabled. This
allows tuple selectors to be treated like normal ops for most of
the compilation pipeline until after the new pass has run, at which
point we need to be careful to maintain the invariant again.

Fixes #39472.

Change-Id: Ia3f79e09d9c65ac95f897ce37e967ee1258a080b
Reviewed-on: https://go-review.googlesource.com/c/go/+/237118
Run-TryBot: Michael Munday <mike.munday@ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2020-06-10 14:55:29 +00:00
..
archive
bufio
builtin
bytes bytes: simpler and faster FieldsFunc (apply same changes as for strings) 2020-05-01 03:49:21 +00:00
cmd cmd/compile: always tighten and de-duplicate tuple selectors 2020-06-10 14:55:29 +00:00
compress
container container/list: fix typo in function comments 2020-05-31 02:07:28 +00:00
context
crypto crypto/tls: restore OCSP and SCTs during session resumption 2020-06-09 23:24:08 +00:00
database/sql database/sql/driver: use correct method name "Connect" in DriverContext docs 2020-05-30 03:20:54 +00:00
debug debug/gosym: correct comments for Table.{Files,Objs} 2020-04-30 03:07:49 +00:00
encoding encoding/xml: only initialize nil struct fields when decoding 2020-05-28 22:48:53 +00:00
errors
expvar
flag
fmt
go go/build: move build constraint docs to 'go help buildconstraint' 2020-05-29 20:56:20 +00:00
hash
html all: avoid awkward wording from CL 236857 2020-06-08 21:36:04 +00:00
image image/png: remove too early declaration of "n" 2020-05-08 22:01:08 +00:00
index/suffixarray
internal internal/poll: correct function name in comment 2020-06-09 20:45:39 +00:00
io io/ioutil: update WriteFile to clarify it does not change permissions if the file exists. 2020-06-04 10:53:46 +00:00
log
math math: fix dead link to springerlink (now link.springer) 2020-05-29 14:33:50 +00:00
mime
net all: avoid awkward wording from CL 236857 2020-06-08 21:36:04 +00:00
os os: always check for EINTR in calls to open 2020-06-08 22:06:39 +00:00
path
plugin
reflect reflect: keep RO flags unchanged in Value.Addr 2020-05-04 18:16:49 +00:00
regexp
runtime runtime: fix typo in comment (object -> objects) 2020-06-09 21:24:52 +00:00
sort
strconv strconv: fix ParseComplex for strings with separators 2020-05-08 20:34:23 +00:00
strings
sync
syscall syscall: document float arguments and results on windows/amd64 2020-06-04 17:50:16 +00:00
testdata
testing testing: capture testname on --- PASS and --- FAIL lines 2020-06-02 22:57:03 +00:00
text all: use a hermetic "go" tool in standard-library tests 2020-05-21 21:17:48 +00:00
time time: note that formats may parse invalid strings 2020-06-02 22:20:47 +00:00
unicode
unsafe
vendor all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
Make.dist
README.vendor
all.bash
all.bat all: treat all files as binary, but check in .bat with CRLF 2020-06-08 15:31:43 +00:00
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat all: treat all files as binary, but check in .bat with CRLF 2020-06-08 15:31:43 +00:00
clean.rc
cmp.bash
go.mod all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
go.sum all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
iostest.bash
make.bash
make.bat all: treat all files as binary, but check in .bat with CRLF 2020-06-08 15:31:43 +00:00
make.rc
race.bash
race.bat all: treat all files as binary, but check in .bat with CRLF 2020-06-08 15:31:43 +00:00
run.bash
run.bat run.bat: do not unset GOROOT_FINAL before running tests 2020-06-10 03:27:28 +00:00
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.