mirror of https://github.com/golang/go.git
b3b8d2bfeb
Fix a build failure when bootstrapping the Go compiler with go-bootstrap 1.4
while the environment contains GOARCH=riscv64.
Building Go toolchain1 using go-1.4-bootstrap-20171003.
src/cmd/compile/internal/ssa/rewriteRISCV64.go:4814
invalid operation: y << x (shift count type int64, must be unsigned integer)
This is because:
- buildtool.go:198: calls bootstrapRewriteFile(src)
- bootstrapRewriteFile: buildtool.go:283 calls:
- isUnneededSSARewriteFile: checks os.Getenv("GOARCH")
- isUnneededSSARewriteFile: returns "", false
- bootstrapRewriteFile: calls bootstrapFixImports
- boostrapFixImports: generates code go1.4 cannot compile
Instead of checking "GOARCH" in the environment, use the gohostarch variable.
Change-Id: Ie9c190498555c4068461fead6278a62e924062c6
GitHub-Last-Rev:
|
||
|---|---|---|
| .. | ||
| README | ||
| build.go | ||
| buildgo.go | ||
| buildruntime.go | ||
| buildtag.go | ||
| buildtag_test.go | ||
| buildtool.go | ||
| doc.go | ||
| exec.go | ||
| imports.go | ||
| main.go | ||
| quoted.go | ||
| sys_default.go | ||
| sys_windows.go | ||
| test.go | ||
| test_linux.go | ||
| util.go | ||
| util_gc.go | ||
| util_gccgo.go | ||
| vfp_arm.s | ||
| vfp_default.s | ||
README
This program, dist, is the bootstrapping tool for the Go distribution. As of Go 1.5, dist and other parts of the compiler toolchain are written in Go, making bootstrapping a little more involved than in the past. The approach is to build the current release of Go with an earlier one. The process to install Go 1.x, for x ≥ 5, is: 1. Build cmd/dist with Go 1.4. 2. Using dist, build Go 1.x compiler toolchain with Go 1.4. 3. Using dist, rebuild Go 1.x compiler toolchain with itself. 4. Using dist, build Go 1.x cmd/go (as go_bootstrap) with Go 1.x compiler toolchain. 5. Using go_bootstrap, build the remaining Go 1.x standard library and commands. NOTE: During the transition from the old C-based toolchain to the Go-based one, step 2 also builds the parts of the toolchain written in C, and step 3 does not recompile those. Because of backward compatibility, although the steps above say Go 1.4, in practice any release ≥ Go 1.4 but < Go 1.x will work as the bootstrap base. See golang.org/s/go15bootstrap for more details. Compared to Go 1.4 and earlier, dist will also take over much of what used to be done by make.bash/make.bat/make.rc and all of what used to be done by run.bash/run.bat/run.rc, because it is nicer to implement that logic in Go than in three different scripting languages simultaneously.