mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/internal/lsp
History
Muir Manders a6aac22fcd internal/lsp: fix find-implementation for promoted methods 
We weren't returning promoted methods as implementations when the
promoted method was defined in a different package than the type
implementing the interface.

Fix by properly mapping the implementer types.Object to its containing
source.Package.

I generalized the implementations() result to just contain the
implementer objects and their containing package. This allowed me to
get rid of some result prep code in Implementation().

Fixes golang/go#35972.

Change-Id: I867f2114c34e2ad39515ee3c8b6354c1cd35f7af
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210280
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
 		2019-12-16 21:36:29 +00:00
..
browser
…
cache internal/lsp: create parseModHandle for storing go.mod data 2019-12-13 22:03:54 +00:00
cmd internal/lsp, internal/tool: clean up command line of gopls 2019-12-16 17:36:52 +00:00
debug internal/lsp: fix the debug info pages 2019-11-04 23:16:26 +00:00
diff internal/lsp: fix unified diffs of edits at the end of a file 2019-10-11 16:38:14 +00:00
fuzzy internal/lsp: fix fuzzy matcher inconsistency 2019-10-22 21:05:28 +00:00
protocol internal/lsp: Make Text in DidSave at *string rather than a string 2019-12-10 20:07:04 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp: fix find-implementation for promoted methods 2019-12-16 21:36:29 +00:00
telemetry internal/lsp: call load in (*session).NewView 2019-11-07 23:34:59 +00:00
testdata internal/lsp: fix find-implementation for promoted methods 2019-12-16 21:36:29 +00:00
tests internal/lsp/tests: add error handling for @item() 2019-12-13 18:39:29 +00:00
code_action.go internal/lsp: rename CheckPackageHandle to PackageHandle 2019-12-02 18:29:46 +00:00
command.go internal/lsp: fix panic in bestView 2019-11-16 21:44:31 +00:00
completion.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
completion_test.go internal/lsp: offer basic type conversion candidates 2019-12-12 22:41:01 +00:00
definition.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
diagnostics.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
folding_range.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
format.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
general.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00
highlight.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
hover.go internal/lsp: improve link in documentation on hover 2019-12-12 22:39:21 +00:00
implementation.go internal/lsp: fix find-implementation for promoted methods 2019-12-16 21:36:29 +00:00
link.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
lsp_test.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
references.go internal/lsp: fix find-references to search from all package variants 2019-12-11 23:36:49 +00:00
rename.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server.go internal/lsp: don't resend diagnostics if they are unchanged 2019-12-12 04:27:51 +00:00
signature_help.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
symbols.go internal/lsp: add handling for go.mod files in internal/lsp functions 2019-12-11 23:24:34 +00:00
text_synchronization.go internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
watched_files.go internal/lsp: move DidModifyFile into internal/lsp/cache 2019-12-12 03:49:59 +00:00
workspace.go internal/lsp: return snapshot when creating a view 2019-12-05 13:33:17 +00:00