go/src
Cholerae Hu a6755fc0de cmd/compile: check indirect connection between if block and phi block in addLocalInductiveFacts
CL 244579 added guard clauses to prevent a faulty state that was
possible under the incorrect logic of the uniquePred loop in
addLocalInductiveFacts. That faulty state was still making the
intended optimization, but not for the correct reason.
Removing the faulty state also removed the overly permissive application
of the optimization, and therefore made these two tests fail.
We disabled the tests of this optimization in CL 244579 to allow us to
quickly apply the fix in the CL. This CL now corrects the logic of the
uniquePred loop in order to apply the optimization correctly.

The comment above the uniquePred loop says that it will follow unique
predecessors until it reaches a join point. Without updating the child
node on each iteration, it cannot follow the chain of unique
predecessors more than one step. Adding the update to the child node
on each iteration of the loop allows the logic to follow the chain of
unique predecessors until reaching a join point (because a non-unique
predecessor will signify a join point).

Updates #40502.

Change-Id: I23d8367046a2ab3ce4be969631f9ba15dc533e6c
Reviewed-on: https://go-review.googlesource.com/c/go/+/246157
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
2020-11-07 07:33:23 +00:00
..
archive archive/zip: fix documentation to mention fs.FS interface 2020-11-07 03:52:47 +00:00
bufio
builtin
bytes
cmd cmd/compile: check indirect connection between if block and phi block in addLocalInductiveFacts 2020-11-07 07:33:23 +00:00
compress
container
context
crypto crypto/cipher: use Neon for xor on arm64 2020-11-07 03:19:27 +00:00
database/sql database/sql, runtime: correct *.Fatal inside goroutines in tests 2020-10-31 20:30:19 +00:00
debug cmd/link: emit include directories in DWARF line table prologue 2020-10-30 18:01:54 +00:00
embed cmd/go: add //go:embed support 2020-10-29 16:26:43 +00:00
encoding
errors
expvar
flag
fmt
go go/types: add unexported start and end positions to type checker errors 2020-11-05 20:35:00 +00:00
hash
html
image
index/suffixarray
internal cmd/go: revert "add GOVCS setting to control version control usage" 2020-11-05 15:16:57 +00:00
io io/fs: add WalkDir 2020-11-06 19:42:05 +00:00
log
math math/big: reduce allocations for building decimal strings 2020-10-29 22:45:29 +00:00
mime
net net/mail: avoid ParseDate confusion if day name includes "T" 2020-11-05 02:48:05 +00:00
os os: remove unused variable in unix implementation of File.readdir 2020-11-05 16:20:01 +00:00
path io/fs: add WalkDir 2020-11-06 19:42:05 +00:00
plugin
reflect reflect: update NumMethod doc for interface type 2020-11-03 00:50:57 +00:00
regexp
runtime runtime: make stack traces of endless recursion print only top and bottom 50 2020-11-06 23:53:49 +00:00
sort
strconv strconv: revert ParseFloat/ParseComplex error on incorrect bitSize 2020-11-03 23:05:51 +00:00
strings strings: complete Reader doc string 2020-10-30 00:23:50 +00:00
sync
syscall syscall: expose bInheritHandles of CreateProcess 2020-11-05 02:28:14 +00:00
testdata
testing
text
time time: fix LoadLocationFromTZData with slim tzdata 2020-10-27 23:36:05 +00:00
unicode
unsafe
vendor all: update dependency on golang.org/x/sys and regenerate Windows syscalls 2020-11-02 15:41:00 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update dependency on golang.org/x/sys and regenerate Windows syscalls 2020-11-02 15:41:00 +00:00
go.sum all: update dependency on golang.org/x/sys and regenerate Windows syscalls 2020-11-02 15:41:00 +00:00
make.bash
make.bat
make.rc
race.bash race.bash: add darwin/arm64 2020-11-04 21:02:29 +00:00
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.