a30116df7a
appliesFn and suggestedFixFn were blocking eliminating the source.Command dynamic configuration. Remove them, and along the way refactor command dispatch to align better with the new internal/lsp/command package. This involved refactoring the internal/lsp/command.go as follows: - create a new commandHandler type, which will eventually implement command.Interface. - create a commandDeps struct to hold command dependencies. - move command functionality into methods on commandHandler. Of these, there are likely to be at least a couple points of controvery: I decided to store the ctx on the commandHandler, because I preferred it to threading a context through command.Interface when it isn't needed. We should revisit this in a later CL. I opted for a sparse commandDeps struct, rather than either explicit resolution of dependencies where necessary, or something more abstract like a proper dependency resolution pattern. It saved enough boilerplate that I deemed it worthwhile, but didn't want to commit to something more sophisticated. Actually switching to the internal/lsp/command package will happen in a later CL. Change-Id: I71502fc68f51f1b296bc529ee2885f7547145e92 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289970 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> |
||
|---|---|---|
| benchmark/parse | ||
| blog | ||
| cmd | ||
| container/intsets | ||
| copyright | ||
| cover | ||
| go | ||
| godoc | ||
| gopls | ||
| imports | ||
| internal | ||
| playground | ||
| present | ||
| refactor | ||
| txtar | ||
| .gitattributes | ||
| .gitignore | ||
| .prettierrc | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| codereview.cfg | ||
| go.mod | ||
| go.sum | ||
README.md
Go Tools
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go
distributions.
Others, including the Go guru and the test coverage tool, can be fetched with
go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
Download/Install
The easiest way to install is to run go get -u golang.org/x/tools/.... You can
also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
JS/CSS Formatting
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
Report Issues / Send Patches
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with "x/tools/(your subdir):" in the subject line, so it is easy to find.