9f16620f46
Sym.pkgDefPtr is supposed to return a pointer to the types.Object variable currently holding the Sym's package-scope definition. However, in the case of identifiers that were shadowed in the current scope, it was incorrectly returning a pointer to a stack copy of the dclstack variable, rather than a pointer into the dclstack itself. This doesn't affect PkgDef, because it only reads from the variable, so it got the same result anyway. It also happens to not affect our usage of SetPkgDef today, because we currently only call SetPkgDef for the builtin/runtime.go symbols, and those are never shadowed. However, it does affect my upcoming CL to lazily create the ir.Names for imported objects, as that depends on the ability to use SetPkgDef to set shadowed identifiers. Passes buildall w/ toolstash -cmp. Change-Id: I54fc48b33da0670d31725faa1df1170a8730750a Reviewed-on: https://go-review.googlesource.com/c/go/+/277712 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| favicon.ico | ||
| robots.txt | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.