mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/test
History
Matthew Dempsky 9dce58d30d runtime/internal/atomic: remove bad go:noescape annotations on Loadp 
The //go:noescape directive says that arguments don't leak at all,
which is too aggressive of a claim for functions that return pointers
derived from their parameters.

Remove the directive for now. Long term fix will require a new
directive that allows more fine-grained control over escape analysis
information supplied for functions implemented in assembly.

Also, update the BAD comments in the test cases for Loadp: we really
want that *ptr leaks to the result parameter, not that *ptr leaks to
the heap.

Updates #31525.

Change-Id: Ibfa61f2b70daa7ed3223056b57eeee777eef2e31
Reviewed-on: https://go-review.googlesource.com/c/go/+/172578
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
 		2019-04-17 19:09:15 +00:00
..
alias3.dir
…
bench test/bench/go1: add go.mod file 2019-03-06 18:53:12 +00:00
chan test/chan: fix broken link to Squinting at Power Series 2019-02-06 20:54:16 +00:00
closure3.dir cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
codegen cmd/compile: handle new panicindex/slice names in optimizations 2019-04-03 21:24:17 +00:00
ddd2.dir
…
dwarf
…
fixedbugs test: add escape regress for empty variadic function 2019-04-17 17:05:53 +00:00
import2.dir
…
import4.dir
…
interface
…
intrinsic.dir
…
ken
…
linkname.dir cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
method4.dir
…
oldescape_linkname.dir cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
retjmp.dir
…
stress
…
syntax
…
uintptrescapes.dir
…
64bit.go
…
235.go
…
README.md
…
alg.go
…
alias.go
…
alias1.go
…
alias2.go
…
alias3.go
…
align.go
…
append.go
…
append1.go
…
args.go
…
armimm.go
…
assign.go
…
assign1.go
…
atomicload.go
…
bigalg.go
…
bigmap.go
…
blank.go
…
blank1.go
…
bom.go
…
bombad.go
…
bounds.go
…
chancap.go runtime: handle 64bits addresses for AIX 2018-11-26 14:06:28 +00:00
chanlinear.go
…
char_lit.go
…
char_lit1.go
…
checkbce.go cmd/compile: fix ordering for short-circuiting ops 2019-03-06 20:04:07 +00:00
clearfat.go
…
closedchan.go
…
closure.go
…
closure1.go
…
closure2.go
…
closure3.go all: fix a bunch of misspellings 2018-10-06 15:40:03 +00:00
closure4.go
…
cmp.go
…
cmp6.go
…
cmplx.go cmd/compile: rewrite f(g()) for multi-value g() during typecheck 2019-03-14 21:00:20 +00:00
cmplxdivide.c
…
cmplxdivide.go
…
cmplxdivide1.go
…
complit.go
…
complit1.go
…
compos.go
…
const.go
…
const1.go cmd/compile: fix ICE from invalid operations on float/complex constants 2019-03-28 17:46:55 +00:00
const2.go
…
const3.go
…
const4.go
…
const5.go
…
const6.go
…
convT2X.go
…
convert.go
…
convert1.go
…
convert2.go
…
convert3.go
…
convlit.go
…
convlit1.go
…
copy.go
…
copy1.go cmd/compile: rewrite f(g()) for multi-value g() during typecheck 2019-03-14 21:00:20 +00:00
crlf.go
…
ddd.go
…
ddd1.go
…
ddd2.go
…
decl.go
…
declbad.go
…
defer.go
…
deferfin.go
…
deferprint.go
…
deferprint.out
…
devirt.go
…
divide.go
…
divmod.go
…
empty.go
…
env.go
…
eof.go
…
eof1.go
…
escape.go
…
escape2.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape2n.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape3.go
…
escape4.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape5.go test: add regress test for issue 28369 2019-04-16 21:01:30 +00:00
escape_array.go cmd/compile: trim more unnecessary escape analysis messages 2019-04-02 18:00:32 +00:00
escape_because.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_calls.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_closure.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_field.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_iface.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_indir.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_level.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_map.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_param.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_runtime_atomic.go runtime/internal/atomic: remove bad go:noescape annotations on Loadp 2019-04-17 19:09:15 +00:00
escape_selfassign.go test: add regress test cases for self-assignment 2019-04-17 16:36:56 +00:00
escape_slice.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_struct_param1.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_struct_param2.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
escape_struct_return.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
escape_sync_atomic.go runtime/internal/atomic: remove bad go:noescape annotations on Loadp 2019-04-17 19:09:15 +00:00
escape_unsafe.go test: add regress tests for unsafe.Pointer rules 2019-04-03 16:03:55 +00:00
fibo.go
…
finprofiled.go
…
float_lit.go
…
float_lit2.go
…
float_lit3.go
…
floatcmp.go
…
for.go
…
func.go
…
func1.go
…
func2.go
…
func3.go
…
func4.go
…
func5.go
…
func6.go
…
func7.go
…
func8.go
…
funcdup.go
…
funcdup2.go
…
gc.go
…
gc1.go
…
gc2.go
…
gcgort.go
…
gcstring.go
…
goprint.go
…
goprint.out
…
goto.go
…
heapsampling.go test: improve test coverage for heap sampling 2019-03-07 21:05:15 +00:00
helloworld.go
…
helloworld.out
…
if.go
…
import.go
…
import1.go
…
import2.go
…
import4.go
…
import5.go
…
import6.go
…
index.go
…
index0.go
…
index1.go
…
index2.go
…
indirect.go
…
indirect1.go
…
init.go cmd/compile: reorganize init functions 2019-03-18 20:10:55 +00:00
init1.go
…
initcomma.go
…
initialize.go
…
initializerr.go
…
initloop.go
…
inline.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
inline_big.go
…
inline_caller.go runtime: make FuncForPC return the innermost inlined frame 2019-01-08 21:54:04 +00:00
inline_callers.go runtime: make FuncForPC return the innermost inlined frame 2019-01-08 21:54:04 +00:00
inline_literal.go
…
inline_math_bits_rotate.go
…
inline_sync.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
inline_variadic.go
…
int_lit.go
…
intcvt.go
…
intrinsic.go
…
intrinsic_atomic.go
…
iota.go
…
label.go
…
label1.go
…
linkmain.go
…
linkmain_run.go
…
linkname.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
linkobj.go
…
linkx.go
…
linkx_run.go
…
literal.go
…
literal2.go cmd/compile: accept 'i' suffix orthogonally on all numbers 2019-02-19 22:45:09 +00:00
live.go cmd/compile: fix ordering for short-circuiting ops 2019-03-06 20:04:07 +00:00
live1.go
…
live2.go cmd/compile,runtime: remove ambiguously live logic 2018-10-03 19:54:16 +00:00
live_syscall.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
locklinear.go
…
loopbce.go cmd/compile: reverse order of slice bounds checks 2019-03-09 00:52:45 +00:00
makechan.go
…
makemap.go
…
makenew.go
…
mallocfin.go
…
map.go
…
map1.go
…
mapclear.go
…
maplinear.go
…
mergemul.go
…
method.go
…
method1.go
…
method2.go
…
method3.go
…
method4.go
…
method5.go
…
method6.go
…
method7.go
…
named.go
…
named1.go
…
nil.go
…
nilcheck.go
…
nilptr.go cmd/compile: fix nilcheck for AIX 2018-11-26 14:13:53 +00:00
nilptr2.go
…
nilptr3.go cmd/compile: fix nilcheck for AIX 2018-11-26 14:13:53 +00:00
nilptr4.go
…
nilptr5.go cmd/compile: fix nilcheck for AIX 2018-11-26 14:13:53 +00:00
nilptr5_aix.go test: fix nilptr5 for AIX 2018-11-27 15:36:08 +00:00
nilptr5_wasm.go cmd/compile: fix nilcheck for AIX 2018-11-26 14:13:53 +00:00
nilptr_aix.go cmd/compile: fix nilcheck for AIX 2018-11-26 14:13:53 +00:00
nosplit.go ../test: set GOPATH in nosplit.go 2019-03-12 20:46:29 +00:00
notinheap.go cmd/compile: disallow converting string to notinheap slice 2018-11-02 19:53:59 +00:00
notinheap2.go
…
notinheap3.go cmd/compile: omit write barriers for slice clears of go:notinheap pointers 2018-12-05 21:54:54 +00:00
nowritebarrier.go
…
nul1.go
…
oldescape2.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape2n.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape5.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_calls.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_closure.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_field.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_iface.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_linkname.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_param.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
oldescape_struct_return.go cmd/compile: update escape analysis tests for newescape 2019-04-16 16:20:39 +00:00
opt_branchlikely.go
…
parentype.go
…
peano.go
…
phiopt.go
…
print.go
…
print.out
…
printbig.go
…
printbig.out
…
prove.go cmd/compile: make prove learn index >= 0 from successful bounds checks 2019-03-30 23:22:02 +00:00
range.go
…
recover.go
…
recover1.go
…
recover2.go
…
recover3.go
…
recover4.go
…
recover5.go
…
reflectmethod1.go
…
reflectmethod2.go
…
reflectmethod3.go
…
reflectmethod4.go
…
rename.go
…
rename1.go
…
reorder.go
…
reorder2.go
…
retjmp.go
…
return.go
…
rotate.go
…
rotate0.go
…
rotate1.go
…
rotate2.go
…
rotate3.go
…
run.go cmd/compile: handle new panicindex/slice names in optimizations 2019-04-03 21:24:17 +00:00
rune.go
…
runtime.go
…
shift1.go
…
shift2.go
…
sieve.go
…
sigchld.go
…
sigchld.out
…
simassign.go
…
sinit.go cmd/compile: fix static initializer 2018-12-03 16:48:21 +00:00
sinit_run.go
…
sizeof.go
…
slice3.go
…
slice3err.go
…
slicecap.go
…
sliceopt.go
…
solitaire.go
…
stack.go
…
stackobj.go cmd/compile,runtime: remove ambiguously live logic 2018-10-03 19:54:16 +00:00
stackobj2.go test: stress test for stack objects 2018-10-03 19:54:29 +00:00
stackobj3.go cmd/compile,runtime: remove ambiguously live logic 2018-10-03 19:54:16 +00:00
strcopy.go
…
strength.go
…
string_lit.go
…
stringrange.go
…
struct0.go
…
switch.go
…
switch2.go
…
switch3.go
…
switch4.go
…
switch5.go Revert "fmt: fix incorrect format of whole-number floats when using %#v" 2018-10-16 21:54:35 +00:00
switch6.go
…
switch7.go
…
tinyfin.go
…
torture.go
…
turing.go
…
typecheck.go
…
typecheckloop.go
…
typeswitch.go
…
typeswitch1.go
…
typeswitch2.go test: fix spelling of `caught be the compiler` to `caught by the compiler` 2018-10-04 00:49:49 +00:00
typeswitch3.go test: fix spelling of `caught be the compiler` to `caught by the compiler` 2018-10-04 00:49:49 +00:00
uintptrescapes.go
…
uintptrescapes2.go cmd/compile: skip escape analysis diagnostics for OADDR 2019-04-02 16:34:03 +00:00
undef.go
…
utf.go
…
varerr.go
…
varinit.go
…
writebarrier.go cmd/compile: better write barrier removal when initializing new objects 2019-03-18 21:16:19 +00:00
zerodivide.go
…

README.md

The test directory contains tests of the Go tool chain and runtime. It includes black box tests, regression tests, and error output tests. They are run as part of all.bash.

To run just these tests, execute:

../bin/go run run.go

Standard library tests should be written as regular Go tests in the appropriate package.

The tool chain and runtime also have regular Go tests in their packages. The main reasons to add a new test to this directory are:

  • it is most naturally expressed using the test runner; or
  • it is also applicable to gccgo and other Go tool chains.