Heschi Kreinick 9611592c72 internal/lsp/cache: fix load race, refactor ... As far as I can tell, the code I removed in from load did roughly nothing -- returning nil metadata didn't suppress type checking as I think was intended. Throwing away the metadata also created the race in Pull the check for missing import changes up to PackageHandles, where it is non-racy and can cause type checking to be skipped. Simplify and refactor. Fixes golang/go#35951. Change-Id: Id4b32b86569afb36863aaf982616b2b3727b0e83 Reviewed-on: https://go-review.googlesource.com/c/tools/+/209737 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>		2019-12-04 01:13:08 +00:00
..
apidiff	all: fix more typos	2019-09-11 15:13:14 +00:00
fastwalk	internal/fastwalk: avoid slice bounds out of range for long file names	2018-11-12 23:16:31 +00:00
gopathwalk	internal/imports: cache things outside the mod cache	2019-10-21 20:45:41 +00:00
imports	internal/imports: make ApplyFixes work despite syntax errors	2019-12-02 20:30:33 +00:00
jsonrpc2	internal/lsp: cancel early	2019-10-22 07:49:31 +00:00
lsp	internal/lsp/cache: fix load race, refactor	2019-12-04 01:13:08 +00:00
memoize	internal/memoize: propagate cancellation	2019-11-12 23:22:37 +00:00
module	imports: stop using go/packages for modules	2019-01-22 20:29:12 +00:00
semver	go/packages: add name= query	2018-10-16 20:20:09 +00:00
span	internal/span: support line directives	2019-11-25 19:20:43 +00:00
telemetry	internal/telemetry: lift the tests up to the request level	2019-11-27 15:41:43 +00:00
testenv	internal/testenv: reject the resolved 'go' command if it does not match runtime.GOROOT	2019-11-11 19:22:22 +00:00
tool	tools/internal/tool: refactor tool.Main() for testabilty	2019-09-19 22:27:22 +00:00
xcontext	internal/lsp: stop making background contexts everywhere	2019-07-11 16:38:52 +00:00