mirror of https://github.com/golang/go.git
078a9cbc6c
In cgo, now that recursive calls to typeConv.Type() always work, we can more robustly calculate the array sizes based on the size of our element type. Also, in debug/dwarf, the decision to call zeroType is made based on a type's usage within a particular struct, but dwarf.Type values are cached in typeCache, so the modification might affect uses of the type in other structs. Current compilers don't appear to share DWARF type entries for "[]foo" and "[0]foo", but they also don't consistently share type entries in other cases. Arguably modifying the types is an improvement in some cases, but varying translated types according to compiler whims seems like a bad idea. Lastly, also in debug/dwarf, zeroType only needs to rewrite the top-level dimension, and only if the rest of the array size is non-zero. Fixes #8428. LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/127980043 |
||
|---|---|---|
| .. | ||
| android | ||
| arm | ||
| cgo | ||
| chrome/gophertool | ||
| dashboard/codereview | ||
| git | ||
| linkcheck | ||
| makerelease | ||
| nacl | ||
| swig | ||
| benchcmp | ||
| editors | ||
| pprof | ||