mirror of https://github.com/golang/go.git
As part of debugging CL 324394, I found that we were returning intermediate test variant packages in packageHandlesForFile. This happened because, even though these packages were not workspace packages, they would still be picked up by the file URIs -> IDs map. This is typically not a problem when we are picking out the widest or narrowest package for a specific request, but for diagnostics on changed files, we run them on all of the possible packages. This also led to us analyzing these intermediate test variant packages. Filter them out, as we will never want them for this purpose. Change-Id: Ifa780cd104f9c4b3fe6c530402956e2337c8fcdc Reviewed-on: https://go-review.googlesource.com/c/tools/+/324689 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> |
||
|---|---|---|
| .. | ||
| analysis.go | ||
| cache.go | ||
| check.go | ||
| error_test.go | ||
| errors.go | ||
| imports.go | ||
| keys.go | ||
| load.go | ||
| mod.go | ||
| mod_tidy.go | ||
| os_darwin.go | ||
| os_windows.go | ||
| parse.go | ||
| parse_test.go | ||
| pkg.go | ||
| session.go | ||
| snapshot.go | ||
| view.go | ||
| view_test.go | ||
| workspace.go | ||
| workspace_test.go | ||