mirror of https://github.com/golang/go.git
f659183972
exec_test.go's init function uses os.NewFile(fd) + f.Stat as a portable mechanism to determine if an FD is in use. Unfortunately, the current use is racy: if an unused FD becomes used between NewFile and f.Close, then we will unintentionally close an FD we do not use. We cannot simply drop Close, as the finalizer will close the FD. We could hold all of the os.Files in a global for the lifetime of the process, but the need for such a hack is indicative of the larger problem: we should not create an os.File for an FD that we do not own. Instead, the new fdtest.Exists provides a helper that performs the equivalent of fstat(2) on each OS to determine if the FD is valid, without using os.File. We also reuse this helper on a variety of other tests that look at open FDs. Fixes #49533 Change-Id: I36e2bdb15f271ab01e55c18db6564271995a15af Reviewed-on: https://go-review.googlesource.com/c/go/+/364035 Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> |
||
|---|---|---|
| .. | ||
| internal/fdtest | ||
| bench_test.go | ||
| env_test.go | ||
| example_test.go | ||
| exec.go | ||
| exec_linux_test.go | ||
| exec_plan9.go | ||
| exec_posix_test.go | ||
| exec_test.go | ||
| exec_unix.go | ||
| exec_windows.go | ||
| exec_windows_test.go | ||
| internal_test.go | ||
| lp_js.go | ||
| lp_plan9.go | ||
| lp_test.go | ||
| lp_unix.go | ||
| lp_unix_test.go | ||
| lp_windows.go | ||
| lp_windows_test.go | ||
| read3.go | ||