mirror of https://github.com/golang/go.git
CL 333289 introduced a panic, which was subsequently suppressed in test error output due to the deferred t.Fatal (an interesting gotcha that I honestly wasn't aware of). Fix both the panic, and the suppression of regtest panics. Also fix the regtest editor shutdown to run on a detached context, so that shutdown doesn't fail for tests that have timed out. For golang/go#46773 Change-Id: I080a713ae4cd4651476d8b4aab1d2291754a4f5a Reviewed-on: https://go-review.googlesource.com/c/tools/+/333510 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| jsonrpc2_v2 | ||
| lsp | ||
| memoize | ||
| mod | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typeparams | ||
| typesinternal | ||
| xcontext | ||