go/gopls/internal/regtest
Rob Findley 8e32e9f144 internal/lsp/regtest: fix a panic TestResolveImportCycle
CL 333289 introduced a panic, which was subsequently suppressed in test
error output due to the deferred t.Fatal (an interesting gotcha that I
honestly wasn't aware of).

Fix both the panic, and the suppression of regtest panics.

Also fix the regtest editor shutdown to run on a detached context, so
that shutdown doesn't fail for tests that have timed out.

For golang/go#46773

Change-Id: I080a713ae4cd4651476d8b4aab1d2291754a4f5a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/333510
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2021-07-09 17:21:04 +00:00
..
bench internal/lsp/regtest: add a benchmark for didChange 2021-05-06 02:57:18 +00:00
codelens internal/lsp/cache: invalidate packages in setMetadata 2021-07-08 19:53:41 +00:00
completion internal/lsp/cache: don't delete metadata until it's reloaded 2021-06-16 00:19:40 +00:00
diagnostics internal/lsp/regtest: allow for unsent diagnostics in TestResolveImportCycle 2021-07-08 19:58:58 +00:00
misc internal/lsp/regtest: fix a panic TestResolveImportCycle 2021-07-09 17:21:04 +00:00
modfile internal/lsp/regtest: run one quick fix at a time in TestUnknownRevision 2021-05-03 21:45:16 +00:00
watch gopls/internal/regtest: clean up TestFillReturnsPanic 2021-06-03 18:03:08 +00:00
workspace internal/lsp: start parsing go.work file like gopls.mod file 2021-06-24 04:20:31 +00:00