mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/internal/lsp
History
Rob Findley 8ddc06776e internal/lsp/source: don't link to packages matching GOPRIVATE in hover 
Currently, our hover text by default links point to public documentation
sites (e.g. pkg.go.dev). This doesn't make sense for private repos, so
hide the hovertext link when the import path matches GOPRIVATE.

Implementing this was a little messy. To be optimal I had to thread
the value of goprivate through cache.view, and to be correct I had to
duplicate some code from cmd/go internal.

Regtest will follow after https://golang.org/cl/232983 is submitted.

Updates golang/go#36998

Change-Id: I1e556471bf919fea30132d9642426a08fdb7f434
Reviewed-on: https://go-review.googlesource.com/c/tools/+/233524
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
 		2020-05-15 19:36:02 +00:00
..
analysis internal/lsp: add type error fixes to existing diagnostics 2020-04-08 01:45:16 +00:00
browser
…
cache internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00
cmd internal/lsp/cmd: fix not displaying symbols result 2020-05-11 23:26:04 +00:00
debug internal/event: improve the logging of events 2020-05-11 17:49:55 +00:00
diff internal/testenv: check that external 'diff' tool is the GNU version 2020-05-08 20:46:49 +00:00
fake internal/lsp/regtest: add regression test for golang/go#36960 2020-05-12 00:15:01 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp/fake: fix some messiness around client hooks 2020-05-08 18:47:54 +00:00
mod internal/lsp: support configurable codeLens 2020-05-08 18:47:35 +00:00
protocol internal/event: improve the logging of events 2020-05-11 17:49:55 +00:00
regtest internal/lsp/regtest: don't build unix_test for Plan 9 2020-05-13 12:28:04 +00:00
snippet
…
source internal/lsp/source: don't link to packages matching GOPRIVATE in hover 2020-05-15 19:36:02 +00:00
testdata internal/lsp: use TypecheckCgo when possible 2020-05-13 17:53:51 +00:00
tests internal/lsp: use TypecheckCgo when possible 2020-05-13 17:53:51 +00:00
code_action.go internal/lsp: don't offer suggested fixes for generated files 2020-05-01 06:56:59 +00:00
command.go internal/lsp: add `run test` code lens 2020-05-12 13:19:52 +00:00
completion.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
completion_test.go internal/lsp: correctly handle type aliases when formatting 2020-04-23 20:53:58 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: avoid showing no-GOPATH-nor-module message so much 2020-05-02 20:28:11 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
generate.go internal/lsp: add `run test` code lens 2020-05-12 13:19:52 +00:00
highlight.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/telemetry: renaming to internal/event 2020-04-23 17:20:48 +00:00
lsp_test.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00
progress.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh
…
server.go internal/lsp: factor out progress reporting to a new WorkDone handle 2020-04-28 20:46:18 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
signature_help.go internal/event: extract keys to their own package 2020-04-23 18:13:43 +00:00
symbols.go internal/event: renaming the main event API functions 2020-04-23 17:21:36 +00:00
text_synchronization.go internal/lsp: instrument work done reporting to use in regtests 2020-04-28 20:46:32 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00
workspace_symbol.go internal/lsp: add config option for SymbolMatch 2020-05-11 19:58:58 +00:00