go/src
Lynn Boger 2d3474043c cmd/compile: call ginsnop, not ginsnop2 on ppc64le for mid-stack inlining tracebacks
A recent change to fix stacktraces for inlined functions
introduced a regression on ppc64le when compiling position
independent code. That happened because ginsnop2 was called for
the purpose of inserting a NOP to identify the location of
the inlined function, when ginsnop should have been used.
ginsnop2 is intended to be used before deferreturn to ensure
r2 is properly restored when compiling position independent code.
In some cases the location where r2 is loaded from might not be
initialized. If that happens and r2 is used to generate an address,
the result is likely a SEGV.

This fixes that problem.

Fixes #30283

Change-Id: If70ef27fc65ef31969712422306ac3a57adbd5b6
Reviewed-on: https://go-review.googlesource.com/c/163337
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2019-02-25 18:08:46 +00:00
..
archive src, misc: apply gofmt 2019-02-19 20:38:28 +00:00
bufio bufio: document relationship between UnreadByte/UnreadRune and Peek 2019-01-08 23:47:27 +00:00
builtin
bytes bytes: add ReplaceAll example 2018-12-13 19:40:13 +00:00
cmd cmd/compile: call ginsnop, not ginsnop2 on ppc64le for mid-stack inlining tracebacks 2019-02-25 18:08:46 +00:00
compress src, misc: apply gofmt 2019-02-19 20:38:28 +00:00
container
context
crypto crypto/rc4: remove false guarantees from Reset docs and deprecate it 2019-02-22 17:05:17 +00:00
database/sql database/sql/driver: fix typo 2019-02-15 17:23:55 +00:00
debug debug/gosym: remove outdated comment 2019-01-09 14:44:28 +00:00
encoding encoding/json: add comment for mashalererror struct 2019-01-15 23:30:58 +00:00
errors
expvar
flag flag: improve docs for PrintDefaults; clarify how to change output destination 2019-01-21 05:30:12 +00:00
fmt fmt: include failing method name in panic message 2018-12-13 22:41:52 +00:00
go go/build: add go1.13 release tag 2019-02-20 21:44:53 +00:00
hash
html text/html: escape MIME type "application/ld+json" as JavaScript 2018-12-13 22:45:02 +00:00
image
index/suffixarray
internal internal/x/net/http2/hpack: update from upstream 2018-12-14 18:15:56 +00:00
io
log
math src, misc: apply gofmt 2019-02-19 20:38:28 +00:00
mime mime/multipart: quote boundary in Content-Type if necessary 2018-12-13 23:58:06 +00:00
net net/http/httputil: make TestDumpRequest idempotent 2019-02-13 16:58:53 +00:00
os os: don't return ENOENT if directory removed before Fstatat 2019-02-12 21:17:38 +00:00
path path/filepath: revert "fix Windows-specific Clean bug" 2019-02-20 18:32:07 +00:00
plugin
reflect reflect: eliminate write barrier for copying result in callReflect 2019-02-01 19:23:02 +00:00
regexp
runtime runtime: make tests that invoke 'go build' module-agnostic 2019-02-19 19:56:43 +00:00
sort sort: change let to let's 2019-01-27 01:34:56 +00:00
strconv strconv: add 0b, 0o integer prefixes in ParseInt, ParseUint 2019-02-12 14:48:26 +00:00
strings
sync sync/atomic: add 32-bit MIPS to the 64-bit alignment requirement 2019-02-09 23:07:07 +00:00
syscall syscall: skip TestSyscallNoError when temp dir is mounted nosuid 2019-02-15 19:24:37 +00:00
testdata
testing testing: report the failing test in a late log panic 2019-01-17 01:28:22 +00:00
text text/scanner: don't liberally consume (invalid) floats or underbars 2019-02-20 20:23:28 +00:00
time time: return ENOENT if a zoneinfo zip file is not found 2018-12-24 19:25:18 +00:00
unicode
unsafe
Make.dist
all.bash
all.bat
all.rc
androidtest.bash Revert "androidtest.bash: wait for device to be ready before using it" 2019-02-24 21:54:04 +00:00
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
iostest.bash
make.bash
make.bat
make.rc
naclmake.bash
nacltest.bash
race.bash
race.bat
run.bash
run.bat
run.rc