Muir Manders 88e652f7a8 internal/lsp/cache: improve completion after dangling selector ... Dangling selectors such as: func _() { x. } var x struct { i int } tend to wreak havoc on the AST. In the above example you didn't used to get completions because the declaration of "x" was missing from the AST. We now work around this issue by inserting a "_" into the source code before parsing to make the selector valid: func _() { x._ // <-- insert "_" here } var x struct { i int } This makes completion work as expected because the declaration of "x" is present in the AST. I had to change fixAST() to be called before fixSrc() because otherwise this new workaround in fixSrc() breaks the "accidental keyword" countermeasures in fixAST(). Fixes golang/go#31973. Updates golang/go#31687. Change-Id: Ia7ef6c045a9c71502d1b8b36f187ac9b8a85fe21 Reviewed-on: https://go-review.googlesource.com/c/tools/+/216484 Run-TryBot: Muir Manders <muir@mnd.rs> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-02-13 22:46:42 +00:00
..
analysis.go	internal/lsp/cache: hardcode parse modes instead of guessing them	2020-02-07 20:00:15 +00:00
cache.go	internal/lsp/debug: serve cache entry counts	2020-02-03 22:21:18 +00:00
check.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
debug.go	internal/lsp/cache: add Env to debugView	2020-01-31 20:48:24 +00:00
error_test.go	internal/lsp: refactor error handling code in type-checking	2019-10-21 18:57:46 +00:00
errors.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
external.go	internal/lsp: check that a file handle is unmodified before read	2020-01-23 20:52:07 +00:00
load.go	internal/lsp/cache: hardcode parse modes instead of guessing them	2020-02-07 20:00:15 +00:00
mod_tidy.go	internal/lsp: build overlays through the snapshot	2020-02-07 18:37:49 +00:00
parse.go	internal/lsp/cache: improve completion after dangling selector	2020-02-13 22:46:42 +00:00
pkg.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
session.go	internal/lsp: propagate file invalidations to all views	2020-02-11 18:37:05 +00:00
snapshot.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
view.go	internal/lsp: turn tempModfile flag on by default	2020-02-13 15:33:58 +00:00