go/src
Daniel Martí 8689ea6a4a cmd/go: make Script/test_regexps less flaky under load
With the command below, I was able to reproduce failures within the
first 50 or so runs:

	go test -c -o test && stress -p 32 ./test -test.run Script/test_regexp

When printing the full failure output, we'd see:

	BenchmarkX
	    BenchmarkX: x_test.go:13: LOG: X running N=1
	BenchmarkX/Y
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=100
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=10000
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=100000000
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000
	BenchmarkX/Y         	1000000000	         0.000050 ns/op
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=30
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1207
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=120700
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=12070000
	    BenchmarkX/Y: x_test.go:15: LOG: Y running N=1000000000
	BenchmarkX/Y         	1000000000	         0.000715 ns/op

In other words, the N values aren't required to be exact. It seems like
they are cut short if the machine is under stress. That's the exact
scenario we reproduce above, since I used -p=32 on my laptop with only 4
real CPU cores.

First, don't require each line to be present. Instead, use patterns
that span multiple lines, so that we can just match the first and last
N= lines.

Second, don't require the last N= lines to be exact; simply require
them to have a reasonably large number of digits.

Fixes #36664.

Change-Id: I7a9818f1a07099fa6482a26da2ac5cbea0f8ab30
Reviewed-on: https://go-review.googlesource.com/c/go/+/215578
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-01-23 18:03:09 +00:00
..
archive all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
bufio
builtin
bytes
cmd cmd/go: make Script/test_regexps less flaky under load 2020-01-23 18:03:09 +00:00
compress all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
container
context
crypto crypto/tls: stop a timeout timer 2020-01-15 20:29:46 +00:00
database/sql all: fix invalid invocations of Fatalf in goroutines 2020-01-03 01:36:26 +00:00
debug all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
encoding all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
errors
expvar
flag flag: clarify that a flag cannot be re-defined 2019-11-11 20:07:54 +00:00
fmt
go internal/poll: use fcntl64 on 32-bit GNU/Linux systems 2019-12-26 13:53:31 +00:00
hash hash/maphash: mark call into runtime hash function as not escaping 2019-11-16 20:31:45 +00:00
html html: update URL in comment 2020-01-13 07:00:18 +00:00
image
index/suffixarray
internal internal/poll: use correct fcntl implementations 2019-12-31 12:11:24 +00:00
io io: show ErrUnexpectedEOF in ExampleReadAtLeast 2019-12-27 06:01:32 +00:00
log
math math, math/big: add support for riscv64 2020-01-15 18:49:52 +00:00
mime
net Revert "net/http: support gzip, x-gzip Transfer-Encodings" 2020-01-22 22:06:30 +00:00
os Revert "os: handle long path in RemoveAll for windows" 2020-01-13 23:35:18 +00:00
path path: minor changes to improve documentation for Join 2019-11-20 20:51:13 +00:00
plugin
reflect reflect: correct riscv64 assembly 2020-01-19 15:28:32 +00:00
regexp
runtime runtime: add missing code for linux/riscv64 2020-01-23 14:36:57 +00:00
sort
strconv strconv: reformat and tidy comments in example 2019-11-11 19:56:33 +00:00
strings strings: update Join parameter name for clarity 2020-01-15 04:21:28 +00:00
sync sync: deflake TestWaitGroupMisuse3 2019-12-06 05:12:15 +00:00
syscall syscall: resync various riscv64 structs with x/sys/unix 2020-01-06 11:46:56 +00:00
testdata
testing testing: clarify that Cleanup is run after subtests complete. 2020-01-18 08:45:35 +00:00
text text/template: indirect interfaces before slicing 2019-12-19 13:52:09 +00:00
time time: add a sentence about distant times to time.Time.Unix 2020-01-13 21:56:50 +00:00
unicode all: fix typo in RuneSelf, runeSelf comments 2020-01-06 02:46:02 +00:00
unsafe
vendor src/go.mod: update x/crypto to drop broken poly1305 arm assembly 2020-01-10 18:53:03 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod src/go.mod: update x/crypto to drop broken poly1305 arm assembly 2020-01-10 18:53:03 +00:00
go.sum src/go.mod: update x/crypto to drop broken poly1305 arm assembly 2020-01-10 18:53:03 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.