go/src
Cherry Mui 82c14346d8 cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used
We have an optimization that if the memory profile is not consumed
anywhere, we set the memory profiling rate to 0 to disable the
"background" low-rate profiling. We detect whether the memory
profile is used by checking whether the runtime.MemProfile function
is reachable at link time. Previously, all APIs that access the
memory profile go through runtime.MemProfile. But the code was
refactored in CL 572396, and now the legacy entry point
WriteHeapProfile uses pprof_memProfileInternal without going
through runtime.MemProfile. In fact, even with the recommended
runtime/pprof.Profile API (pprof.Lookup or pprof.Profiles),
runtime.MemProfile is only (happen to be) reachable through
countHeap.

Change the linker to check runtime.memProfileInternal instead,
which is on all code paths that retrieve the memory profile. Add
a test case for WriteHeapProfile, so we cover all entry points.

Fixes #68136.

Change-Id: I075c8d45c95c81825a1822f032e23107aea4303c
Reviewed-on: https://go-review.googlesource.com/c/go/+/596538
Reviewed-by: Than McIntosh <thanm@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-07-03 22:43:11 +00:00
..
archive archive/zip: fix UncompressedSize godoc 2024-05-28 21:41:09 +00:00
arena
bufio
builtin
bytes all: document legacy //go:linkname for final round of modules 2024-05-29 17:58:53 +00:00
cmd cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used 2024-07-03 22:43:11 +00:00
cmp cmd/compile: remove redundant calls to cmpstring 2024-04-19 16:31:02 +00:00
compress compress: reordering fields to reduce struct sizes 2024-04-26 13:32:40 +00:00
container
context
crypto crypto/tls: apply QUIC session event flag to QUICResumeSession events 2024-06-25 17:08:08 +00:00
database/sql all: document legacy //go:linkname for final round of modules 2024-05-29 17:58:53 +00:00
debug all: document legacy //go:linkname for final round of modules 2024-05-29 17:58:53 +00:00
embed embed: simplify the code 2024-05-20 19:42:51 +00:00
encoding encoding/json: clarify the map's key type for Unmarshal 2024-06-21 18:42:18 +00:00
errors errors: change interface{} to any in comment 2024-05-24 17:13:04 +00:00
expvar all: make use of sync.Map.Clear 2024-04-26 21:32:11 +00:00
flag flag: replace sort.Slice with slices.SortFunc 2024-05-07 18:38:24 +00:00
fmt all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
go types2, go/types: correct NewTypeParam documentation 2024-06-21 18:41:24 +00:00
hash all: make function comments match function names 2024-06-03 14:56:25 +00:00
html html: update jstmpllitinterp doc 2024-05-22 18:04:29 +00:00
image all: make function comments match function names 2024-06-03 14:56:25 +00:00
index/suffixarray all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
internal time: provide non-default metric for asynctimerchan 2024-06-21 12:36:22 +00:00
io all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
iter iter: minor doc comment updates 2024-06-21 19:12:59 +00:00
log log/slog: handle times with undefined UnixNanos 2024-05-16 16:12:08 +00:00
maps maps: slightly improve iter tests 2024-05-23 03:44:19 +00:00
math math/big: better doc string for Float.Copy, add example test 2024-06-06 15:46:54 +00:00
mime all: document legacy //go:linkname for final round of modules 2024-05-29 17:58:53 +00:00
net net/http: avoid appending an existing trailing slash to path again 2024-06-28 17:01:13 +00:00
os os: add TODO about removing test exception 2024-07-02 12:36:03 +00:00
path all: change from sort functions to slices functions where feasible 2024-05-23 01:00:11 +00:00
plugin
reflect all: document legacy //go:linkname for final round of modules 2024-05-29 17:58:53 +00:00
regexp
runtime cmd/link: don't disable memory profiling when pprof.WriteHeapProfile is used 2024-07-03 22:43:11 +00:00
slices slices: update docs for All, Backward, Values 2024-06-27 17:17:57 +00:00
sort
strconv strconv: use stringslite.Clone 2024-05-05 00:24:26 +00:00
strings strings: move Clone to stringslite 2024-05-04 01:23:42 +00:00
structs cmd/compile: add structs.HostLayout 2024-05-20 21:19:39 +00:00
sync sync: refer to Locker interface methods in RWMutex.RLocker doc 2024-07-01 13:44:22 +00:00
syscall syscall: selectively update zerrors_* on openbsd/386, openbsd/arm and openbsd/amd64 2024-06-16 23:08:08 +00:00
testdata
testing cmd/go: fix problems with coverage percentage reporting w/ -coverpkg 2024-06-14 11:46:05 +00:00
text text/template/parse: fix handling of assignment/declaration in PipeNode.String 2024-06-21 18:12:29 +00:00
time time: fix time zone parsing when format includes time zone seconds 2024-07-02 20:01:50 +00:00
unicode
unique internal/concurrent: make HashTrieMap iteration more idiomatic 2024-05-22 16:01:55 +00:00
unsafe unsafe: document the behavior of Sizeof on an interface 2024-05-21 19:45:20 +00:00
vendor all: update vendored dependencies 2024-06-04 16:19:04 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash src/buildall.bash: use grep -E instead of egrep 2024-04-23 17:45:23 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2024-06-04 16:19:04 +00:00
go.sum all: update vendored dependencies 2024-06-04 16:19:04 +00:00
make.bash make.bash: preserve GOROOT_BOOTSTRAP 2024-05-29 13:48:46 +00:00
make.bat
make.rc make.bash: preserve GOROOT_BOOTSTRAP 2024-05-29 13:48:46 +00:00
race.bash
race.bat
run.bash run.bash: rm bumping open files soft limit 2024-05-15 15:02:23 +00:00
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.