go/src
Michael Anthony Knyszek 816199e421 runtime: don't let readTrace spin on trace.shutdown
Issue #74045 describes a scenario in which gopark is inlined into
readTrace, such that there are no preemption points. This is only a
problem because readTrace spins if trace.shutdown is set, through
traceReaderAvailable. However, trace.shutdown is almost certainly
overkill for traceReaderAvailable. The first condition, checking whether
the reader gen and the flushed gen match, should be sufficient to ensure
the reader wakes up and finishes flushing all buffers. The first
condition is also safe because it guarantees progress. In the case of
shutdown, all the trace work that will be flushed has been flushed, and
so the trace reader will exit into a regular goroutine context when
it's finished. If not shutting down, then the trace reader will release
doneSema, increase readerGen, and then the gopark unlockf will let it
block until new work actually comes in.

Fixes #74045.

Change-Id: Id9b15c277cb731618488771bd484577341b68675
Reviewed-on: https://go-review.googlesource.com/c/go/+/680738
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
2025-06-16 15:16:29 -07:00
..
archive
arena
bufio bufio: update buffer documentation 2025-05-21 11:05:26 -07:00
builtin
bytes strings,bytes: add internal docs about perennial noCopy questions 2025-05-19 10:38:56 -07:00
cmd internal/trace: make Value follow reflect conventions 2025-06-16 10:05:39 -07:00
cmp
compress std: pass bytes.Buffer and strings.Builder by pointer 2025-05-19 09:13:04 -07:00
container
context
crypto crypto/tls: enable signature algorithm BoGo tests (and fix two bugs) 2025-05-27 08:37:16 -07:00
database/sql
debug
embed
encoding encoding/json/jsontext, encoding/json/v2: document experimental nature 2025-06-11 14:17:53 -07:00
errors errors: add joinError Unwrap example 2025-05-27 08:37:09 -07:00
expvar
flag
fmt cmd/compile/internal/walk: convert composite literals to interfaces without allocating 2025-05-21 12:23:26 -07:00
go test: add another regression test for issue 73309 2025-06-04 07:40:51 -07:00
hash hash: mention the new Cloner interface in Hash docs. 2025-05-24 06:27:15 -07:00
html
image
index/suffixarray
internal internal/trace: make Value follow reflect conventions 2025-06-16 10:05:39 -07:00
io io/fs: add examples for Glob,ReadFile and ValidPath 2025-05-27 08:37:04 -07:00
iter
log log/slog: fix level doc on handlers 2025-06-09 09:04:58 -07:00
maps
math math: fix portable FMA implementation when x*y ~ 0, x*y < 0 and z = 0 2025-05-19 14:45:48 -07:00
mime
net net: remove some BUG entries 2025-06-12 09:28:42 -07:00
os all: replace a few user-visible mentions of golang.org and godoc.org 2025-06-12 23:27:10 -07:00
path
plugin
reflect reflect: leak packEface input to result rather than heap 2025-05-21 13:21:10 -07:00
regexp
runtime runtime: don't let readTrace spin on trace.shutdown 2025-06-16 15:16:29 -07:00
slices slices,sort: explicitly discard results in benchmarks 2025-06-02 09:09:25 -07:00
sort slices,sort: explicitly discard results in benchmarks 2025-06-02 09:09:25 -07:00
strconv
strings strings,bytes: add internal docs about perennial noCopy questions 2025-05-19 10:38:56 -07:00
structs
sync testing/synctest, runtime: avoid panic when using linker-alloc WG from bubble 2025-06-10 15:02:26 -07:00
syscall os: don't follow symlinks on Windows when O_CREATE|O_EXCL and read-only 2025-05-27 19:35:07 -07:00
testdata
testing testing/synctest, runtime: avoid panic when using linker-alloc WG from bubble 2025-06-10 15:02:26 -07:00
text text/template: limit expression parenthesis nesting 2025-05-17 03:27:48 -07:00
time
unicode
unique cmd/compile/internal/ssa: eliminate string copies for calls to unique.Make 2025-05-21 20:20:31 -07:00
unsafe
vendor all: update vendored dependencies [generated] 2025-06-06 10:04:27 -07:00
weak
Make.dist
README.vendor
all.bash all.{bash,rc}: use "../bin/go tool dist" instead of "%GOTOOLDIR%/dist" print build info 2025-06-10 06:00:41 -07:00
all.bat
all.rc all.{bash,rc}: use "../bin/go tool dist" instead of "%GOTOOLDIR%/dist" print build info 2025-06-10 06:00:41 -07:00
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies [generated] 2025-06-06 10:04:27 -07:00
go.sum all: update vendored dependencies [generated] 2025-06-06 10:04:27 -07:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Also, ensure that 'go env GOROOT' shows the root of this Go source
tree. Otherwise, the results are undefined. It's recommended to build
Go from source and use that 'go' binary to update its source tree.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.