go/src
Alan Donovan 8121604559 go/types: don't fail fast on Go version errors
Many tools (especially in the IDE) rely on type information
being computed even for packages that have some type errors.
Previously, there were two early (error) exits in checkFiles
that violated this invariant, one related to FakeImportC
and one related to a too-new Config.GoVersion.
(The FakeImportC one is rarely encountered in practice,
but the GoVersion one, which was recently downgraded from
a panic by CL 507975, was a source of crashes
due to incomplete type information.)

This change moves both of those errors out of checkFiles
so that they report localized errors and don't obstruct
type checking. A test exercises the errors, and that
type annotations are produced.

Also, we restructure and document checkFiles to make clear
that it is never supposed to stop early.

Updates #66525

Change-Id: I9c6210e30bbf619f32a21157f17864b09cfb5cf2
Reviewed-on: https://go-review.googlesource.com/c/go/+/574495
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-04-03 22:50:48 +00:00
..
archive all: make use of builtin clear 2024-03-27 18:23:49 +00:00
arena
bufio
builtin
bytes bytes: add a colon after Output to make the Example in the document display correctly 2024-03-04 15:54:40 +00:00
cmd go/types: don't fail fast on Go version errors 2024-04-03 22:50:48 +00:00
cmp
compress compress/bzip2,lzw: use built-in clear to simplify code 2024-03-18 16:57:58 +00:00
container
context all: fix a large number of comments 2024-03-26 19:58:28 +00:00
crypto crypto/tls,regexp: remove always-nil error results 2024-03-29 22:22:45 +00:00
database/sql database/sql: refactor unused variables to use blank identifiers 2024-04-02 01:32:55 +00:00
debug debug/elf: avoid using binary.Read() in NewFile() 2024-03-15 05:04:31 +00:00
embed
encoding encoding/json: prevent duplicate slicebytetostring 2024-04-02 15:00:17 +00:00
errors errors: return early for Is(nil, ...) 2024-04-03 22:49:49 +00:00
expvar expvar: use slices to simplify the code 2024-04-03 21:36:09 +00:00
flag
fmt fmt: add available godoc link 2024-04-02 21:56:20 +00:00
go go/types: don't fail fast on Go version errors 2024-04-03 22:50:48 +00:00
hash all: make use of builtin clear 2024-03-27 18:23:49 +00:00
html all: fix a large number of comments 2024-03-26 19:58:28 +00:00
image image: use built-in clear to simplify code 2024-03-11 17:08:05 +00:00
index/suffixarray index/suffixarray: use built-in clear to simplify code 2024-03-18 23:57:18 +00:00
internal go/types: don't fail fast on Go version errors 2024-04-03 22:50:48 +00:00
io io: close PipeReader in test 2024-03-11 19:49:15 +00:00
iter
log log/slog: use plain string concatenation for Attr.String 2024-03-25 18:23:25 +00:00
maps all: run go fmt 2024-02-28 20:35:05 +00:00
math math/big: use built-in clear to simplify code 2024-03-14 17:02:38 +00:00
mime mime: add available godoc link 2024-03-21 16:12:35 +00:00
net net/http: speed up go test 2024-04-03 22:49:46 +00:00
os os: convert poll.ErrFileClosed to ErrClosed for Stat 2024-04-03 22:38:03 +00:00
path path/filepath: use slices to simplify the test code 2024-03-22 16:38:19 +00:00
plugin
reflect reflect: add missing String case in Value.UnsafePointer doc 2024-04-03 22:44:07 +00:00
regexp regexp/syntax: cleanup code generation in perl_groups.go 2024-04-02 13:59:01 +00:00
runtime all: add reflect.SliceAt function 2024-04-02 21:51:18 +00:00
slices slices: update doc for Repeat 2024-04-03 22:46:15 +00:00
sort sort: fix typo in sort_test.go 2024-03-07 19:41:04 +00:00
strconv strconv: use generics to reduce redundant helper functions 2024-03-12 16:49:33 +00:00
strings strings: optimize Repeat for common substrings 2024-03-18 19:36:37 +00:00
sync runtime: migrate internal/atomic to internal/runtime 2024-03-25 19:53:03 +00:00
syscall syscall: export Tc{get,set}pgrp for testing 2024-03-22 04:41:27 +00:00
testdata
testing all: fix a large number of comments 2024-03-26 19:58:28 +00:00
text text/template: more godoc links 2024-04-02 21:54:08 +00:00
time runtime: add fast path for (*timers).adjust 2024-03-22 16:33:57 +00:00
unicode unicode/utf8: update doc for RuneLen 2024-03-08 02:00:36 +00:00
unsafe unsafe: add available godoc link 2024-03-21 21:01:56 +00:00
vendor net/http: update bundled x/net/http2 2024-03-25 09:37:46 +00:00
Make.dist
README.vendor cmd: update vendored x/tools to 904c6ba 2024-04-02 02:20:05 +00:00
all.bash all.bash: allow spaces in $GOTOOLDIR to print build info 2024-03-11 19:53:58 +00:00
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod net/http: update bundled x/net/http2 2024-03-25 09:37:46 +00:00
go.sum net/http: update bundled x/net/http2 2024-03-25 09:37:46 +00:00
make.bash cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
make.bat cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
make.rc cmd: remove support for GOROOT_FINAL 2024-02-21 22:16:54 +00:00
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto', and if you use a go.work file, set GOWORK=off.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src  # or src/cmd
    go get golang.org/x/net@master
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.