go/src
Manlio Perillo 805b4d5636 cmd/dist: wait for exit in bgwait after a fatal error
Currently, when a command scheduled by bgrun fails, bgwait returns to
the caller even in case the fatal error was detected.

In case of a syntax error in one of the standard packages, as an
example, the runInstall function will try to read the generated archive
file, only to fail since the file does not exist.  Since the runInstall
function is called in a goroutine, cmd/dist will continue to report
errors until all background goroutines are done.

Update the bgwait function to wait until program termination in case of
a fatal error, since returning to the caller (with an error, as an
example) will cause cmd/dist to report an additional error during the
next build phase.

Fixes #45410

Change-Id: If89976abad70f8d6ec79b2a5a1f2306e9c034c5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/320311
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
2021-11-09 21:58:03 +00:00
..
archive archive/zip: don't read data descriptor early 2021-11-07 04:56:11 +00:00
bufio bufio: document that NewWriter can return its argument 2021-11-09 20:06:10 +00:00
builtin
bytes strings, bytes: deprecate Title 2021-11-05 21:27:34 +00:00
cmd cmd/dist: wait for exit in bgwait after a fatal error 2021-11-09 21:58:03 +00:00
compress
constraints constraints: remove Slice/Map/Chan 2021-10-27 22:17:35 +00:00
container
context
crypto crypto/x509: remove ios build tag restriction 2021-11-08 17:46:34 +00:00
database/sql database/sql: fix tx.Prepare documentation 2021-11-03 23:48:28 +00:00
debug all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
embed cmd/go: add //go:embed all:pattern 2021-11-09 18:03:59 +00:00
encoding encoding/xml: add generic encoding test 2021-11-09 21:26:25 +00:00
errors errors: add errors.Unwrap example 2021-11-05 21:28:50 +00:00
expvar
flag
fmt
go go/types: clearer object string for type parameters 2021-11-09 21:07:06 +00:00
hash all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
html all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
image image/draw: rename and reorder some benchmarks 2021-10-31 08:29:02 +00:00
index/suffixarray all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
internal internal/fmtsort: order channels in test in memory address order 2021-11-08 17:30:10 +00:00
io io: remove UTF8 specified document for RuneReader 2021-10-29 02:16:47 +00:00
log all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
math all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
mime all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
net all: update vendored golang.org/x/{net,text} for Go 1.18 release 2021-11-09 20:10:36 +00:00
os os: clarify that File.{Read,Write} use the buffer 2021-11-09 20:08:48 +00:00
path all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
plugin all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
reflect all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
regexp all: go fix -fix=buildtag std cmd (except for bootstrap deps, vendor) 2021-10-28 18:17:57 +00:00
runtime runtime: add upper half and carry bit with zero 2021-11-09 17:18:08 +00:00
sort
strconv
strings strings, bytes: deprecate Title 2021-11-05 21:27:34 +00:00
sync all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
syscall all: remove more leftover // +build lines 2021-11-06 10:24:44 +00:00
testdata
testing testing: remove package from fuzz crasher message 2021-11-09 15:16:57 +00:00
text text/template: use reflect.Value.FieldByIndexErr 2021-10-29 02:12:05 +00:00
time time: fix looking for zone offset when date is close to a zone transition 2021-11-05 21:28:34 +00:00
unicode unicode/utf8: add AppendRune Example 2021-11-05 21:29:18 +00:00
unsafe
vendor all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
go.sum all: update vendored golang.org/x/crypto for Go 1.18 release 2021-11-09 20:10:44 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.