mirror
/
go
mirror of https://github.com/golang/go.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go/src
History
Nikhil Benesch 804d03281c cmd/go: rebuild as needed when vetting test packages 
If A's external test package imports B, which imports A, and A's
internal test code adds something to A that invalidates anything in A's
export data, then we need to build B against the test-augmented version
of A before using it to build A's external test package.

https://golang.org/cl/92215 taught 'go test' to do this rebuilding
properly, but 'go vet' was not taught the same trick when it learned to
vet test packages in https://golang.org/cl/87636. This commit moves the
necessary logic into the load.TestPackagesFor function so it can be
shared by 'go test' and 'go vet'.

Fixes #23701.

Change-Id: I1086d447eca02933af53de693384eac99a08d9bd
Reviewed-on: https://go-review.googlesource.com/104315
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
 		2018-04-04 14:39:23 +00:00
..
archive all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
bufio bufio: document ReadFrom/WriteTo calls to underlying methods 2018-03-28 22:21:52 +00:00
builtin
…
bytes internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
cmd cmd/go: rebuild as needed when vetting test packages 2018-04-04 14:39:23 +00:00
compress compress/gzip: do not count header bytes written in Write 2018-04-02 20:18:14 +00:00
container
…
context
…
crypto crypto/tls: simplify the Handshake locking strategy 2018-04-03 16:44:55 +00:00
database/sql database/sql: check to see if ctx is cancelable before await 2018-03-27 18:40:46 +00:00
debug debug/pe: use bytes.IndexByte instead of a loop 2018-03-07 16:12:08 +00:00
encoding all: remove some unused return parameters 2018-03-24 19:44:47 +00:00
errors
…
expvar all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
flag flag: correct zero values when printing defaults 2018-04-01 20:17:22 +00:00
fmt fmt: document the behaviour of %p on slices 2018-03-30 00:19:36 +00:00
go go/types: fix column reporting of invalid selector names 2018-04-02 21:33:10 +00:00
hash
…
html html/template: fix one more lint naming error 2018-03-30 23:57:47 +00:00
image all: fix non-standard "DO NOT EDIT" comments for generated files 2018-03-10 17:50:11 +00:00
index/suffixarray
…
internal os/user: obtain a user GID on Windows 2018-04-04 09:28:39 +00:00
io io: document that ReadAtLeast and ReadFull can drop errors 2018-03-26 17:38:36 +00:00
log
…
math math/big: remove "else" from if with block that ends with return 2018-04-03 19:55:04 +00:00
mime all: use strings.Builder instead of bytes.Buffer where appropriate 2018-03-26 23:05:53 +00:00
net Revert "net: mark tests with retry as parallel" 2018-04-01 18:23:34 +00:00
os os/user: obtain a user GID on Windows 2018-04-04 09:28:39 +00:00
path path/filepath: change example to print the correct path on failure 2018-03-26 17:40:01 +00:00
plugin
…
reflect reflect: sort exported methods first 2018-03-15 21:56:08 +00:00
regexp regexp: use sync.Pool to cache regexp.machine objects 2018-04-03 16:03:19 +00:00
runtime runtime: improve StackCopy benchmarks 2018-04-04 04:45:12 +00:00
sort sort: fix typo, was a mixup between identifiers 'unsorted' and 'data' 2018-03-19 13:09:29 +00:00
strconv strconv: make code formatting more consistent in doc.go 2018-03-19 12:53:16 +00:00
strings strings: fix flaky TestBuilderGrow test 2018-04-03 00:11:46 +00:00
sync cmd/internal/obj/arm: add DMB instruction 2018-03-27 19:54:44 +00:00
syscall syscall: remove double Unlock from Dup2 on nacl 2018-03-30 21:37:21 +00:00
testing testing: fix testing flags link 2018-03-30 23:34:47 +00:00
text text/scanner: add examples 2018-03-10 02:01:58 +00:00
time all: remove some unused return parameters 2018-03-24 19:44:47 +00:00
unicode
…
unsafe
…
vendor/golang_org/x vendor: update golang.org/x/net/dns/dnsmessage from upstream 2018-03-18 05:48:38 +00:00
Make.dist
…
all.bash
…
all.bat
…
all.rc
…
androidtest.bash androidtest.bash: don't require GOARCH set 2018-03-07 14:01:43 +00:00
bootstrap.bash
…
buildall.bash
…
clean.bash
…
clean.bat
…
clean.rc
…
cmp.bash
…
iostest.bash iostest.bash: don't build std library twice 2018-03-06 16:08:20 +00:00
make.bash
…
make.bat
…
make.rc
…
naclmake.bash
…
nacltest.bash
…
race.bash
…
race.bat
…
run.bash src/run.bash: remove some trailing whitespace 2018-04-01 16:12:47 +00:00
run.bat
…
run.rc
…