Heschi Kreinick 1e7abacf3b internal/lsp: refactor go command error handling ... Our handling of go command errors was cobbled together, leading to unexpected gaps and duplication. Refactor it to be more coherent. Our goal is to turn every go command error into a diagnostic in the relevant location. The errors don't contain error positions, so we have to guess where they belong using the module names mentioned in the error. If we can't find any reference to those modules, we are forced to add diagnostics to all go.mod files. I may have destroyed the intent of TestMultiModule_OneBrokenModule but I'm not sure what to do about it. Some cleanup along the way: - Stop parsing modfile.Parse error text: it returns structured errors and we can just use them. - Return CriticalErrors from awaitLoadedAllErrors, and do error extraction lower in the stack. This prevents a ridiculous situation where initialize formed a CriticalError, then awaitLoadedAllErrors returned just its MainError, and then GetCriticalError parsed out a new CriticalError from the MainError we got from a CriticalError. - In initialize, return modDiagnostics even if load succeeds: we are missing packages and should not silently fail, I think? - During testing I tripped over ApplyQuickFixes' willingness to not actually do anything, so I made that an error. Fixes golang/go#44132. I may also have fixed golang/go#44204 but I haven't checked. Change-Id: Ibf819d0f044d4f99795978a28b18915893e50c88 Reviewed-on: https://go-review.googlesource.com/c/tools/+/291192 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>		2021-02-16 21:26:54 +00:00
..
analysisinternal	internal/lsp/fuzzy: fix return value on no match	2020-08-28 15:37:48 +00:00
apidiff	all: add copyright notices to files that are missing them	2021-01-06 17:23:47 +00:00
event	all: add copyright notices to files that are missing them	2021-01-06 17:23:47 +00:00
fakenet	internal/fakenet: add a fake network connection	2020-05-27 14:27:59 +00:00
fastwalk	internal/fastwalk: attempt Symlink tests on Windows	2020-05-21 21:19:27 +00:00
gocommand	internal/lsp: re-enable upgrades for individual dependencies	2021-02-01 17:10:16 +00:00
gopathwalk	internal/imports: fix crash when adding stdlib imports	2020-08-13 17:47:04 +00:00
imports	all: replace all usages of os/exec with golang.org/x/sys/execabs	2021-01-19 22:25:03 +00:00
jsonrpc2	internal/jsonrpc2: remove unused invalidID constant	2021-02-04 15:49:51 +00:00
lsp	internal/lsp: refactor go command error handling	2021-02-16 21:26:54 +00:00
memoize	internal/memoize: add a final argument to Bind for cleaning up	2020-10-30 19:59:21 +00:00
packagesinternal	internal/lsp/cache: disable network for mod tidy diagnostics	2021-02-05 19:41:14 +00:00
proxydir	all: remove version-specific test files	2020-05-28 17:13:50 +00:00
span	internal/typesinternal: use Go 1.16 metadata for go/types errors	2020-12-07 17:42:14 +00:00
stack	internal/stack: add the leak test	2020-05-27 14:25:42 +00:00
testenv	all: replace all usages of os/exec with golang.org/x/sys/execabs	2021-01-19 22:25:03 +00:00
tool	…
typesinternal	internal/typesinternal: sync error codes with go1.16	2021-02-16 20:01:04 +00:00
xcontext	…