go/src
Bryan C. Mills 58e42b946b cmd/go/internal/modload: break more cycles in readModGraph
Before CL 471595, modload.readModGraph in module with graph pruning
enabled only ever chased down transitive dependencies of unpruned
roots, so pruned dependencies couldn't cause cycles and we didn't
need to dedup them in the loading queue.

However, in 'go get' we are now passing in a set of upgraded modules
to unprune, and those upgraded modules can potentially contain cycles,
leading to an infinite loop during loading.

We have two options for a fix: we could either drop the 'unprune'
check in the enqueue operation (and instead expand the 'unprune'
requirements in a separate pass, as we do in workspace mode), or we
could check for cycles for all modules (not just the ones that are
naturally unpruned). The latter option makes it clearer that this
process must terminate, so we choose that.

(It may be possible to clean up and simplify the workspace-mode case
now that we are passing in the 'unprune' map, but for now we're
looking for a minimal fix for the Go 1.21 release.)

Fixes #60490.

Change-Id: I701f5d43a35e357f6c0c0c9d10b7aa088f917311
Reviewed-on: https://go-review.googlesource.com/c/go/+/499195
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
2023-05-30 16:18:15 +00:00
..
archive compress/flate, archive/zip: reduce memory allocations 2023-05-24 23:23:54 +00:00
arena
bufio
builtin
bytes internal/bytealg: fix alignment code in compare_riscv64.s 2023-05-30 16:05:30 +00:00
cmd cmd/go/internal/modload: break more cycles in readModGraph 2023-05-30 16:18:15 +00:00
cmp cmp: new package 2023-05-19 17:41:52 +00:00
compress compress/flate, archive/zip: reduce memory allocations 2023-05-24 23:23:54 +00:00
container
context
crypto crypto/tls: avoid referencing potentially unused symbols in init 2023-05-26 15:24:38 +00:00
database/sql database/sql: fix regression from earlier RawBytes fix 2023-05-26 03:06:19 +00:00
debug all: fix unavailable url 2023-05-24 15:02:49 +00:00
embed
encoding encoding/json: document unsupported float values 2023-05-25 00:04:56 +00:00
errors errors: add godoc links 2023-05-25 13:20:16 +00:00
expvar
flag
fmt fmt: correct documentation for Formatter 2023-05-24 18:58:06 +00:00
go go/types: don't use user string as format string 2023-05-30 15:53:36 +00:00
hash hash/maphash: weaken avalanche test a bit 2023-05-17 14:45:20 +00:00
html html/template: expose ErrJSTemplate 2023-05-19 16:51:35 +00:00
image
index/suffixarray
internal internal/bytealg: fix alignment code in compare_riscv64.s 2023-05-30 16:05:30 +00:00
io io: clarify that Read(nil) can return 0, EOF 2023-05-26 17:03:12 +00:00
log log/slog: add link to handler-writing guide 2023-05-24 20:58:16 +00:00
maps maps: move test funcs to maps_test.go 2023-05-24 21:17:23 +00:00
math fmt,math/big,net/url: fixes to old Benchmarks 2023-05-23 20:25:13 +00:00
mime
net all: update vendored dependencies 2023-05-26 22:45:40 +00:00
os net: implement wasip1 FileListener and FileConn 2023-05-25 00:12:41 +00:00
path
plugin
reflect
regexp
runtime syscall: implement wasip1 Fcntl 2023-05-26 17:59:52 +00:00
slices slices: add sorting and comparison functions 2023-05-23 23:33:29 +00:00
sort slices: add sorting and comparison functions 2023-05-23 23:33:29 +00:00
strconv
strings
sync syscall: avoid serializing forks on ForkLock 2023-05-23 17:25:09 +00:00
syscall syscall: fix ComputerName on Windows 2023-05-30 13:48:54 +00:00
testdata
testing Revert "testing: only report subtest races once" 2023-05-24 17:35:45 +00:00
text
time
unicode
unsafe
vendor all: update vendored dependencies 2023-05-26 22:45:40 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash all: fix buildall.bash 2023-05-25 14:37:57 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies 2023-05-26 22:45:40 +00:00
go.sum all: update vendored dependencies 2023-05-26 22:45:40 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

There are two modules, std and cmd, defined in src/go.mod and
src/cmd/go.mod. When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure that GO111MODULE is not set in the environment, or that it is
set to 'on' or 'auto'.

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.