Rob Findley 6da3d7ace9 internal/lsp/source: re-parse if needed when collecting identifier info ... With the new ParseExported logic, we can lose some unexported fields on exported structs. This can lead to misleading or malformatted hover information. Fix this by ensuring we always extract the Spec from a full parse. Since this path is only hit via user-initiated requests (and should only be hit ~once per request), it is preferable to do the parse on-demand rather than parse via the cache and risk pinning the full AST for the remaining duration of the session. For golang/go#46158 Change-Id: Ib3eb61c3f75e16199eb492e3e129ba875bd8553e Reviewed-on: https://go-review.googlesource.com/c/tools/+/320550 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2021-05-18 02:12:20 +00:00
..
codelens_test.go	internal/lsp/source: re-parse if needed when collecting identifier info	2021-05-18 02:12:20 +00:00