go/src/internal/bytealg
Josh Bleecher Snyder ca0c449a6b bytes, internal/bytealg: simplify Equal
The compiler has advanced enough that it is cheaper
to convert to strings than to go through the assembly
trampolines to call runtime.memequal.

Simplify Equal accordingly, and cull dead code from bytealg.

While we're here, simplify Equal's documentation.

Fixes #31587

Change-Id: Ie721d33f9a6cbd86b1d873398b20e7882c2c63e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/173323
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dave Cheney <dave@cheney.net>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
2019-04-24 00:56:36 +00:00
..
bytealg.go all: align cpu feature variable offset naming 2018-08-24 18:40:16 +00:00
compare_386.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_amd64.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_amd64p32.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_arm.s internal/bytealg: use word-wise comparison for Compare on arm 2019-03-06 16:09:38 +00:00
compare_arm64.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_generic.go strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_mipsx.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_native.go internal/bytealg, runtime: provide linknames for pushed symbols 2018-11-12 20:27:16 +00:00
compare_ppc64x.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_s390x.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
compare_wasm.s all: rename WebAssembly instructions according to spec changes 2019-03-03 21:10:01 +00:00
count_amd64.s all: align cpu feature variable offset naming 2018-08-24 18:40:16 +00:00
count_arm.s internal/bytealg: add assembly implementation of Count/CountString on arm 2019-03-19 16:33:10 +00:00
count_arm64.s internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
count_generic.go internal/bytealg: add assembly implementation of Count/CountString on arm 2019-03-19 16:33:10 +00:00
count_native.go internal/bytealg: add assembly implementation of Count/CountString on arm 2019-03-19 16:33:10 +00:00
count_ppc64x.s internal/bytealg: implement bytes.Count in asm for ppc64x 2018-09-12 15:47:43 +00:00
equal_386.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_amd64.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_amd64p32.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_arm.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_arm64.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_generic.go bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_mips64x.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_mipsx.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_native.go bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_ppc64x.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_s390x.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
equal_wasm.s bytes, internal/bytealg: simplify Equal 2019-04-24 00:56:36 +00:00
index_amd64.go internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
index_amd64.s all: align cpu feature variable offset naming 2018-08-24 18:40:16 +00:00
index_arm64.go internal/bytealg: fix function reference in comments 2019-04-02 05:45:33 +00:00
index_arm64.s all: fix typos detected by github.com/client9/misspell 2018-08-23 15:54:07 +00:00
index_generic.go internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
index_native.go internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
index_s390x.go internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
index_s390x.s internal/bytealg: move short string Index implementations into bytealg 2018-03-04 19:49:44 +00:00
indexbyte_386.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_amd64.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_amd64p32.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_arm.s internal/bytealg: share code for IndexByte functions on arm 2019-03-18 07:37:13 +00:00
indexbyte_arm64.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_generic.go strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_mips64x.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_mipsx.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_native.go internal/bytealg: add wasm architecture 2018-05-08 13:28:18 +00:00
indexbyte_ppc64x.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_s390x.s strings,bytes: use inlineable function trampolines instead of linkname 2018-11-08 20:52:47 +00:00
indexbyte_wasm.s internal/bytealg: simplify memchr for wasm 2019-03-29 03:59:19 +00:00