768a39975d
At one point this map checked for infinite loops during package iteration. The last write to the map was mistakenly removed in CL 251445. However, looking at the code before that change, the map-based termination strategy was never quite right to begin with: it checked whether we had ever added any module for the given package, not whether we had already added the module being proposed right now. (For packages within nested modules, we could try adding multiple different modules for a given package without looping.) Moreover, the "looping trying to add package" failure message was only marginally helpful. Users are capable of noticing that an invocation of the 'go' command is taking too long, and will report a bug for an infinite loop just as readily as a "looping trying to add package" error. We could try to add this tracking back in, but it's no substitute for a proper proof of convergence, and the code is simpler without it. Instead I'm going to add a proper proof of convergence — or, barring that, a more accurate and useful check for failure to converge. In the meantime, this invariantly-empty map isn't doing anybody any good. For #36460 Change-Id: I2c111d4b4bf59159af0d7e62d1c0ef4ce0a43a71 Reviewed-on: https://go-review.googlesource.com/c/go/+/312929 Trust: Bryan C. Mills <bcmills@google.com> Run-TryBot: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Michael Matloob <matloob@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| SECURITY.md | ||
| codereview.cfg | ||
README.md
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://golang.org/doc/contribute.html.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.