go/internal/lsp/regtest
Robert Findley e55fb40e67 internal/lsp/cache: clear shouldLoad IDs on load
CL 417576 externalized shouldLoad tracking into a map, which was used to
trigger a reload and cleared once reload completes. Unfortunately, it
overlooked the fact that we may also reload the entire workspace (via
reinitialization). In this case, we should clear newly loaded IDs from
the shouldLoad map, so that they are not subsequently loaded again.

Fixes golang/go#54473

Change-Id: I26f49552cae502644142dc4a4e946294db37f6f7
Reviewed-on: https://go-review.googlesource.com/c/tools/+/424074
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
2022-08-16 15:07:15 +00:00
..
doc.go gopls, internal/lsp: gofmt 2022-04-12 17:41:31 +00:00
env.go gopls/internal/regtest: fix TestFailingDiagnosticClearingOnEdit 2022-08-09 15:36:31 +00:00
env_test.go gopls/internal/regtest/bench: refactor and improve benchmarks 2022-08-04 14:58:59 +00:00
expectation.go internal/lsp/cache: clear shouldLoad IDs on load 2022-08-16 15:07:15 +00:00
regtest.go internal/lsp/regtest: improvements for shared execution modes 2022-08-02 18:16:22 +00:00
runner.go gopls/internal/regtest/bench: refactor and improve benchmarks 2022-08-04 14:58:59 +00:00
wrappers.go internal/lsp: update the broken workspace message to mention go.work 2022-08-08 18:10:56 +00:00