go/src
Ian Lance Taylor 70fd4e47d7 runtime: avoid possible preemption when returning from Go to C
When returning from Go to C, it was possible for the goroutine to be
preempted after calling unlockOSThread. This could happen when there
a context function installed by SetCgoTraceback set a non-zero context,
leading to a defer call in cgocallbackg1. The defer function wrapper,
introduced in 1.17 as part of the regabi support, was not nosplit,
and hence was a potential preemption point. If it did get preempted,
the G would move to a new M. It would then attempt to return to C
code on a different stack, typically leading to a SIGSEGV.

Fix this in a simple way by postponing the unlockOSThread until after
the other defer. Also check for the failure condition and fail early,
rather than waiting for a SIGSEGV.

Without the fix to cgocall.go, the test case fails about 50% of the
time on my laptop.

Fixes #47441

Change-Id: Ib8ca13215bd36cddc2a49e86698824a29c6a68ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/338197
Trust: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
2021-07-29 15:30:38 +00:00
..
archive archive/zip: only preallocate File slice if reasonably sized 2021-05-25 23:41:42 +00:00
bufio
builtin
bytes
cmd cmd/go: fix go.mod file name printed in error messages for replacements 2021-07-28 20:09:10 +00:00
compress
container
context
crypto crypto/x509: update iOS bundled roots to version 55188.120.1.0.1 2021-07-26 14:24:27 +00:00
database/sql database/sql: fix deadlock test in prepare statement 2021-06-21 17:37:23 +00:00
debug debug/elf: don't apply DWARF relocations for ET_EXEC binaries 2021-06-14 22:13:47 +00:00
embed
encoding
errors
expvar
flag
fmt fmt: split package documentation into more sections 2021-06-07 15:17:48 +00:00
go go/types: preserve untyped constants on the RHS of a shift expression 2021-07-27 00:15:55 +00:00
hash
html
image image/gif: fix typo in the comment (io.ReadByte -> io.ByteReader) 2021-06-30 17:58:50 +00:00
index/suffixarray
internal Update oudated comment 2021-07-08 16:59:21 +00:00
io io/fs: minor corrections to Sub docs 2021-06-02 18:52:58 +00:00
log
math math/big: fix typo of comment (`BytesScanner` to `ByteScanner`) 2021-06-29 16:57:13 +00:00
mime mime: document use of the Shared MIME-Info Database 2021-05-26 22:41:35 +00:00
net net/http: correct capitalization in cancelTimeBody comment 2021-07-16 02:43:48 +00:00
os os: change example to avoid deprecated function 2021-06-30 16:44:19 +00:00
path path/filepath: deflake TestEvalSymlinksAboveRoot on darwin 2021-06-30 20:03:34 +00:00
plugin
reflect reflect: add missing copyright header 2021-07-21 20:29:18 +00:00
regexp
runtime runtime: avoid possible preemption when returning from Go to C 2021-07-29 15:30:38 +00:00
sort
strconv strconv: document parsing of leading +/- 2021-06-09 18:16:27 +00:00
strings
sync
syscall syscall: fix TestGroupCleanupUserNamespace test failure on Fedora 2021-06-16 04:45:46 +00:00
testdata
testing testing: clarify T.Name returns a distinct name of the running test 2021-07-27 05:07:46 +00:00
text text/scanner: use Go convention in Position doc comment 2021-07-18 21:00:03 +00:00
time runtime: don't clear timerModifiedEarliest if adjustTimers is 0 2021-07-22 19:26:40 +00:00
unicode
unsafe spec, unsafe: clarify unsafe.Slice docs 2021-07-02 19:26:52 +00:00
vendor
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod
go.sum cmd/go: add a -compat flag to 'go mod tidy' 2021-05-25 13:18:26 +00:00
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.