go/gopls/internal/regtest/misc
Robert Findley 6e6f3131ec internal/lsp/regtest: simplify, consolidate, and document settings
Configuration of LSP settings within the regression test runner had
become a bit of a grab-bag: some were configured via explicit fields on
EditorConfig, some via the catch-all EditorConfig.Settings field, and
others via custom RunOption implementations.

Consolidate these fields as follows:
 - Add an EnvVars and Settings field, for configuring environment and
   LSP settings.
 - Eliminate the EditorConfig RunOption wrapper. RunOptions help build
   the config.
 - Remove RunOptions that just wrap a key-value settings pair. By
   definition settings are user-facing and cannot change without
   breaking compatibility. Therefore, our tests can and should set the
   exact string keys they are using.
 - Eliminate the unused SendPID option.

Also clean up some logic to change configuration.

For golang/go#39384

Change-Id: Id5d1614f139550cbc62db2bab1d1e1f545ad9393
Reviewed-on: https://go-review.googlesource.com/c/tools/+/416876
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
2022-07-12 16:56:46 +00:00
..
call_hierarchy_test.go internal/lsp/source: check for nil objects in call hierarchy 2021-10-27 16:11:50 +00:00
configuration_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
debugserver_test.go internal/lsp/debug: add a facility to track known bugs 2021-05-10 23:21:19 +00:00
definition_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
embed_test.go internal/lsp/cache: parse files with ParseFull mode to check if metadata reload is required 2021-08-06 19:38:52 +00:00
failures_test.go internal/lsp: move gopls/internal/regtest -> internal/lsp/regtest 2021-04-23 16:19:37 +00:00
fix_test.go internal/lsp/analysis/fillreturns: update fillreturns for new type errs 2021-12-03 18:55:02 +00:00
formatting_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
generate_test.go gopls/internal/regtest/misc: temporarily skip TestGenerateProgress 2021-12-01 18:47:44 +00:00
highlight_test.go internal/lsp: move gopls/internal/regtest -> internal/lsp/regtest 2021-04-23 16:19:37 +00:00
hover_test.go internal/lsp: render package documentation when hovering over a package import 2022-04-25 17:29:41 +00:00
import_test.go internal/lsp: add ListImports 2022-02-04 22:09:29 +00:00
imports_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
link_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
misc_test.go internal/lsp/cache: invalidate metadata when parsing issues resolve 2022-05-23 18:14:40 +00:00
multiple_adhoc_test.go internal/lsp: allow for multiple ad-hoc packages in the workspace 2021-08-12 18:45:58 +00:00
references_test.go internal/lsp: find references to package 2022-06-21 19:39:47 +00:00
rename_test.go internal/lsp/source: recursively search for qualified objects 2021-08-17 02:54:26 +00:00
semantictokens_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
settings_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
shared_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
staticcheck_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00
vendor_test.go internal/lsp: run go mod vendor exclusively to avoid file contention 2022-04-11 22:06:59 +00:00
vuln_test.go internal/lsp: handle invalid URL args in command params 2022-03-25 15:45:26 +00:00
workspace_symbol_test.go internal/lsp/regtest: simplify, consolidate, and document settings 2022-07-12 16:56:46 +00:00