mirror of https://github.com/golang/go.git
Configuration of LSP settings within the regression test runner had become a bit of a grab-bag: some were configured via explicit fields on EditorConfig, some via the catch-all EditorConfig.Settings field, and others via custom RunOption implementations. Consolidate these fields as follows: - Add an EnvVars and Settings field, for configuring environment and LSP settings. - Eliminate the EditorConfig RunOption wrapper. RunOptions help build the config. - Remove RunOptions that just wrap a key-value settings pair. By definition settings are user-facing and cannot change without breaking compatibility. Therefore, our tests can and should set the exact string keys they are using. - Eliminate the unused SendPID option. Also clean up some logic to change configuration. For golang/go#39384 Change-Id: Id5d1614f139550cbc62db2bab1d1e1f545ad9393 Reviewed-on: https://go-review.googlesource.com/c/tools/+/416876 TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> |
||
|---|---|---|
| .. | ||
| call_hierarchy_test.go | ||
| configuration_test.go | ||
| debugserver_test.go | ||
| definition_test.go | ||
| embed_test.go | ||
| failures_test.go | ||
| fix_test.go | ||
| formatting_test.go | ||
| generate_test.go | ||
| highlight_test.go | ||
| hover_test.go | ||
| import_test.go | ||
| imports_test.go | ||
| link_test.go | ||
| misc_test.go | ||
| multiple_adhoc_test.go | ||
| references_test.go | ||
| rename_test.go | ||
| semantictokens_test.go | ||
| settings_test.go | ||
| shared_test.go | ||
| staticcheck_test.go | ||
| vendor_test.go | ||
| vuln_test.go | ||
| workspace_symbol_test.go | ||