go/src
Josh Bleecher Snyder 6dd11bcb35 cmd/compile: remove chunking of rewrite rules
We added chunking of rewrite rules to speed up compiling package SSA.
This series of changes has significantly shrunk the number of
rewrite rules, and they are no longer being added nearly as fast.
Now that we are sharing v.Args across multiple rewrite rules,
there is additional benefit to having more rules in a single function.
Removing chunking now has an incidental impact on compiling package SSA,
marginally speeds up other compilation, shrinks the cmd/compile binary,
and simplifies the code.

name        old time/op       new time/op       delta
Template          211ms ± 2%        210ms ± 2%  -0.50%  (p=0.000 n=91+97)
Unicode          81.9ms ± 3%       81.8ms ± 3%    ~     (p=0.179 n=96+91)
GoTypes           731ms ± 2%        731ms ± 1%    ~     (p=0.442 n=94+96)
Compiler          3.43s ± 2%        3.41s ± 2%  -0.36%  (p=0.001 n=98+94)
SSA               8.30s ± 2%        8.32s ± 2%  +0.19%  (p=0.034 n=94+95)
Flate             135ms ± 2%        134ms ± 1%  -0.30%  (p=0.006 n=98+94)
GoParser          167ms ± 1%        167ms ± 1%  -0.22%  (p=0.001 n=92+94)
Reflect           453ms ± 2%        453ms ± 3%    ~     (p=0.306 n=98+97)
Tar               184ms ± 2%        183ms ± 2%  -0.31%  (p=0.012 n=94+94)
XML               249ms ± 2%        248ms ± 1%  -0.26%  (p=0.002 n=96+92)
[Geo mean]        419ms             418ms       -0.21%

name        old user-time/op  new user-time/op  delta
Template          273ms ± 2%        272ms ± 2%  -0.46%  (p=0.000 n=93+96)
Unicode           116ms ± 4%        117ms ± 4%    ~     (p=0.433 n=98+98)
GoTypes           977ms ± 2%        977ms ± 1%    ~     (p=0.971 n=92+99)
Compiler          4.56s ± 6%        4.53s ± 6%    ~     (p=0.081 n=100+100)
SSA               11.1s ± 2%        11.1s ± 2%    ~     (p=0.064 n=99+96)
Flate             167ms ± 2%        167ms ± 1%  -0.24%  (p=0.004 n=95+96)
GoParser          203ms ± 1%        203ms ± 2%  -0.14%  (p=0.049 n=96+97)
Reflect           595ms ± 2%        595ms ± 2%    ~     (p=0.544 n=95+92)
Tar               225ms ± 2%        224ms ± 2%    ~     (p=0.562 n=99+99)
XML               312ms ± 2%        311ms ± 1%    ~     (p=0.050 n=97+93)
[Geo mean]        543ms             542ms       -0.13%

Change-Id: I8d34ab59f154b28f20c6f9e416b976bfce339baa
Reviewed-on: https://go-review.googlesource.com/c/go/+/216220
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
2020-02-21 02:29:11 +00:00
..
archive all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
bufio
builtin
bytes
cmd cmd/compile: remove chunking of rewrite rules 2020-02-21 02:29:11 +00:00
compress all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
container
context
crypto crypto/elliptic: document the Name and names of each curve 2020-02-11 00:59:47 +00:00
database/sql all: fix invalid invocations of Fatalf in goroutines 2020-01-03 01:36:26 +00:00
debug all: base64-encode binaries that will cause Apple notarization to fail 2019-11-21 14:55:12 +00:00
encoding all: fix a number of misuses of the word "an" 2019-12-10 16:23:10 +00:00
errors
expvar
flag flag: clarify that a flag cannot be re-defined 2019-11-11 20:07:54 +00:00
fmt
go go/internal/gcimporter: rename file to better reflect new meaning 2020-02-20 16:23:27 +00:00
hash hash/maphash: mention the results are 64-bit integers 2020-02-13 18:32:48 +00:00
html html: update URL in comment 2020-01-13 07:00:18 +00:00
image
index/suffixarray
internal internal/bytealg: fix riscv64 offset names 2020-02-04 23:15:01 +00:00
io io: show ErrUnexpectedEOF in ExampleReadAtLeast 2019-12-27 06:01:32 +00:00
log
math math/big: reintroduce pre-Go 1.14 mention in GCD docs 2020-02-05 20:54:27 +00:00
mime
net net: don't check LookupHost error in TestLookupNullByte 2020-02-05 14:32:25 +00:00
os Revert "os: handle long path in RemoveAll for windows" 2020-01-13 23:35:18 +00:00
path path: minor changes to improve documentation for Join 2019-11-20 20:51:13 +00:00
plugin
reflect reflect: correct riscv64 assembly 2020-01-19 15:28:32 +00:00
regexp
runtime cmd/link, runtime: skip holes in func table 2020-02-18 17:55:23 +00:00
sort
strconv strconv: stop describing Unicode graphic characters as non-ASCII 2020-01-26 20:38:34 +00:00
strings strings: update Join parameter name for clarity 2020-01-15 04:21:28 +00:00
sync sync: deflake TestWaitGroupMisuse3 2019-12-06 05:12:15 +00:00
syscall syscall: Revert "release a js.Func object in fsCall" 2020-02-04 19:09:43 +00:00
testdata
testing testing: remove obsolete comment in testing.(*T) docs 2020-02-15 16:40:12 +00:00
text text/template/parse: remove redundant return 2020-01-23 23:07:10 +00:00
time time: document how Parse handles two-digit years 2020-01-23 20:44:44 +00:00
unicode all: fix typo in RuneSelf, runeSelf comments 2020-01-06 02:46:02 +00:00
unsafe
vendor all: update module dependencies 2020-02-19 21:26:10 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update module dependencies 2020-02-19 21:26:10 +00:00
go.sum all: update module dependencies 2020-02-19 21:26:10 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.