Josh Bleecher Snyder 61336b78c1 cmd/compile: don't update outer variables after capturevars is complete ... When compiling concurrently, we walk all functions before compiling any of them. Walking functions can cause variables to switch from being non-addrtaken to addrtaken, e.g. to prepare for a runtime call. Typechecking propagates addrtaken-ness of closure variables to their outer variables, so that capturevars can decide whether to pass the variable's value or a pointer to it. When all functions are compiled immediately, as long as the containing function is compiled prior to the closure, this propagation has no effect. When compilation is deferred, though, in rare cases, this results in a change in the addrtaken-ness of a variable in the outer function, which in turn changes the compiler's output. (This is rare because in a great many cases, a temporary has been introduced, insulating the outer variable from modification.) But concurrent compilation must generate identical results. To fix this, track whether capturevars has run. If it has, there is no need to update outer variables when closure variables change. Capturevars always runs before any functions are walked or compiled. The remainder of the changes in this CL are to support the test. In particular, -d=compilelater forces the compiler to walk all functions before compiling any of them, despite being non-concurrent. This is useful because -live is fundamentally incompatible with concurrent compilation, but we want -c=1 to have no behavior changes. Fixes #20250 Change-Id: I89bcb54268a41e8588af1ac8cc37fbef856a90c2 Reviewed-on: https://go-review.googlesource.com/42853 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Griesemer <gri@golang.org>		2017-05-14 00:27:25 +00:00
..
alias3.dir	[dev.typealias] cmd/compile: export/import test cases for type aliases	2017-01-20 05:55:53 +00:00
bench	test/bench/go1: fix typo in parserdata_test.go comment	2017-03-22 03:23:16 +00:00
chan	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
ddd2.dir	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
dwarf	…
fixedbugs	cmd/compile: don't update outer variables after capturevars is complete	2017-05-14 00:27:25 +00:00
import2.dir	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
import4.dir	…
interface	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
intrinsic.dir	cmd/compile: intrinsics for math/bits.TrailingZerosX	2017-03-16 02:44:16 +00:00
ken	…
linkname.dir	cmd/compile: include linknames in export data	2017-02-08 20:59:45 +00:00
method4.dir	…
safe	…
stress	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
syntax	cmd/compile/internal/parser: improved a couple of error messages	2017-02-24 18:54:36 +00:00
uintptrescapes.dir	cmd/compile, syscall: add //go:uintptrescapes comment, and use it	2016-07-06 20:48:41 +00:00
64bit.go	…
235.go	…
alg.go	test: add test that required algs get generated	2016-04-24 21:36:52 +00:00
alias.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
alias1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
alias2.go	[dev.typealias] cmd/compile: declare methods after resolving receiver type	2017-01-25 08:04:17 +00:00
alias3.go	[dev.typealias] cmd/compile: export/import test cases for type aliases	2017-01-20 05:55:53 +00:00
append.go	…
append1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
args.go	…
armimm.go	cmd/internal/obj: continue to optimize ARM's constant pool	2017-05-11 13:53:54 +00:00
assign.go	…
assign1.go	…
atomicload.go	…
bigalg.go	…
bigmap.go	…
blank.go	…
blank1.go	…
bom.go	…
bombad.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
bounds.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
chancap.go	…
chanlinear.go	…
char_lit.go	…
char_lit1.go	…
checkbce.go	cmd/compile: improve generic rules for BCE based on AND operations.	2017-03-04 16:13:07 +00:00
clearfat.go	…
closedchan.go	…
closure.go	…
closure1.go	…
closure2.go	…
cmp.go	…
cmp6.go	…
cmplx.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
cmplxdivide.c	runtime: make complex division c99 compatible	2017-03-15 22:45:17 +00:00
cmplxdivide.go	runtime: make complex division c99 compatible	2017-03-15 22:45:17 +00:00
cmplxdivide1.go	runtime: make complex division c99 compatible	2017-03-15 22:45:17 +00:00
complit.go	…
complit1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
compos.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
const.go	cmd/compile: fix compiler bug for constant equality comparison	2016-09-17 01:12:24 +00:00
const1.go	…
const2.go	…
const3.go	…
const4.go	…
const5.go	…
const6.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
convT2X.go	…
convert.go	…
convert1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
convert2.go	cmd/compile: ignore struct tags when converting structs	2016-10-04 17:10:47 +00:00
convert3.go	…
convlit.go	…
convlit1.go	…
copy.go	…
copy1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
crlf.go	…
ddd.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
ddd1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
ddd2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
decl.go	…
declbad.go	…
defer.go	…
deferfin.go	…
deferprint.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
deferprint.out	…
devirt.go	cmd/compile: de-virtualize interface calls	2017-03-14 18:49:23 +00:00
divide.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
divmod.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
empty.go	…
env.go	…
eof.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
eof1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
errchk	cmd/vet: make checking example names in _test packages more robust	2016-06-28 22:09:00 +00:00
escape.go	…
escape2.go	cmd/compile: ignore some dead code during escape analysis	2017-02-27 21:31:04 +00:00
escape2n.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape3.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape4.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape5.go	cmd/compile: unnamed parameters do not escape	2017-03-24 17:14:00 +00:00
escape_array.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_because.go	cmd/compile: add explicit 'where' to EscStep data for explanations	2016-10-26 18:46:59 +00:00
escape_calls.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_closure.go	cmd/compile/internal/syntax: establish principled position information	2017-02-15 01:33:03 +00:00
escape_field.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_iface.go	cmd/compile: avoid leak of dottype expression on double assignment form	2016-10-10 12:09:16 +00:00
escape_indir.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_level.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_map.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_param.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_slice.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_struct_param1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_struct_param2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
escape_struct_return.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
fibo.go	…
finprofiled.go	…
float_lit.go	…
float_lit2.go	test/float_lit2: fix expressions in comment	2016-09-14 16:39:47 +00:00
float_lit3.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
floatcmp.go	…
for.go	…
func.go	…
func1.go	…
func2.go	…
func3.go	…
func4.go	…
func5.go	…
func6.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
func7.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
func8.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
funcdup.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
funcdup2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
gc.go	…
gc1.go	…
gc2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
gcstring.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
goprint.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
goprint.out	…
goto.go	cmd/compile: report block start for gotos jumping into blocks	2017-04-19 02:27:58 +00:00
heapsampling.go	…
helloworld.go	…
helloworld.out	…
if.go	…
import.go	…
import1.go	…
import2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
import4.go	…
import5.go	cmd/compile: be slightly more tolerant in case of certain syntax errors	2017-03-24 20:07:15 +00:00
import6.go	cmd/compile/internal/syntax: removed gcCompat code needed to pass orig. tests	2017-02-10 01:22:30 +00:00
index.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
index0.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
index1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
index2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
indirect.go	…
indirect1.go	…
init.go	Revert "cmd/compile: improve error message if init is directly invoked"	2017-03-06 23:48:37 +00:00
init1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
initcomma.go	…
initialize.go	…
initializerr.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
initloop.go	…
inline.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
inline_caller.go	runtime: skip logical frames in runtime.Caller	2017-04-18 19:56:30 +00:00
inline_callers.go	runtime: include inlined calls in result of CallersFrames	2017-03-29 17:27:38 +00:00
inline_literal.go	cmd/compile: copy literals when inlining	2017-03-03 21:29:32 +00:00
inline_variadic.go	cmd/compile: generate code that type checks when inlining variadic functions	2016-11-30 19:46:00 +00:00
int_lit.go	…
intcvt.go	…
intrinsic.go	cmd/compile: intrinsify Ctz{32,64} and Bswap{32,64} on s390x	2016-09-19 19:03:01 +00:00
intrinsic_atomic.go	cmd/compile: intrinsify Ctz, Bswap on ARM	2016-09-12 19:26:31 +00:00
iota.go	…
label.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
label1.go	cmd/compile/internal/gc: don't panic on continue in switch	2017-04-12 14:27:45 +00:00
linkmain.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
linkmain_run.go	…
linkname.go	cmd/compile: include linknames in export data	2017-02-08 20:59:45 +00:00
linkobj.go	cmd/compile: add -linkobj flag to allow writing object file in two parts	2016-05-09 17:31:45 +00:00
linkx.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
linkx_run.go	test: print output on link -X failure	2016-04-20 17:37:35 +00:00
literal.go	…
live.go	runtime: add mapdelete_fast*	2017-03-21 06:07:24 +00:00
live1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
live2.go	cmd/compile: mark temps with new AutoTemp flag, and use it.	2016-10-31 19:38:50 +00:00
live_syscall.go	cmd/compile: mark temps with new AutoTemp flag, and use it.	2016-10-31 19:38:50 +00:00
locklinear.go	test: deflake locklinear again	2017-04-05 18:46:31 +00:00
loopbce.go	cmd/compile: check loop rescheduling with stack bound, not counter	2017-03-08 18:52:12 +00:00
makenew.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
mallocfin.go	…
map.go	…
map1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
maplinear.go	…
method.go	…
method1.go	…
method2.go	test: avoid matching file names in errcheck	2016-10-18 05:32:37 +00:00
method3.go	…
method4.go	…
method5.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
named.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
named1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
nil.go	…
nilcheck.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
nilptr.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
nilptr2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
nilptr3.go	cmd/compile: re-enable nilcheck removal in same block	2017-02-17 19:19:59 +00:00
nilptr4.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
nosplit.go	cmd/internal/objabi: extract shared functionality from obj	2017-04-19 00:00:09 +00:00
notinheap.go	cmd/compile/internal/gc: inline typedcl0 and typedcl1	2017-02-01 22:52:32 +00:00
notinheap2.go	cmd/compile: add go:notinheap type pragma	2016-10-15 17:58:14 +00:00
nowritebarrier.go	cmd/compile, runtime: add go:yeswritebarrierrec pragma	2016-10-15 17:58:11 +00:00
nul1.go	cmd/compile/internal/gc: enable new parser by default	2016-10-25 22:28:40 +00:00
opt_branchlikely.go	cmd/compile: insert scheduling checks on loop backedges	2017-01-09 21:01:29 +00:00
parentype.go	…
peano.go	…
phiopt.go	test: re-enable phi optimization test	2016-09-13 20:06:13 +00:00
print.go	…
print.out	…
printbig.go	…
printbig.out	…
prove.go	cmd/compile/internal/gc: improve comparison with constant strings	2017-04-07 15:40:25 +00:00
range.go	cmd/compile: fix assignment order in string range loop	2017-02-28 08:23:52 +00:00
recover.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
recover1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
recover2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
recover3.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
recover4.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
recover5.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
reflectmethod1.go	…
reflectmethod2.go	…
reflectmethod3.go	…
reflectmethod4.go	…
rename.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rename1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
reorder.go	cmd/compile: Ensure left-to-right assignment	2017-02-11 21:46:21 +00:00
reorder2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
return.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rotate.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rotate0.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rotate1.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rotate2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
rotate3.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
run.go	cmd/compile: check width of embedded interfaces in expandiface	2017-04-28 20:07:38 +00:00
rune.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
runtime.go	cmd/compile/internal/gc: separate builtin and real runtime packages	2017-03-01 01:06:32 +00:00
shift1.go	cmd/compile: more error position tests for the typechecker	2017-04-24 12:37:49 +00:00
shift2.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
sieve.go	…
sigchld.go	…
sigchld.out	…
simassign.go	…
sinit.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
sinit_run.go	…
sizeof.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
slice3.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
slice3err.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
slicecap.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
sliceopt.go	cmd/compile: use masks instead of branches for slicing	2016-10-27 20:22:49 +00:00
solitaire.go	…
stack.go	…
strength.go	…
string_lit.go	…
stringrange.go	…
struct0.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
switch.go	…
switch2.go	cmd/compile/internal/syntax: match old parser errors and line numbers	2016-08-19 01:10:21 +00:00
switch3.go	…
switch4.go	…
switch5.go	cmd/compile/internal/syntax: removed gcCompat code needed to pass orig. tests	2017-02-10 01:22:30 +00:00
switch6.go	cmd/compile: improve error for wrong type in switch	2017-02-02 17:36:43 +00:00
tinyfin.go	…
torture.go	…
turing.go	…
typecheck.go	…
typecheckloop.go	…
typeswitch.go	…
typeswitch1.go	…
typeswitch2.go	cmd/compile/internal/syntax: removed gcCompat code needed to pass orig. tests	2017-02-10 01:22:30 +00:00
typeswitch3.go	cmd/compile: add test for non interface type switch	2017-03-25 22:52:54 +00:00
uintptrescapes.go	cmd/compile, syscall: add //go:uintptrescapes comment, and use it	2016-07-06 20:48:41 +00:00
uintptrescapes2.go	cmd/compile: mark temps with new AutoTemp flag, and use it.	2016-10-31 19:38:50 +00:00
undef.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
utf.go	…
varerr.go	all: make copyright headers consistent with one space after period	2016-05-02 13:43:18 +00:00
varinit.go	…
writebarrier.go	cmd/compile: don't use statictmps for SSA-able composite literals	2017-05-11 18:28:40 +00:00
zerodivide.go	test: lock in test for _ assignment evaluation/zerodivide panic	2016-12-23 17:35:24 +00:00