Rob Findley 2350fe8b0e internal/lsp/source: fix panic in addFieldItems ... I have no idea what I did to trigger this, but I got a panic in this codepath. Since this is for completion, it should be OK to simply make this code defensive, without fully understanding the cause. Here's the panic: panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0xc570f3] goroutine 5914644 [running]: golang.org/x/tools/internal/lsp/source/completion.(*completer).addFieldItems(0xc0996ee240, 0x1032020, 0xc0dd21e2a0, 0xc0b99b26f0) /usr/local/google/home/rfindley/src/tools/internal/lsp/source/completion/completion.go:1065 +0x193 Change-Id: I82350b30172ead95b6611962c2e040cc49259dc2 Reviewed-on: https://go-review.googlesource.com/c/tools/+/254697 Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-09-14 15:58:11 +00:00
..
completion.go	internal/lsp/source: fix panic in addFieldItems	2020-09-14 15:58:11 +00:00
completion_builtin.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_format.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_keywords.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_labels.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_literal.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_package.go	internal/lsp: add more tests for package completion	2020-09-09 17:18:21 +00:00
completion_printf.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_printf_test.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_snippet.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
completion_statements.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
deep_completion.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
deep_completion_test.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
util.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00
util_test.go	internal/lsp/source: move completion to its own package	2020-09-08 19:19:08 +00:00