mirror of https://github.com/golang/go.git
If a context was canceled during load, only report it as a critical error if the load actually failed. Along the way, simplify evaulation of the critical error to use a switch statement. Also await IWL in the second Env used in shared regtests. Presumably it is this Env that is being shutdown prior to IWL, triggering the panicking code-path from golang/go#47030. I wasn't able to reproduce, but all panics are occurring in regtest/misc, and this seems highly plausible. Fixes golang/go#47030 Change-Id: I4df65697f644cff275ab1babb783868fd9e10c2d Reviewed-on: https://go-review.googlesource.com/c/tools/+/332589 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> |
||
|---|---|---|
| .. | ||
| analysisinternal | ||
| apidiff | ||
| event | ||
| fakenet | ||
| fastwalk | ||
| gocommand | ||
| gopathwalk | ||
| imports | ||
| jsonrpc2 | ||
| jsonrpc2_v2 | ||
| lsp | ||
| memoize | ||
| mod | ||
| packagesinternal | ||
| proxydir | ||
| span | ||
| stack | ||
| testenv | ||
| tool | ||
| typeparams | ||
| typesinternal | ||
| xcontext | ||