go/src
Michael Matloob 641918ee09 cmd/go: add positions for load errors in call to load
This CL sets positions for errors from cals to load within the load
call itself, similar to how the rest of the code in pkg.go sets
positions right after the error is set on the package.

This allows the code to ensure that we only add positions either for
ImportPathErrors, or if an error was passed into load, and was set
using setLoadPackageDataError. (Though I'm wondering if the call
to setLoadPackageDataError should be done before the call to load).

Fixes #38034

Change-Id: I0748866933b4c1a329954b4b96640bef702a4644
Reviewed-on: https://go-review.googlesource.com/c/go/+/228784
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
2020-05-06 19:03:06 +00:00
..
archive
bufio bufio: optimize bufio.Reader.ReadString to avoid an allocation and copy 2020-04-28 00:53:32 +00:00
builtin
bytes bytes: simpler and faster FieldsFunc (apply same changes as for strings) 2020-05-01 03:49:21 +00:00
cmd cmd/go: add positions for load errors in call to load 2020-05-06 19:03:06 +00:00
compress
container
context
crypto crypto/x509: improve VerifyOptions and VerifyHostname docs 2020-05-06 16:29:51 +00:00
database/sql database/sql: document Connect and Close may need a timeout 2020-04-28 20:42:02 +00:00
debug debug/gosym: correct comments for Table.{Files,Objs} 2020-04-30 03:07:49 +00:00
encoding encoding/csv: optimize Write by giving fieldNeedsQuotes a fast path for when Comma is ascii 2020-05-05 23:57:19 +00:00
errors
expvar
flag
fmt
go net/http/cgi: reject invalid header names 2020-05-06 17:06:02 +00:00
hash hash/crc32: simplify hasVX checking on s390x 2020-04-27 21:18:58 +00:00
html
image image: guard against NewXxx integer overflow 2020-04-29 11:57:50 +00:00
index/suffixarray
internal syscall, internal/syscall/windows: remove utf16PtrToString parameter 2020-05-03 07:23:32 +00:00
io
log
math math/big: add (*Int).FillBytes 2020-05-05 00:36:44 +00:00
mime
net net/http/cgi: reject invalid header names 2020-05-06 17:06:02 +00:00
os syscall, internal/syscall/windows: remove utf16PtrToString parameter 2020-05-03 07:23:32 +00:00
path
plugin
reflect reflect: keep RO flags unchanged in Value.Addr 2020-05-04 18:16:49 +00:00
regexp regexp/syntax: fix comment on p.literal and simplify 2020-04-17 22:12:02 +00:00
runtime cmd/internal/obj, runtime: preempt & restart some instruction sequences 2020-05-06 15:41:12 +00:00
sort
strconv strconv: fix for parseFloatPrefix 2020-04-30 21:34:51 +00:00
strings bytes, strings: align requirements for functions passed to FieldFuncs 2020-04-29 19:58:47 +00:00
sync
syscall syscall, internal/syscall/windows: remove utf16PtrToString parameter 2020-05-03 07:23:32 +00:00
testdata
testing testing: fix reported caller name for funcs passed to Cleanup 2020-05-05 22:44:36 +00:00
text
time lib/time, time/tzdata: update tz data to 2020a 2020-04-30 08:07:39 +00:00
unicode unicode/utf8: optimize Valid and ValidString for ASCII checks 2020-04-22 14:14:34 +00:00
unsafe
vendor all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
Make.dist
README.vendor
all.bash
all.bat
all.rc all.rc: pass arguments to make.rc 2020-04-20 04:53:46 +00:00
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
go.sum all: update vendored dependencies for Go 1.15 release 2020-05-04 22:52:07 +00:00
iostest.bash
make.bash
make.bat
make.rc
race.bash
race.bat
run.bash
run.bat
run.rc

README.vendor

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.